From patchwork Fri Nov 16 18:42:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 10686857 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BB2E017DE for ; Fri, 16 Nov 2018 18:44:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE12D2895F for ; Fri, 16 Nov 2018 18:44:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A279F28E12; Fri, 16 Nov 2018 18:44:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 547342895F for ; Fri, 16 Nov 2018 18:44:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389474AbeKQE5u (ORCPT ); Fri, 16 Nov 2018 23:57:50 -0500 Received: from mail-yb1-f195.google.com ([209.85.219.195]:38348 "EHLO mail-yb1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729497AbeKQE5u (ORCPT ); Fri, 16 Nov 2018 23:57:50 -0500 Received: by mail-yb1-f195.google.com with SMTP id u103-v6so10148187ybi.5 for ; Fri, 16 Nov 2018 10:44:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=S7QENO9uGwQfF5/vm8gh8vzZ+AOHJcmr1HQ/Kg7+ju4=; b=cUmgAQlBefAOfGlj9sSfXuUJ7D6/7N3HbOlUxuZ6SXPfb9eKc4VUlI/JnOUDaapvPJ 1caJAWOBFbZqqDWDvxLvmRdrjHw9gTJBjAZtKkBh8JhzMqaeCy0ukxtfATcsvUQAdMw+ f9H06GtZeiKS7SJdVXdH3b0Gapw69Mu8i8wnCdbEC/+WQP3U0Le5FGa4oP2MPybNF9jo C9dB8Fd6Ok7R83gL/uu7t35dAR4NCRkiXbLD4JtJIALP/gwyPcfRh1pAI439xNxU+ebk ABgOeAvI2wqw3cfu/54HB+XP4Lyo+9KX43VL26nlaPgdNLHIQHKEgrbexkonnJLqsD10 mf+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S7QENO9uGwQfF5/vm8gh8vzZ+AOHJcmr1HQ/Kg7+ju4=; b=NayUbFP3nY9IW1IrxBSZIJ2Ji45GMidQjkaXl97rVbLIeLXoGvy6OBJXLAvMmbf2Iv K2TjFoHdJME3/rXGDnejBGDA7BhFZ87/BR2fCkdwI/81+p+EgLfP2+7BX7RbVWx4h9YN jyMjwGFnOlINMnilqhXzYCdVMcrJFaQvTbfQUPydb3Y0XgBbjZrQR6WrSvJ9ofJgm0+X xtFzAvHFZ3AEN9OIG2q9btgWNNZEhpvWMDHztIxhTNJy0vtV6ZoDAM9m9A4hlBZ7LExB XdsPRgv7vxbf7DBFtrmYkiDAKg0/asS4EjVzQFvdO3Est4G5ImnVVHOP0revN+RUi8S3 3J9w== X-Gm-Message-State: AGRZ1gKNERf6Ilw8h8E9kVJgMHxrHRl14+w15U/Dyl3cpXuZ7TkPTajF 9zHmeUcSwFJmvxsepNJaz1Fydg== X-Google-Smtp-Source: AJdET5ebJ1+QrCVko9YPI1aSwvd8PkyRYJ/w9X6L/+SCusScU8UgfDOtfgULRpL7Em8KEZEDMXLZwQ== X-Received: by 2002:a25:2f83:: with SMTP id v125-v6mr11797320ybv.465.1542393857987; Fri, 16 Nov 2018 10:44:17 -0800 (PST) Received: from rosewood.cam.corp.google.com ([2620:0:1013:11:ad55:b1db:adfe:3b9f]) by smtp.gmail.com with ESMTPSA id b144sm5359134ywa.33.2018.11.16.10.44.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 10:44:17 -0800 (PST) From: Sean Paul To: dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Cc: robdclark@gmail.com, jsanka@codeaurora.org, Sean Paul Subject: [PATCH v2 21/24] drm/msm: dpu: Don't bother checking ->enabled in dpu_crtc_vblank Date: Fri, 16 Nov 2018 13:42:31 -0500 Message-Id: <20181116184238.170034-22-sean@poorly.run> X-Mailer: git-send-email 2.19.1.1215.g8438c0b245-goog In-Reply-To: <20181116184238.170034-1-sean@poorly.run> References: <20181116184238.170034-1-sean@poorly.run> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sean Paul The drm_crtc_vblank_on/off calls in enable/disable guarantee that we won't call this function when crtc is not enabled. Changes in v2: - None Signed-off-by: Sean Paul Reviewed-by: Jeykumar Sankaran --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c index 9efb41c7973b..54bb777b2d0c 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c @@ -1162,9 +1162,7 @@ int dpu_crtc_vblank(struct drm_crtc *crtc, bool en) mutex_lock(&dpu_crtc->crtc_lock); trace_dpu_crtc_vblank(DRMID(&dpu_crtc->base), en, dpu_crtc); - if (dpu_crtc->enabled) { - _dpu_crtc_vblank_enable_no_lock(dpu_crtc, en); - } + _dpu_crtc_vblank_enable_no_lock(dpu_crtc, en); dpu_crtc->vblank_requested = en; mutex_unlock(&dpu_crtc->crtc_lock);