From patchwork Thu Nov 22 12:50:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Balakrishna Godavarthi X-Patchwork-Id: 10694127 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A186D14BD for ; Thu, 22 Nov 2018 12:51:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 92E172C43E for ; Thu, 22 Nov 2018 12:51:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9143B2C78B; Thu, 22 Nov 2018 12:51:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SUBJ_OBFU_PUNCT_MANY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1A3312C734 for ; Thu, 22 Nov 2018 12:51:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403786AbeKVXaL (ORCPT ); Thu, 22 Nov 2018 18:30:11 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:37814 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388647AbeKVXaK (ORCPT ); Thu, 22 Nov 2018 18:30:10 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 47E2960712; Thu, 22 Nov 2018 12:50:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1542891057; bh=oNhIxjK5O7kpmeHNK1YUXPZoA0AcFe2A1HdQQx7ZPiI=; h=From:To:Cc:Subject:Date:From; b=egIVvpO60ORWGDVbJpsHIdmBJYtcyN7K2ZadWsNx551tmxT1xUDG8c12DrV+jsTrI 9iMhSOs0aVXvzIpokvoyGlKUIOGR+V2WzPgfxbMT3EzOsR9fNHzp4rcLbFS/keaHj6 a7kJHUIU7DVjVqS58HbMgoz1oqIJQnib/mxPXndI= Received: from bgodavar-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: bgodavar@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D7DAF60227; Thu, 22 Nov 2018 12:50:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1542891056; bh=oNhIxjK5O7kpmeHNK1YUXPZoA0AcFe2A1HdQQx7ZPiI=; h=From:To:Cc:Subject:Date:From; b=omsV550nTmounSTZsShVFI9Aqu665Nm1UWv6bMGGReLaJ39RZ6WWAQnPMKhyC3Kh0 a34+EesGY9LyY4n6BZoTrjFCSBy+IzVqWdb3owJhhU1wmNC91BJ41p/TF5gyEONg2m xcFAJGhiZev4ddyQBqyIy9R5pR/No5EgxSdiZzEE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D7DAF60227 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=bgodavar@codeaurora.org From: Balakrishna Godavarthi To: marcel@holtmann.org, johan.hedberg@gmail.com Cc: mka@chromium.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org, Balakrishna Godavarthi Subject: [PATCH v1] Bluetooth: hci_serdev: Remove setting of HCI_QUIRK_RESET_ON_CLOSE. Date: Thu, 22 Nov 2018 18:20:47 +0530 Message-Id: <20181122125047.725-1-bgodavar@codeaurora.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP HCI_QUIRK_RESET_ON_CLOSE quirk is required for BT v1.0 based devices, to send a reset command to the chip during hci device close. Serdev architecture is used for the latest BT chips, which doesn't require to send the reset command during close. If still chips required reset command during close, it would be better enabling it in the vendor probes or in proto setup. Signed-off-by: Balakrishna Godavarthi --- drivers/bluetooth/hci_serdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c index c445aa9ac511..490abba94363 100644 --- a/drivers/bluetooth/hci_serdev.c +++ b/drivers/bluetooth/hci_serdev.c @@ -333,9 +333,6 @@ int hci_uart_register_device(struct hci_uart *hu, if (test_bit(HCI_UART_EXT_CONFIG, &hu->hdev_flags)) set_bit(HCI_QUIRK_EXTERNAL_CONFIG, &hdev->quirks); - if (!test_bit(HCI_UART_RESET_ON_INIT, &hu->hdev_flags)) - set_bit(HCI_QUIRK_RESET_ON_CLOSE, &hdev->quirks); - if (test_bit(HCI_UART_CREATE_AMP, &hu->hdev_flags)) hdev->dev_type = HCI_AMP; else