| Message ID | 20181217100724.4593-1-sibis@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/7] dt-bindings: soc: qcom: Add remote-pid binding for GLINK SMEM | expand |
Hi, On Mon, Dec 17, 2018 at 2:07 AM Sibi Sankar <sibis@codeaurora.org> wrote: > > Add missing qcom,remote-pid dt binding required for GLINK SMEM > which specifies the remote endpoint of the GLINK edge. > > Signed-off-by: Sibi Sankar <sibis@codeaurora.org> > --- > Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt | 5 +++++ > 1 file changed, 5 insertions(+) Fixes: 2b41d6c8e696 ("dt-bindings: soc: qcom: Extend GLINK to cover SMEM") > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt > index 0b8cc533ca83..59ae603ba520 100644 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt > @@ -21,6 +21,11 @@ edge. > Definition: should specify the IRQ used by the remote processor to > signal this processor about communication related events > > +- qcom,remote-pid: > + Usage: required for glink-smem > + Value type: <u32> > + Definition: specifies the identfier of the remote endpoint of this edge s/identfier/identifier/ Other than the typo this seems right to me. Feel free to add my Reviewed-by tag when that's fixed. -Doug
Hi Doug, Thanks for the review :) On 2018-12-18 05:29, Doug Anderson wrote: > Hi, > > On Mon, Dec 17, 2018 at 2:07 AM Sibi Sankar <sibis@codeaurora.org> > wrote: >> >> Add missing qcom,remote-pid dt binding required for GLINK SMEM >> which specifies the remote endpoint of the GLINK edge. >> >> Signed-off-by: Sibi Sankar <sibis@codeaurora.org> >> --- >> Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt | 5 +++++ >> 1 file changed, 5 insertions(+) > > Fixes: 2b41d6c8e696 ("dt-bindings: soc: qcom: Extend GLINK to cover > SMEM") > > >> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt >> b/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt >> index 0b8cc533ca83..59ae603ba520 100644 >> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt >> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt >> @@ -21,6 +21,11 @@ edge. >> Definition: should specify the IRQ used by the remote >> processor to >> signal this processor about communication related >> events >> >> +- qcom,remote-pid: >> + Usage: required for glink-smem >> + Value type: <u32> >> + Definition: specifies the identfier of the remote endpoint of >> this edge > > s/identfier/identifier/ > missed this, will correct it in v3. > > Other than the typo this seems right to me. Feel free to add my > Reviewed-by tag when that's fixed. > > > -Doug
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt index 0b8cc533ca83..59ae603ba520 100644 --- a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt @@ -21,6 +21,11 @@ edge. Definition: should specify the IRQ used by the remote processor to signal this processor about communication related events +- qcom,remote-pid: + Usage: required for glink-smem + Value type: <u32> + Definition: specifies the identfier of the remote endpoint of this edge + - qcom,rpm-msg-ram: Usage: required for glink-rpm Value type: <prop-encoded-array>
Add missing qcom,remote-pid dt binding required for GLINK SMEM which specifies the remote endpoint of the GLINK edge. Signed-off-by: Sibi Sankar <sibis@codeaurora.org> --- Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt | 5 +++++ 1 file changed, 5 insertions(+)