From patchwork Mon Jan 7 12:07:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Gautam X-Patchwork-Id: 10750477 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3109813AD for ; Mon, 7 Jan 2019 12:07:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2039428A38 for ; Mon, 7 Jan 2019 12:07:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1417328A3C; Mon, 7 Jan 2019 12:07:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8276C28A38 for ; Mon, 7 Jan 2019 12:07:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726614AbfAGMHW (ORCPT ); Mon, 7 Jan 2019 07:07:22 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:47592 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726589AbfAGMHV (ORCPT ); Mon, 7 Jan 2019 07:07:21 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E91316092B; Mon, 7 Jan 2019 12:07:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1546862840; bh=nQdhMg/zxfqtrScSfOLq5awV0rQd/TXDzDgONYXtPN8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LEUl+L0A+d3IbYCgZgnZpAR7UgW6PQ0q+FEIn47fuduhOQs1LxH9Vgg6K3nU10zL/ zcu5VQ76aZuAkvqXIZo1j/mPibUGxhKUtjiDm9WNqtmE+1mIf71KQlj4QyCM4BWC0w fyk3WaVwwb6ekvJXdPvVPMMVw2GD2u73LI2hEY04= Received: from blr-ubuntu-41.ap.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: vivek.gautam@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D09A26087B; Mon, 7 Jan 2019 12:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1546862839; bh=nQdhMg/zxfqtrScSfOLq5awV0rQd/TXDzDgONYXtPN8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QMzcsjX6ff+Tr1v8kPZxHc11Xn25gjrpML0uZIROZAW0Dcb4sR5n0qCErRbhjb5YZ tYGoc4Wvi+YcL4E1tZMNevtlhm94CF+4JPwDTLV8gg/ZFy6/+/8KdJc1zEB7UypR4j dCRqqrz+8+D7IKhuGMZvhiMu+f4yOIKkHSBDYE1s= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D09A26087B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org From: Vivek Gautam To: sean@poorly.run, airlied@linux.ie, dri-devel@lists.freedesktop.org Cc: maarten.lankhorst@linux.intel.com, maxime.ripard@bootlin.com, daniel@ffwll.ch, robdclark@gmail.com, jcrouse@codeaurora.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Vivek Gautam Subject: [PATCH v2 1/1] drm/prime: Use sg_dma_len() macro to get sg's length Date: Mon, 7 Jan 2019 17:37:08 +0530 Message-Id: <20190107120708.18497-1-vivek.gautam@codeaurora.org> X-Mailer: git-send-email 2.16.1.72.g5be1f00a9a70 In-Reply-To: References: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP After mapping a sg list the we should use sg_dma_address() and sg_dma_len() macros to access sg->address and sg->length. Fix the same for sg->length in drm_prime_sg_to_page_addr_arrays(). Signed-off-by: Vivek Gautam --- Changes since v1: - Fixed compilation error: replaced sg_dma_length() with sg_dma_len(). This came while debugging one dmabuf import issue that we are seeing on sdm845 target. The dmabuf which is prepared by video (venus in this case), is imported by drm device. The import call flow looks like follows: drm_gem_prime_import() - drm_gem_prime_import_dev() - dma_buf_attach() & dma_buf_map_attachment() - From dma_buf_map_attachment() - vb2_dma_sg_dmabuf_ops_map() - dma_map_sg(): this updates the sg->nents. From debugging, the sg table mapping results in sg's 'nents' to be less that the original nents. Now drm device prepares the page information based on this sg table, and messes up with the mappings, and we start seeing random crashes as below from drm's memory space. Although this change isn't helping to fix the issue currently, but this fix seems the right thing to do. One thing to notice is that, if we restore the sg->nents to sg->orig_nents in vb2_dma_sg_dmabuf_ops_map(), we don't see the below corruptions. Any pointers on this will be highly appreciated. Thanks. ------ [ 338.070558] Unable to handle kernel paging request at virtual address 0000400000000038 [ 338.078751] Mem abort info: [ 338.081671] ESR = 0x96000004 [ 338.084860] Exception class = DABT (current EL), IL = 32 bits [ 338.090972] SET = 0, FnV = 0 [ 338.094139] EA = 0, S1PTW = 0 [ 338.097393] Data abort info: [ 338.100375] ISV = 0, ISS = 0x00000004 [ 338.104362] CM = 0, WnR = 0 [ 338.107446] [0000400000000038] address between user and kernel address ranges [ 338.114801] Internal error: Oops: 96000004 [#1] PREEMPT SMP [ 338.120527] Modules linked in: rfcomm uinput cdc_ether venus_dec venus_enc usbnet videobuf2_dma_sg videobuf2_memops hci_uart btqca bluetooth r8152 mii ath10k_snoc venus_core ath10k_core v4l2_mem2mem videobuf2_v4l2 videobuf2_common ath mac80211 ecdh_generic qcom_q6v5_mss lzo lzo_compress qcom_q6v5_adsp qcom_common qcom_q6v5 zram bridge stp llc ipt_MASQUERADE fuse snd_seq_dummy snd_seq snd_seq_device cfg80211 joydev [ 338.158192] CPU: 4 PID: 3235 Comm: chrome Tainted: G W 4.19.0 #2 [ 338.165700] Hardware name: Google Cheza (rev1) (DT) [ 338.170720] pstate: 80400009 (Nzcv daif +PAN -UAO) [ 338.175660] pc : drm_mm_insert_node_in_range+0xfc/0x348 [ 338.181035] lr : drm_mm_insert_node_in_range+0x24/0x348 [ 338.186407] sp : ffffff8013033b30 [ 338.189816] x29: ffffff8013033bd0 x28: ffffff8008591894 [ 338.195275] x27: 0000000000000010 x26: 0000000000000000 [ 338.200734] x25: 0000000000000000 x24: ffffffffffffffff [ 338.206194] x23: 0000000000000000 x22: ffffffc0f48b7e08 [ 338.211656] x21: 0000000000000000 x20: 000000000000005d [ 338.217118] x19: 0000000000000000 x18: 0000000000000000 [ 338.222581] x17: 0000000000000000 x16: 0000000000000000 [ 338.228046] x15: 0000000000000000 x14: 0000000000000000 [ 338.233511] x13: 0000000000000001 x12: ffffffc0b1da7200 [ 338.238978] x11: 0000000000000010 x10: 0000000000000010 [ 338.244437] x9 : 0000000000000008 x8 : 0000400000000000 [ 338.249898] x7 : 0000000000000000 x6 : ffffffffffffffff [ 338.255361] x5 : 0000000000000000 x4 : 0000000000000000 [ 338.260823] x3 : 0000000000000000 x2 : 000000000000005d [ 338.266285] x1 : ffffffc0b1da7100 x0 : ffffffc0b0215800 [ 338.271748] Process chrome (pid: 3235, stack limit = 0x000000000900f416) [ 338.278628] Call trace: [ 338.281151] drm_mm_insert_node_in_range+0xfc/0x348 [ 338.286168] msm_gem_map_vma+0x60/0xdc [ 338.290022] msm_gem_get_iova+0xb4/0xf4 [ 338.293967] msm_ioctl_gem_info+0x90/0xdc [ 338.298089] drm_ioctl_kernel+0xa8/0xe8 [ 338.302043] drm_ioctl+0x218/0x384 [ 338.305547] drm_compat_ioctl+0xd8/0xe8 [ 338.309503] __arm64_compat_sys_ioctl+0x134/0x20c [ 338.314339] el0_svc_common+0xa0/0xf0 [ 338.318108] el0_svc_compat_handler+0x2c/0x38 [ 338.322588] el0_svc_compat+0x8/0x18 [ 338.326274] Code: f94066c8 aa1f03e0 321d03e9 321c03ea (f9401d0b) [ 338.332538] ---[ end trace 5c09e60869887d87 ]--- [ 338.354633] Kernel panic - not syncing: Fatal exception [ 338.360018] SMP: stopping secondary CPUs [ 338.364179] Kernel Offset: disabled [ 338.367779] CPU features: 0x0,22802a18 [ 338.371643] Memory Limit: none ------ drivers/gpu/drm/drm_prime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c index 231e3f6d5f41..aa87ba9c0d7b 100644 --- a/drivers/gpu/drm/drm_prime.c +++ b/drivers/gpu/drm/drm_prime.c @@ -945,7 +945,7 @@ int drm_prime_sg_to_page_addr_arrays(struct sg_table *sgt, struct page **pages, index = 0; for_each_sg(sgt->sgl, sg, sgt->nents, count) { - len = sg->length; + len = sg_dma_len(sg); page = sg_page(sg); addr = sg_dma_address(sg);