From patchwork Thu Jan 24 13:00:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 10778919 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 22839746 for ; Thu, 24 Jan 2019 13:01:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 11E502F095 for ; Thu, 24 Jan 2019 13:01:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0614C2F1F9; Thu, 24 Jan 2019 13:01:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5AE952F1EB for ; Thu, 24 Jan 2019 13:01:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728023AbfAXNBM (ORCPT ); Thu, 24 Jan 2019 08:01:12 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:35835 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728253AbfAXNBL (ORCPT ); Thu, 24 Jan 2019 08:01:11 -0500 Received: by mail-lj1-f195.google.com with SMTP id x85-v6so5162990ljb.2 for ; Thu, 24 Jan 2019 05:01:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g+TtSy60AE5xODphXFL+46GqeLVir41c6n923ZIZoIg=; b=LU7rIQ0nMKaAs0DboQfj/1yr260XzcrEkZ16XvOWXQJ/4LbZwOy6yQi8x6Nz4MvM2M Hp+RK2+bGbjx2sw6/Fce9yUI017KU6dboVacGvoLQMof1hXsIf1XjAIKlGsEU8aGcOvf DyqX7s8d6vnfXfQYnSK4vrfop4944Z8PFLO74= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g+TtSy60AE5xODphXFL+46GqeLVir41c6n923ZIZoIg=; b=gGEykerKKCNbxrb7I3JG+QUjBAqTECkTEB7986eO9iRwgdZzXV4JGEWzkgVJrq+k34 e+BXNzs1wJ33uZqjtyPUfq7IFMEQaTiw5YdTnMrMPU3hordIei+CUIMDOqyPSp0s+AIc vYK7eyfM+64mYpUZAj1aza5q1lSKHf+yITVKbmBT5Up9tXV0HcOTPhvCeHHdPZCIC0TI FOO7QhjttphTCzIk67eaQ+7vjUXE1io0qniUZXyNaoE6RgOaBQS8ACEJ1hSHFhAodUQT 7ddWR2++qNmxMRme5c2Q5H2M0tGev96MgNpK0oY3mKTiTvBkFov4YLzWH0NVCaPxRHdg 114Q== X-Gm-Message-State: AJcUukcwwkT6ZzOOruDZFBQ2u4geT2F/BoHKBzQz1/od1Wm98ZC9DFIZ Bzx8sqx+0xU1kDB1AXjTquG6hgdAW2U= X-Google-Smtp-Source: ALg8bN44TRzK5qm0kHqkqnlkwr6hrW2wIh4z0XlCQFjzJLVw8hGz2pSyleKMUK8Z6ezUuGVHasHC/w== X-Received: by 2002:a2e:9e95:: with SMTP id f21-v6mr5394238ljk.128.1548334869471; Thu, 24 Jan 2019 05:01:09 -0800 (PST) Received: from centauri.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id 12-v6sm967803ljf.96.2019.01.24.05.01.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 Jan 2019 05:01:08 -0800 (PST) From: Niklas Cassel To: Andy Gross , David Brown , Rob Herring , Mark Rutland Cc: Niklas Cassel , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: dts: qcom: ipq4019: Fix MSI IRQ type Date: Thu, 24 Jan 2019 14:00:47 +0100 Message-Id: <20190124130047.8071-1-niklas.cassel@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The databook clearly states that the MSI IRQ (msi_ctrl_int) is a level triggered interrupt. The msi_ctrl_int will be high for as long as any MSI status bit is set, thus the IRQ type should be set to IRQ_TYPE_LEVEL_HIGH, causing the IRQ handler to keep getting called, as long as any MSI status bit is set. A git grep shows that ipq4019 is the only SoC using snps,dw-pcie that has configured this IRQ incorrectly. Not having the correct IRQ type defined will cause us to lose interrupts, which in turn causes timeouts in the PCIe endpoint drivers. Signed-off-by: Niklas Cassel Reviewed-by: Bjorn Andersson --- arch/arm/boot/dts/qcom-ipq4019.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi index 19635f91e2c4..48b3cb474ba0 100644 --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi @@ -398,7 +398,7 @@ ranges = <0x81000000 0 0x40200000 0x40200000 0 0x00100000 0x82000000 0 0x40300000 0x40300000 0 0x400000>; - interrupts = ; + interrupts = ; interrupt-names = "msi"; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0x7>;