| Message ID | 20190218101853.4290-1-vkoul@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] net: phy: at803x: dont inline helpers | expand |
On Mon, Feb 18, 2019 at 03:48:52PM +0530, Vinod Koul wrote: > Some helpers were inlined, but makes more sense to allow compiler > to do the right optiomazations instead, so remove inline for > at803x_disable_rx_delay() and at803x_disable_tx_delay() > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > drivers/net/phy/at803x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c > index 8ff12938ab47..c6e7d800fd7a 100644 > --- a/drivers/net/phy/at803x.c > +++ b/drivers/net/phy/at803x.c > @@ -110,13 +110,13 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg, > return phy_write(phydev, AT803X_DEBUG_DATA, val); > } > > -static inline int at803x_disable_rx_delay(struct phy_device *phydev) > +static int at803x_disable_rx_delay(struct phy_device *phydev) > { > return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, > AT803X_DEBUG_RX_CLK_DLY_EN, 0); > } > > -static inline int at803x_disable_tx_delay(struct phy_device *phydev) > +static int at803x_disable_tx_delay(struct phy_device *phydev) > { > return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5, > AT803X_DEBUG_TX_CLK_DLY_EN, 0); > -- > 2.20.1 > Reviewed-by: Niklas Cassel <niklas.cassel@linaro.org>
From: Vinod Koul <vkoul@kernel.org> Date: Mon, 18 Feb 2019 15:48:52 +0530 > Some helpers were inlined, but makes more sense to allow compiler > to do the right optiomazations instead, so remove inline for > at803x_disable_rx_delay() and at803x_disable_tx_delay() > > Signed-off-by: Vinod Koul <vkoul@kernel.org> Two problem with this patch series. 1) It fixes a bug in 'net' but the patches only apply cleanly to 'net-next'. Please respin this against 'net'. 2) This series lacks a header posting "[PATCH vX 0/N] " which explains at a high level what the series is doing, how it is doing it, and why it is doing it that way. Thanks.
Hello Dave, On 18-02-19, 16:28, David Miller wrote: > From: Vinod Koul <vkoul@kernel.org> > Date: Mon, 18 Feb 2019 15:48:52 +0530 > > > Some helpers were inlined, but makes more sense to allow compiler > > to do the right optiomazations instead, so remove inline for > > at803x_disable_rx_delay() and at803x_disable_tx_delay() > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > Two problem with this patch series. > > 1) It fixes a bug in 'net' but the patches only apply cleanly to > 'net-next'. Please respin this against 'net'. I assume the 'net' is fixes going into current -rcX. This fixes issues reported on linux-next due to patches in net-next, so these fixes should go to net-next as well. > 2) This series lacks a header posting "[PATCH vX 0/N] " which > explains at a high level what the series is doing, how it is > doing it, and why it is doing it that way. Sure I will add this and repost Thanks
Hi Vinod, On 19/02/19 10:32 AM, Vinod Koul wrote: > Hello Dave, > > On 18-02-19, 16:28, David Miller wrote: >> From: Vinod Koul <vkoul@kernel.org> >> Date: Mon, 18 Feb 2019 15:48:52 +0530 >> >>> Some helpers were inlined, but makes more sense to allow compiler >>> to do the right optiomazations instead, so remove inline for >>> at803x_disable_rx_delay() and at803x_disable_tx_delay() >>> >>> Signed-off-by: Vinod Koul <vkoul@kernel.org> >> >> Two problem with this patch series. >> >> 1) It fixes a bug in 'net' but the patches only apply cleanly to >> 'net-next'. Please respin this against 'net'. > > I assume the 'net' is fixes going into current -rcX. This fixes issues > reported on linux-next due to patches in net-next, so these fixes should > go to net-next as well. net-next should be part of subject prefix in this case. See Documentation/networking/netdev-FAQ.rst Thanks, Sekhar
On 19-02-19, 11:05, Sekhar Nori wrote: > Hi Vinod, > > On 19/02/19 10:32 AM, Vinod Koul wrote: > > Hello Dave, > > > > On 18-02-19, 16:28, David Miller wrote: > >> From: Vinod Koul <vkoul@kernel.org> > >> Date: Mon, 18 Feb 2019 15:48:52 +0530 > >> > >>> Some helpers were inlined, but makes more sense to allow compiler > >>> to do the right optiomazations instead, so remove inline for > >>> at803x_disable_rx_delay() and at803x_disable_tx_delay() > >>> > >>> Signed-off-by: Vinod Koul <vkoul@kernel.org> > >> > >> Two problem with this patch series. > >> > >> 1) It fixes a bug in 'net' but the patches only apply cleanly to > >> 'net-next'. Please respin this against 'net'. > > > > I assume the 'net' is fixes going into current -rcX. This fixes issues > > reported on linux-next due to patches in net-next, so these fixes should > > go to net-next as well. > > net-next should be part of subject prefix in this case. See > Documentation/networking/netdev-FAQ.rst Thanks for the pointer Sekhar, will do :)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index 8ff12938ab47..c6e7d800fd7a 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -110,13 +110,13 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg, return phy_write(phydev, AT803X_DEBUG_DATA, val); } -static inline int at803x_disable_rx_delay(struct phy_device *phydev) +static int at803x_disable_rx_delay(struct phy_device *phydev) { return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, AT803X_DEBUG_RX_CLK_DLY_EN, 0); } -static inline int at803x_disable_tx_delay(struct phy_device *phydev) +static int at803x_disable_tx_delay(struct phy_device *phydev) { return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5, AT803X_DEBUG_TX_CLK_DLY_EN, 0);
Some helpers were inlined, but makes more sense to allow compiler to do the right optiomazations instead, so remove inline for at803x_disable_rx_delay() and at803x_disable_tx_delay() Signed-off-by: Vinod Koul <vkoul@kernel.org> --- drivers/net/phy/at803x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)