diff mbox series

[v2] net: dsa: read mac address from DT for slave device

Message ID 20190329053458.11891-1-vkoul@kernel.org (mailing list archive)
State New, archived
Headers show
Series [v2] net: dsa: read mac address from DT for slave device | expand

Commit Message

Vinod Koul March 29, 2019, 5:34 a.m. UTC 
From: Xiaofei Shen <xiaofeis@codeaurora.org>

Before creating a slave netdevice, get the mac address from DTS and
apply in case it is valid.

Signed-off-by: Xiaofei Shen <xiaofeis@codeaurora.org>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---

v2: Rebase on net-next. The binding patch is already merged

 include/net/dsa.h | 1 +
 net/dsa/dsa2.c    | 1 +
 net/dsa/slave.c   | 5 ++++-
 3 files changed, 6 insertions(+), 1 deletion(-)

Comments

David Miller April 1, 2019, 9:57 p.m. UTC | #1 
From: Vinod Koul <vkoul@kernel.org>
Date: Fri, 29 Mar 2019 11:04:58 +0530

> From: Xiaofei Shen <xiaofeis@codeaurora.org>
> 
> Before creating a slave netdevice, get the mac address from DTS and
> apply in case it is valid.
> 
> Signed-off-by: Xiaofei Shen <xiaofeis@codeaurora.org>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> 
> v2: Rebase on net-next. The binding patch is already merged

Applied.
diff mbox series

Patch

diff --git a/include/net/dsa.h b/include/net/dsa.h
index ae480bba11f5..0cfc2f828b87 100644
--- a/include/net/dsa.h
+++ b/include/net/dsa.h
@@ -140,6 +140,7 @@  struct dsa_port {
 	unsigned int		index;
 	const char		*name;
 	const struct dsa_port	*cpu_dp;
+	const char		*mac;
 	struct device_node	*dn;
 	unsigned int		ageing_time;
 	u8			stp_state;
diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
index fe0a6197db9c..0e1cce460406 100644
--- a/net/dsa/dsa2.c
+++ b/net/dsa/dsa2.c
@@ -266,6 +266,7 @@  static int dsa_port_setup(struct dsa_port *dp)
 		return 0;
 
 	memset(&dp->devlink_port, 0, sizeof(dp->devlink_port));
+	dp->mac = of_get_mac_address(dp->dn);
 
 	switch (dp->type) {
 	case DSA_PORT_TYPE_CPU:
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 093eef6f2599..9e4208140142 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -1378,7 +1378,10 @@  int dsa_slave_create(struct dsa_port *port)
 				NETIF_F_HW_VLAN_CTAG_FILTER;
 	slave_dev->hw_features |= NETIF_F_HW_TC;
 	slave_dev->ethtool_ops = &dsa_slave_ethtool_ops;
-	eth_hw_addr_inherit(slave_dev, master);
+	if (port->mac && is_valid_ether_addr(port->mac))
+		ether_addr_copy(slave_dev->dev_addr, port->mac);
+	else
+		eth_hw_addr_inherit(slave_dev, master);
 	slave_dev->priv_flags |= IFF_NO_QUEUE;
 	slave_dev->netdev_ops = &dsa_slave_netdev_ops;
 	slave_dev->min_mtu = 0;