| Message ID | 20190402161256.11044-5-daniel.lezcano@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Tue, Apr 2, 2019 at 11:14 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > The dependency on the THERMAL option to be set is already there implicitly > by the "if THERMAL" conditionnal option. The sub Kconfigs do not have to > check against the THERMAL option as they are called from a Kconfig block > which is enabled by the conditionnal option. > > Remove the useless "depends on THERMAL" in the Kconfigs. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > drivers/thermal/Kconfig | 2 -- > drivers/thermal/intel/Kconfig | 1 - > drivers/thermal/qcom/Kconfig | 1 - > 3 files changed, 4 deletions(-) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index ccf5b9408d7a..d8aa7fac8c56 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -24,7 +24,6 @@ config THERMAL_STATISTICS > > config THERMAL_EMERGENCY_POWEROFF_DELAY_MS > int "Emergency poweroff delay in milli-seconds" > - depends on THERMAL > default 0 > help > Thermal subsystem will issue a graceful shutdown when > @@ -152,7 +151,6 @@ config CPU_THERMAL > bool "generic cpu cooling support" > depends on CPU_FREQ > depends on THERMAL_OF > - depends on THERMAL=y This will break the intention of afa1f2ab43d48d0e1. At the moment, we need THERMAL=y if we want cpu_cooling. > help > This implements the generic cpu cooling mechanism through frequency > reduction. An ACPI version of this already exists > diff --git a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig > index 2e013eeb4a1d..2c727a820759 100644 > --- a/drivers/thermal/intel/Kconfig > +++ b/drivers/thermal/intel/Kconfig > @@ -1,6 +1,5 @@ > config INTEL_POWERCLAMP > tristate "Intel PowerClamp idle injection driver" > - depends on THERMAL > depends on X86 > depends on CPU_SUP_INTEL > help > diff --git a/drivers/thermal/qcom/Kconfig b/drivers/thermal/qcom/Kconfig > index cdb455ffd575..3ce20fec86a2 100644 > --- a/drivers/thermal/qcom/Kconfig > +++ b/drivers/thermal/qcom/Kconfig > @@ -1,6 +1,5 @@ > config QCOM_TSENS > tristate "Qualcomm TSENS Temperature Alarm" > - depends on THERMAL > depends on QCOM_QFPROM > depends on ARCH_QCOM || COMPILE_TEST > help > -- > 2.17.1 >
Hi Amit, On 02/04/2019 20:51, Amit Kucheria wrote: > On Tue, Apr 2, 2019 at 11:14 PM Daniel Lezcano > <daniel.lezcano@linaro.org> wrote: >> >> The dependency on the THERMAL option to be set is already there implicitly >> by the "if THERMAL" conditionnal option. The sub Kconfigs do not have to >> check against the THERMAL option as they are called from a Kconfig block >> which is enabled by the conditionnal option. >> >> Remove the useless "depends on THERMAL" in the Kconfigs. >> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >> --- >> drivers/thermal/Kconfig | 2 -- >> drivers/thermal/intel/Kconfig | 1 - >> drivers/thermal/qcom/Kconfig | 1 - >> 3 files changed, 4 deletions(-) >> >> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig >> index ccf5b9408d7a..d8aa7fac8c56 100644 >> --- a/drivers/thermal/Kconfig >> +++ b/drivers/thermal/Kconfig >> @@ -24,7 +24,6 @@ config THERMAL_STATISTICS >> >> config THERMAL_EMERGENCY_POWEROFF_DELAY_MS >> int "Emergency poweroff delay in milli-seconds" >> - depends on THERMAL >> default 0 >> help >> Thermal subsystem will issue a graceful shutdown when >> @@ -152,7 +151,6 @@ config CPU_THERMAL >> bool "generic cpu cooling support" >> depends on CPU_FREQ >> depends on THERMAL_OF >> - depends on THERMAL=y > > This will break the intention of afa1f2ab43d48d0e1. At the moment, we > need THERMAL=y if we want cpu_cooling. The patch 1/7 changes the thermal option from tristate to bool, so the thermal is compiled-in always. The dependency is no longer needed in this case. Did I miss something?
On Wed, Apr 3, 2019 at 9:03 AM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > Hi Amit, > > On 02/04/2019 20:51, Amit Kucheria wrote: > > On Tue, Apr 2, 2019 at 11:14 PM Daniel Lezcano > > <daniel.lezcano@linaro.org> wrote: > >> > >> The dependency on the THERMAL option to be set is already there implicitly > >> by the "if THERMAL" conditionnal option. The sub Kconfigs do not have to > >> check against the THERMAL option as they are called from a Kconfig block > >> which is enabled by the conditionnal option. > >> > >> Remove the useless "depends on THERMAL" in the Kconfigs. > >> > >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > >> --- > >> drivers/thermal/Kconfig | 2 -- > >> drivers/thermal/intel/Kconfig | 1 - > >> drivers/thermal/qcom/Kconfig | 1 - > >> 3 files changed, 4 deletions(-) > >> > >> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > >> index ccf5b9408d7a..d8aa7fac8c56 100644 > >> --- a/drivers/thermal/Kconfig > >> +++ b/drivers/thermal/Kconfig > >> @@ -24,7 +24,6 @@ config THERMAL_STATISTICS > >> > >> config THERMAL_EMERGENCY_POWEROFF_DELAY_MS > >> int "Emergency poweroff delay in milli-seconds" > >> - depends on THERMAL > >> default 0 > >> help > >> Thermal subsystem will issue a graceful shutdown when > >> @@ -152,7 +151,6 @@ config CPU_THERMAL > >> bool "generic cpu cooling support" > >> depends on CPU_FREQ > >> depends on THERMAL_OF > >> - depends on THERMAL=y > > > > This will break the intention of afa1f2ab43d48d0e1. At the moment, we > > need THERMAL=y if we want cpu_cooling. > > The patch 1/7 changes the thermal option from tristate to bool, so the > thermal is compiled-in always. The dependency is no longer needed in > this case. Did I miss something? Sorry, the threading of this series was a bit strange and there was no cover letter. I wasn't cc'ed on the other patches, so missed the earlier changes. This series looks good. FWIW, Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index ccf5b9408d7a..d8aa7fac8c56 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -24,7 +24,6 @@ config THERMAL_STATISTICS config THERMAL_EMERGENCY_POWEROFF_DELAY_MS int "Emergency poweroff delay in milli-seconds" - depends on THERMAL default 0 help Thermal subsystem will issue a graceful shutdown when @@ -152,7 +151,6 @@ config CPU_THERMAL bool "generic cpu cooling support" depends on CPU_FREQ depends on THERMAL_OF - depends on THERMAL=y help This implements the generic cpu cooling mechanism through frequency reduction. An ACPI version of this already exists diff --git a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig index 2e013eeb4a1d..2c727a820759 100644 --- a/drivers/thermal/intel/Kconfig +++ b/drivers/thermal/intel/Kconfig @@ -1,6 +1,5 @@ config INTEL_POWERCLAMP tristate "Intel PowerClamp idle injection driver" - depends on THERMAL depends on X86 depends on CPU_SUP_INTEL help diff --git a/drivers/thermal/qcom/Kconfig b/drivers/thermal/qcom/Kconfig index cdb455ffd575..3ce20fec86a2 100644 --- a/drivers/thermal/qcom/Kconfig +++ b/drivers/thermal/qcom/Kconfig @@ -1,6 +1,5 @@ config QCOM_TSENS tristate "Qualcomm TSENS Temperature Alarm" - depends on THERMAL depends on QCOM_QFPROM depends on ARCH_QCOM || COMPILE_TEST help
The dependency on the THERMAL option to be set is already there implicitly by the "if THERMAL" conditionnal option. The sub Kconfigs do not have to check against the THERMAL option as they are called from a Kconfig block which is enabled by the conditionnal option. Remove the useless "depends on THERMAL" in the Kconfigs. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- drivers/thermal/Kconfig | 2 -- drivers/thermal/intel/Kconfig | 1 - drivers/thermal/qcom/Kconfig | 1 - 3 files changed, 4 deletions(-)