| Message ID | 20190817082520.7751-1-alex.dewar@gmx.co.uk (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Andy Gross |
| Headers | show |
| Series | pinctrl/qcom: Fix -Wimplicit-fallthrough | expand |
On Sat 17 Aug 01:25 PDT 2019, Alex Dewar wrote: > In pinctrl-spmi-gpio.c there is a switch case which is obviously > intended to fall through to the next label. Add a comment to suppress > -Wimplicit-fallthrough warning. > Thanks for your patch Alex, this was fixed in 6161dc03587b ("pinctrl: qcom: spmi-gpio: Mark expected switch fall-through") Regards, Bjorn > Signed-off-by: Alex Dewar <alex.dewar@gmx.co.uk> > --- > drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > index f39da87ea185..b035dd5e25b8 100644 > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > @@ -813,6 +813,7 @@ static int pmic_gpio_populate(struct pmic_gpio_state *state, > switch (subtype) { > case PMIC_GPIO_SUBTYPE_GPIO_4CH: > pad->have_buffer = true; > + /* FALLS THROUGH */ > case PMIC_GPIO_SUBTYPE_GPIOC_4CH: > pad->num_sources = 4; > break; > -- > 2.22.1 >
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index f39da87ea185..b035dd5e25b8 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -813,6 +813,7 @@ static int pmic_gpio_populate(struct pmic_gpio_state *state, switch (subtype) { case PMIC_GPIO_SUBTYPE_GPIO_4CH: pad->have_buffer = true; + /* FALLS THROUGH */ case PMIC_GPIO_SUBTYPE_GPIOC_4CH: pad->num_sources = 4; break;
In pinctrl-spmi-gpio.c there is a switch case which is obviously intended to fall through to the next label. Add a comment to suppress -Wimplicit-fallthrough warning. Signed-off-by: Alex Dewar <alex.dewar@gmx.co.uk> --- drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 + 1 file changed, 1 insertion(+) -- 2.22.1