diff mbox series

[RFC,v2,3/5] ARM: dts: qcom: pm8941: add 5vs2 regulator node

Message ID 20191007014509.25180-4-masneyb@onstation.org (mailing list archive)
State New, archived
Headers show
Series drm/msm: external HDMI support for Nexus 5 phone | expand

Commit Message

Brian Masney Oct. 7, 2019, 1:45 a.m. UTC
pm8941 is missing the 5vs2 regulator node so let's add it since its
needed to get the external display working. This regulator was already
configured in the interrupts property on the parent node.

Note that this regulator is referred to as mvs2 in the downstream MSM
kernel sources.

Signed-off-by: Brian Masney <masneyb@onstation.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
---
Changes since v1:
- None

 arch/arm/boot/dts/qcom-pm8941.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Bjorn Andersson Oct. 7, 2019, 5:48 a.m. UTC | #1
On Sun 06 Oct 18:45 PDT 2019, Brian Masney wrote:

> pm8941 is missing the 5vs2 regulator node so let's add it since its
> needed to get the external display working. This regulator was already
> configured in the interrupts property on the parent node.
> 
> Note that this regulator is referred to as mvs2 in the downstream MSM
> kernel sources.
> 
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Picked this patch for now, once the driver updates are landed I will
take the last two dts patches.

Regards,
Bjorn

> ---
> Changes since v1:
> - None
> 
>  arch/arm/boot/dts/qcom-pm8941.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
> index f198480c8ef4..c1f2012d1c8b 100644
> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> @@ -178,6 +178,16 @@
>  				qcom,vs-soft-start-strength = <0>;
>  				regulator-initial-mode = <1>;
>  			};
> +
> +			pm8941_5vs2: 5vs2 {
> +				regulator-enable-ramp-delay = <1000>;
> +				regulator-pull-down;
> +				regulator-over-current-protection;
> +				qcom,ocp-max-retries = <10>;
> +				qcom,ocp-retry-delay = <30>;
> +				qcom,vs-soft-start-strength = <0>;
> +				regulator-initial-mode = <1>;
> +			};
>  		};
>  	};
>  };
> -- 
> 2.21.0
>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
index f198480c8ef4..c1f2012d1c8b 100644
--- a/arch/arm/boot/dts/qcom-pm8941.dtsi
+++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
@@ -178,6 +178,16 @@ 
 				qcom,vs-soft-start-strength = <0>;
 				regulator-initial-mode = <1>;
 			};
+
+			pm8941_5vs2: 5vs2 {
+				regulator-enable-ramp-delay = <1000>;
+				regulator-pull-down;
+				regulator-over-current-protection;
+				qcom,ocp-max-retries = <10>;
+				qcom,ocp-retry-delay = <30>;
+				qcom,vs-soft-start-strength = <0>;
+				regulator-initial-mode = <1>;
+			};
 		};
 	};
 };