| Message ID | 20200211005059.1377279-5-bjorn.andersson@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | remoteproc: qcom: post mortem debug support | expand |
Quoting Bjorn Andersson (2020-02-10 16:50:55) > diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi > index 4ee1e3d5f123..f539293b875c 100644 > --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi > @@ -997,6 +997,19 @@ blsp2_spi0: spi@7af5000 { > status = "disabled"; > }; > > + imem@8600000 { > + compatible = "syscon", "simple-mfd"; > + reg = <0x08600000 0x1000>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + > + pil-reloc@94c { > + compatible ="qcom,pil-reloc-info"; > + reg = <0x94c 200>; Is it 200 in decimal? It looks weird that this is basically the only thing that isn't in hexadecimal. > + }; > + }; > +
On Thu 13 Feb 18:37 PST 2020, Stephen Boyd wrote: > Quoting Bjorn Andersson (2020-02-10 16:50:55) > > diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi > > index 4ee1e3d5f123..f539293b875c 100644 > > --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi > > +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi > > @@ -997,6 +997,19 @@ blsp2_spi0: spi@7af5000 { > > status = "disabled"; > > }; > > > > + imem@8600000 { > > + compatible = "syscon", "simple-mfd"; > > + reg = <0x08600000 0x1000>; > > + > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + pil-reloc@94c { > > + compatible ="qcom,pil-reloc-info"; > > + reg = <0x94c 200>; > > Is it 200 in decimal? It looks weird that this is basically the only > thing that isn't in hexadecimal. > Yes it is and the size was documented as such... But you're probably not the last one who will spend cycles wondering if I forgot the 0x. Regards, Bjorn > > + }; > > + }; > > +
On Mon, Feb 10, 2020 at 04:50:55PM -0800, Bjorn Andersson wrote: > Add a simple-mfd representing IMEM on QCS404 and define the PIL > relocation info region, so that post mortem tools will be able to locate > the loaded remoteprocs. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > > Changes since v2: > - Replace offset with reg > > arch/arm64/boot/dts/qcom/qcs404.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi > index 4ee1e3d5f123..f539293b875c 100644 > --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi > @@ -997,6 +997,19 @@ blsp2_spi0: spi@7af5000 { > status = "disabled"; > }; > > + imem@8600000 { > + compatible = "syscon", "simple-mfd"; > + reg = <0x08600000 0x1000>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + > + pil-reloc@94c { > + compatible ="qcom,pil-reloc-info"; s/="/= " > + reg = <0x94c 200>; > + }; > + }; > + > intc: interrupt-controller@b000000 { > compatible = "qcom,msm-qgic2"; > interrupt-controller; > -- > 2.24.0 >
diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi index 4ee1e3d5f123..f539293b875c 100644 --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi @@ -997,6 +997,19 @@ blsp2_spi0: spi@7af5000 { status = "disabled"; }; + imem@8600000 { + compatible = "syscon", "simple-mfd"; + reg = <0x08600000 0x1000>; + + #address-cells = <1>; + #size-cells = <1>; + + pil-reloc@94c { + compatible ="qcom,pil-reloc-info"; + reg = <0x94c 200>; + }; + }; + intc: interrupt-controller@b000000 { compatible = "qcom,msm-qgic2"; interrupt-controller;
Add a simple-mfd representing IMEM on QCS404 and define the PIL relocation info region, so that post mortem tools will be able to locate the loaded remoteprocs. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- Changes since v2: - Replace offset with reg arch/arm64/boot/dts/qcom/qcs404.dtsi | 13 +++++++++++++ 1 file changed, 13 insertions(+)