diff mbox series

[5/6] ARM: dts: qcom: msm8974-klte: Remove inherited vreg_boost node

Message ID 20200410023203.192048-6-iskren.chernev@gmail.com (mailing list archive)
State Superseded
Headers show
Series ARM: dts: qcom: klte: Add support for hw keys, flash and usb | expand

Commit Message

Iskren Chernev April 10, 2020, 2:32 a.m. UTC 
From: Daniele Debernardi <drebrez@gmail.com>

The Samsung klte does not have a vreg_boost node. vreg_boost also
depends on pm8941-gpio which are not present on the klte.

Signed-off-by: Daniele Debernardi <drebrez@gmail.com>
Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
---
 arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Bjorn Andersson April 11, 2020, 1:38 a.m. UTC | #1 
On Thu 09 Apr 19:32 PDT 2020, Iskren Chernev wrote:

> From: Daniele Debernardi <drebrez@gmail.com>
> 
> The Samsung klte does not have a vreg_boost node. vreg_boost also
> depends on pm8941-gpio which are not present on the klte.
> 

May I ask what PMICs this device actually has, if it doesn't have a
PM8941 GPIO?

Regards,
Bjorn

> Signed-off-by: Daniele Debernardi <drebrez@gmail.com>
> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
> ---
>  arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts
> index de0bf6b7e732..ad26c83fee81 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts
> @@ -1,7 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0
>  #include "qcom-msm8974pro.dtsi"
> -#include "qcom-pm8841.dtsi"
> -#include "qcom-pm8941.dtsi"
>  #include "qcom-pma8084.dtsi"
>  #include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/input/input.h>
> @@ -196,6 +194,8 @@ l27 {
>  			};
>  		};
>  	};
> +
> +	/delete-node/ vreg-boost;
>  };
>  
>  &soc {
> -- 
> 2.26.0
>
Iskren Chernev April 11, 2020, 5:21 p.m. UTC | #2 
On 4/11/20 4:38 AM, Bjorn Andersson wrote:
> May I ask what PMICs this device actually has, if it doesn't have a
> PM8941 GPIO?

In terms of power, the device has PMA8084, MAX77826 (pure PMIC for
touchpad, camera, other peripherals), MAX77804k (MFD with fuel gauge,
charger, a few regulators + other). I'm sending a MAX77826 patch
shortly :)

In terms of GPIO controllers, PMA8084 has some pins, and the SoC
itself (qcom,msm8974-pinctrl) has gpio pins.

According to ./drivers/platform/msm/qpnp-revid.c from downstream,
these devices are covered by similar drivers: "PM8941", "PM8841",
"PM8019", "PM8226", "PM8110", "PMA8084", "PMI8962", "PMD9635", and my
KLTE prints the PMA8084, after querying the hardware.

I still don't have the full picture yet, but I'm pretty confident
there is no PM8941/PM8841 on the klte.

Regards,
Iskren
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts
index de0bf6b7e732..ad26c83fee81 100644
--- a/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts
+++ b/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts
@@ -1,7 +1,5 @@ 
 // SPDX-License-Identifier: GPL-2.0
 #include "qcom-msm8974pro.dtsi"
-#include "qcom-pm8841.dtsi"
-#include "qcom-pm8941.dtsi"
 #include "qcom-pma8084.dtsi"
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
@@ -196,6 +194,8 @@  l27 {
 			};
 		};
 	};
+
+	/delete-node/ vreg-boost;
 };
 
 &soc {