| Message ID | 20200523175232.13721-1-jonathan@marek.ca (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6b9afd8f96c6eba561dabbe4e15052b9ceb6878a |
| Headers | show |
| Series | arm64: dts: qcom: sm8250: change ufs node name to ufshc | expand |
On Sat 23 May 10:52 PDT 2020, Jonathan Marek wrote: > The ufs-qcom driver checks that the name matches the androidboot.bootdevice > parameter provided by the bootloader, which uses the name ufshc. Without > this change UFS fails to probe. > Seems I only tested with UFS built as module, thanks for spotting this. > I think this is broken behavior from the ufs-qcom driver, but using the > name ufshc is consistent with dts for sdm845/sm8150/etc. > I agree. Patch applied... Thanks, Bjorn > Signed-off-by: Jonathan Marek <jonathan@marek.ca> > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index e0344d3ba159..3bdce658c08a 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -309,7 +309,7 @@ uart2: serial@a90000 { > }; > }; > > - ufs_mem_hc: ufs@1d84000 { > + ufs_mem_hc: ufshc@1d84000 { > compatible = "qcom,sm8250-ufshc", "qcom,ufshc", > "jedec,ufs-2.0"; > reg = <0 0x01d84000 0 0x3000>; > -- > 2.26.1 >
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index e0344d3ba159..3bdce658c08a 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -309,7 +309,7 @@ uart2: serial@a90000 { }; }; - ufs_mem_hc: ufs@1d84000 { + ufs_mem_hc: ufshc@1d84000 { compatible = "qcom,sm8250-ufshc", "qcom,ufshc", "jedec,ufs-2.0"; reg = <0 0x01d84000 0 0x3000>;
The ufs-qcom driver checks that the name matches the androidboot.bootdevice parameter provided by the bootloader, which uses the name ufshc. Without this change UFS fails to probe. I think this is broken behavior from the ufs-qcom driver, but using the name ufshc is consistent with dts for sdm845/sm8150/etc. Signed-off-by: Jonathan Marek <jonathan@marek.ca> --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)