| Message ID | 20200729074415.28393-1-krzk@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] soc: mediatek: mtk-infracfg: Fix kerneldoc | expand |
On 29/07/2020 09:44, Krzysztof Kozlowski wrote: > Fix W=1 compile warnings (invalid kerneldoc): > > drivers/soc/mediatek/mtk-infracfg.c:34: warning: Function parameter or member 'infracfg' not described in 'mtk_infracfg_set_bus_protection' > drivers/soc/mediatek/mtk-infracfg.c:34: warning: Excess function parameter 'regmap' description in 'mtk_infracfg_set_bus_protection' > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Queued for v5.9-next/soc Thanks Matthias > --- > drivers/soc/mediatek/mtk-infracfg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-infracfg.c b/drivers/soc/mediatek/mtk-infracfg.c > index 341c7ac250e3..4a123796aad3 100644 > --- a/drivers/soc/mediatek/mtk-infracfg.c > +++ b/drivers/soc/mediatek/mtk-infracfg.c > @@ -19,7 +19,7 @@ > > /** > * mtk_infracfg_set_bus_protection - enable bus protection > - * @regmap: The infracfg regmap > + * @infracfg: The infracfg regmap > * @mask: The mask containing the protection bits to be enabled. > * @reg_update: The boolean flag determines to set the protection bits > * by regmap_update_bits with enable register(PROTECTEN) or > @@ -50,7 +50,7 @@ int mtk_infracfg_set_bus_protection(struct regmap *infracfg, u32 mask, > > /** > * mtk_infracfg_clear_bus_protection - disable bus protection > - * @regmap: The infracfg regmap > + * @infracfg: The infracfg regmap > * @mask: The mask containing the protection bits to be disabled. > * @reg_update: The boolean flag determines to clear the protection bits > * by regmap_update_bits with enable register(PROTECTEN) or >
On Wed, Jul 29, 2020 at 09:53:59AM +0200, Matthias Brugger wrote: > > > On 29/07/2020 09:44, Krzysztof Kozlowski wrote: > > Fix W=1 compile warnings (invalid kerneldoc): > > > > drivers/soc/mediatek/mtk-infracfg.c:34: warning: Function parameter or member 'infracfg' not described in 'mtk_infracfg_set_bus_protection' > > drivers/soc/mediatek/mtk-infracfg.c:34: warning: Excess function parameter 'regmap' description in 'mtk_infracfg_set_bus_protection' > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > Queued for v5.9-next/soc Hi, It looks like this missed the merge window. Do you plan to keep it for v5.10? Best regards, Krzysztof
On 19/08/2020 19:48, Krzysztof Kozlowski wrote: > On Wed, Jul 29, 2020 at 09:53:59AM +0200, Matthias Brugger wrote: >> >> >> On 29/07/2020 09:44, Krzysztof Kozlowski wrote: >>> Fix W=1 compile warnings (invalid kerneldoc): >>> >>> drivers/soc/mediatek/mtk-infracfg.c:34: warning: Function parameter or member 'infracfg' not described in 'mtk_infracfg_set_bus_protection' >>> drivers/soc/mediatek/mtk-infracfg.c:34: warning: Excess function parameter 'regmap' description in 'mtk_infracfg_set_bus_protection' >>> >>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> >> >> Queued for v5.9-next/soc > > Hi, > > It looks like this missed the merge window. Do you plan to keep it for > v5.10? > Yes. I'm using the confusing way of v5.9-next branch, which means v5.10, as long as Linus does not decide to switch to v6.x Anyway it's queued for v5.10 Regards, Matthias
diff --git a/drivers/soc/mediatek/mtk-infracfg.c b/drivers/soc/mediatek/mtk-infracfg.c index 341c7ac250e3..4a123796aad3 100644 --- a/drivers/soc/mediatek/mtk-infracfg.c +++ b/drivers/soc/mediatek/mtk-infracfg.c @@ -19,7 +19,7 @@ /** * mtk_infracfg_set_bus_protection - enable bus protection - * @regmap: The infracfg regmap + * @infracfg: The infracfg regmap * @mask: The mask containing the protection bits to be enabled. * @reg_update: The boolean flag determines to set the protection bits * by regmap_update_bits with enable register(PROTECTEN) or @@ -50,7 +50,7 @@ int mtk_infracfg_set_bus_protection(struct regmap *infracfg, u32 mask, /** * mtk_infracfg_clear_bus_protection - disable bus protection - * @regmap: The infracfg regmap + * @infracfg: The infracfg regmap * @mask: The mask containing the protection bits to be disabled. * @reg_update: The boolean flag determines to clear the protection bits * by regmap_update_bits with enable register(PROTECTEN) or
Fix W=1 compile warnings (invalid kerneldoc): drivers/soc/mediatek/mtk-infracfg.c:34: warning: Function parameter or member 'infracfg' not described in 'mtk_infracfg_set_bus_protection' drivers/soc/mediatek/mtk-infracfg.c:34: warning: Excess function parameter 'regmap' description in 'mtk_infracfg_set_bus_protection' Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/soc/mediatek/mtk-infracfg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)