| Message ID | 20200827084102.1.I7a5f56b411071eeecae84b7e33981d39170ccf2a@changeid (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: sdhci-msm: We need to restore_dll_config for sc7180 | expand |
Hi, On Thu, Aug 27, 2020 at 8:41 AM Douglas Anderson <dianders@chromium.org> wrote: > > Although sc7180 is supposed to have a hardware fix that means that we > don't have to restore the DLL config like we did with sdm845, > apparently the hardware fix doesn't work in all cases. Until it's > understood under exactly which cases we the hardware fix malfunctions, > let's go back to restoring the DLL config whenever we do runtime > resume. This is safe and gets things working again. > > NOTE: we don't need to introduce a whole new "struct > sdhci_msm_variant_info" for sc7180 since it would be exactly the same > as the sdm845 one. We'll just refer to that one. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > drivers/mmc/host/sdhci-msm.c | 1 + > 1 file changed, 1 insertion(+) Sorry for the spam. I was too busy debugging and preparing my other patches and didn't realize that Veerabhadrarao was sending at the exact same time. Let's take that one, AKA: https://lore.kernel.org/r/1598541694-15694-1-git-send-email-vbadigan@codeaurora.org -Doug
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index b7e47107a31a..a88db3f376bd 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -2148,6 +2148,7 @@ static const struct sdhci_msm_variant_info sm8250_sdhci_var = { static const struct of_device_id sdhci_msm_dt_match[] = { {.compatible = "qcom,sdhci-msm-v4", .data = &sdhci_msm_mci_var}, {.compatible = "qcom,sdhci-msm-v5", .data = &sdhci_msm_v5_var}, + {.compatible = "qcom,sc7180-sdhci", .data = &sdm845_sdhci_var}, {.compatible = "qcom,sdm845-sdhci", .data = &sdm845_sdhci_var}, {.compatible = "qcom,sm8250-sdhci", .data = &sm8250_sdhci_var}, {},
Although sc7180 is supposed to have a hardware fix that means that we don't have to restore the DLL config like we did with sdm845, apparently the hardware fix doesn't work in all cases. Until it's understood under exactly which cases we the hardware fix malfunctions, let's go back to restoring the DLL config whenever we do runtime resume. This is safe and gets things working again. NOTE: we don't need to introduce a whole new "struct sdhci_msm_variant_info" for sc7180 since it would be exactly the same as the sdm845 one. We'll just refer to that one. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- drivers/mmc/host/sdhci-msm.c | 1 + 1 file changed, 1 insertion(+)