diff mbox series

[18/18] bus: mhi: core: Fix the building of MHI module

Message ID 20200921160815.28071-20-manivannan.sadhasivam@linaro.org (mailing list archive)
State Superseded
Headers show
Series MHI changes for v5.10 | expand

Commit Message

Manivannan Sadhasivam Sept. 21, 2020, 4:08 p.m. UTC
The Kbuild rule to build MHI should use the append operator. This fixes
the below warning reported by Kbuild test bot.

WARNING: modpost: missing MODULE_LICENSE() in
drivers/bus/mhi/core/main.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/bus/mhi/core/pm.o
WARNING: modpost: missing MODULE_LICENSE() in
drivers/bus/mhi/core/boot.o

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/bus/mhi/core/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg Kroah-Hartman Sept. 27, 2020, 10:22 a.m. UTC | #1
On Mon, Sep 21, 2020 at 09:38:15PM +0530, Manivannan Sadhasivam wrote:
> The Kbuild rule to build MHI should use the append operator. This fixes
> the below warning reported by Kbuild test bot.
> 
> WARNING: modpost: missing MODULE_LICENSE() in
> drivers/bus/mhi/core/main.o
> WARNING: modpost: missing MODULE_LICENSE() in drivers/bus/mhi/core/pm.o
> WARNING: modpost: missing MODULE_LICENSE() in
> drivers/bus/mhi/core/boot.o
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

What commit caused this problem?  Can you add a Fixes: line for it?

thanks,

greg k-h
Manivannan Sadhasivam Sept. 28, 2020, 3:45 a.m. UTC | #2
On Sun, Sep 27, 2020 at 12:22:33PM +0200, Greg KH wrote:
> On Mon, Sep 21, 2020 at 09:38:15PM +0530, Manivannan Sadhasivam wrote:
> > The Kbuild rule to build MHI should use the append operator. This fixes
> > the below warning reported by Kbuild test bot.
> > 
> > WARNING: modpost: missing MODULE_LICENSE() in
> > drivers/bus/mhi/core/main.o
> > WARNING: modpost: missing MODULE_LICENSE() in drivers/bus/mhi/core/pm.o
> > WARNING: modpost: missing MODULE_LICENSE() in
> > drivers/bus/mhi/core/boot.o
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> 
> What commit caused this problem?  Can you add a Fixes: line for it?
> 

Sure, will add the fixes tag!

Thanks,
Mani

> thanks,
> 
> greg k-h
diff mbox series

Patch

diff --git a/drivers/bus/mhi/core/Makefile b/drivers/bus/mhi/core/Makefile
index 12c57ab3724c..c3feb4130aa3 100644
--- a/drivers/bus/mhi/core/Makefile
+++ b/drivers/bus/mhi/core/Makefile
@@ -1,4 +1,4 @@ 
-obj-$(CONFIG_MHI_BUS) := mhi.o
+obj-$(CONFIG_MHI_BUS) += mhi.o
 
 mhi-y := init.o main.o pm.o boot.o
 mhi-$(CONFIG_MHI_BUS_DEBUG) += debugfs.o