| Message ID | 20210225103330.v2.3.Ife7768b6b4765026c9d233ad4982da0e365ddbca@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6748450a6bcbd1b3916588602d5fdd5a58174baa |
| Headers | show |
| Series | [v2,1/4] arm64: dts: qcom: sc7180: trogdor: Add label to charger thermal zone | expand |
Quoting Matthias Kaehlcke (2021-02-25 10:33:36) > The trip point configuration of the charger thermal zone for trogdor > is missing a node for the critical trip point. Add the missing node. > > Fixes: bb06eb3607e9 ("arm64: qcom: sc7180: trogdor: Add ADC nodes and thermal zone for charger thermistor") > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Hi, On Thu, Feb 25, 2021 at 10:33 AM Matthias Kaehlcke <mka@chromium.org> wrote: > > The trip point configuration of the charger thermal zone for trogdor > is missing a node for the critical trip point. Add the missing node. > > Fixes: bb06eb3607e9 ("arm64: qcom: sc7180: trogdor: Add ADC nodes and thermal zone for charger thermistor") > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > > Changes in v2: > - patch added to the series > > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index bda983da4eaf..ab4efaece5cb 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -22,9 +22,11 @@ charger_thermal: charger-thermal { > thermal-sensors = <&pm6150_adc_tm 1>; > > trips { > - temperature = <125000>; > - hysteresis = <1000>; > - type = "critical"; > + charger-crit { If you happen to spin for some other reason, it might not hurt to add a label to this node. Best case it'll save a patch in the future when some OEM decides that they need to adjust this temperature and worst case it doesn't hurt. In any case: Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index bda983da4eaf..ab4efaece5cb 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -22,9 +22,11 @@ charger_thermal: charger-thermal { thermal-sensors = <&pm6150_adc_tm 1>; trips { - temperature = <125000>; - hysteresis = <1000>; - type = "critical"; + charger-crit { + temperature = <125000>; + hysteresis = <1000>; + type = "critical"; + }; }; }; };
The trip point configuration of the charger thermal zone for trogdor is missing a node for the critical trip point. Add the missing node. Fixes: bb06eb3607e9 ("arm64: qcom: sc7180: trogdor: Add ADC nodes and thermal zone for charger thermistor") Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- Changes in v2: - patch added to the series arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)