| Message ID | 20210406163330.11996-1-srivasam@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 367a8230fc88642be685fed4a63eeed352019a6d |
| Headers | show |
| Series | [v2] arm64: dts: qcom: Update iommu property for simultaneous playback | expand |
Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30) > From: V Sujith Kumar Reddy <vsujithk@codeaurora.org> > > Update iommu property in lpass cpu node for supporting > simultaneous playback on headset and speaker. > > Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org> > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > --- > Changes since v1: > -- Commit messge header change > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index a6da78d31fdd..6228ba2d8513 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -3566,7 +3566,8 @@ lpass_cpu: lpass@62f00000 { > reg = <0 0x62f00000 0 0x29000>; > reg-names = "lpass-lpaif"; > > - iommus = <&apps_smmu 0x1020 0>; > + iommus = <&apps_smmu 0x1020 0>, > + <&apps_smmu 0x1021 0>; The stream ID 0x1032 was also dropped in this version but there's no mention of that in the changelog. Why? > > power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>; >
Hi Stephen. Thanks for your time!!! On 4/9/2021 10:31 PM, Stephen Boyd wrote: > Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30) >> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org> >> >> Update iommu property in lpass cpu node for supporting >> simultaneous playback on headset and speaker. >> >> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org> >> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> >> --- >> Changes since v1: >> -- Commit messge header change >> >> arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> index a6da78d31fdd..6228ba2d8513 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> @@ -3566,7 +3566,8 @@ lpass_cpu: lpass@62f00000 { >> reg = <0 0x62f00000 0 0x29000>; >> reg-names = "lpass-lpaif"; >> >> - iommus = <&apps_smmu 0x1020 0>; >> + iommus = <&apps_smmu 0x1020 0>, >> + <&apps_smmu 0x1021 0>; > The stream ID 0x1032 was also dropped in this version but there's no > mention of that in the changelog. Why? That is ID is for HDMI Stream, so as part of DP patches that will be added. > >> >> power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>; >>
Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30) > From: V Sujith Kumar Reddy <vsujithk@codeaurora.org> > > Update iommu property in lpass cpu node for supporting > simultaneous playback on headset and speaker. > > Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org> > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Quoting Srinivasa Rao Mandadapu (2021-04-09 22:17:07) > Hi Stephen. > > Thanks for your time!!! > > > On 4/9/2021 10:31 PM, Stephen Boyd wrote: > > Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30) > >> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org> > >> > >> Update iommu property in lpass cpu node for supporting > >> simultaneous playback on headset and speaker. > >> > >> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org> > >> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > >> --- > >> Changes since v1: > >> -- Commit messge header change > >> > >> arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > >> index a6da78d31fdd..6228ba2d8513 100644 > >> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > >> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > >> @@ -3566,7 +3566,8 @@ lpass_cpu: lpass@62f00000 { > >> reg = <0 0x62f00000 0 0x29000>; > >> reg-names = "lpass-lpaif"; > >> > >> - iommus = <&apps_smmu 0x1020 0>; > >> + iommus = <&apps_smmu 0x1020 0>, > >> + <&apps_smmu 0x1021 0>; > > The stream ID 0x1032 was also dropped in this version but there's no > > mention of that in the changelog. Why? > That is ID is for HDMI Stream, so as part of DP patches that will be added. Ok, got it.
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Tue, 6 Apr 2021 22:03:30 +0530 you wrote: > From: V Sujith Kumar Reddy <vsujithk@codeaurora.org> > > Update iommu property in lpass cpu node for supporting > simultaneous playback on headset and speaker. > > Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org> > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > > [...] Here is the summary with links: - [v2] arm64: dts: qcom: Update iommu property for simultaneous playback https://git.kernel.org/qcom/c/367a8230fc88 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index a6da78d31fdd..6228ba2d8513 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -3566,7 +3566,8 @@ lpass_cpu: lpass@62f00000 { reg = <0 0x62f00000 0 0x29000>; reg-names = "lpass-lpaif"; - iommus = <&apps_smmu 0x1020 0>; + iommus = <&apps_smmu 0x1020 0>, + <&apps_smmu 0x1021 0>; power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;