diff mbox series

[v3,1/1] nexus: Fix gpio-reserved-ranges 85-88

Message ID 20210415173957.28533-1-petr.vorel@gmail.com (mailing list archive)
State Superseded
Headers show
Series [v3,1/1] nexus: Fix gpio-reserved-ranges 85-88 | expand

Commit Message

Petr Vorel April 15, 2021, 5:39 p.m. UTC
Reserve GPIO pins 85-88 as these aren't meant to be accessible from the
application CPUs (causes reboot). Yet another fix similar to
9134586715e3, 5f8d3ab136d0, which is needed to allow angler to boot after
3edfb7bd76bd ("gpiolib: Show correct direction from the beginning").

Fixes: feeaf56ac78d ("arm64: dts: msm8994 SoC and Huawei Angler (Nexus 6P) support")

Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
Hi,

NOTE: as I wrote there is also problem with 86588296acbf ("fdt: Properly
handle "no-map" field in the memory region") from v5.12-rc1-dontuse, but
that's another story.

Kind regards,
Petr

 arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Konrad Dybcio April 15, 2021, 6:47 p.m. UTC | #1
Hi,

the patch title should be:

arm64: dts: qcom: angler: <blurb>

or

arm64: dts: qcom: msm8994-angler:

But that's a nit, that could probably be fixed when applying. Otherwise, if the device now works:

Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>


Konrad
Petr Vorel April 15, 2021, 7:36 p.m. UTC | #2
Hi Konrad,

> Hi,

> the patch title should be:

> arm64: dts: qcom: angler: <blurb>

> or

> arm64: dts: qcom: msm8994-angler:
I'm sorry for this error, I'll send v4. Thanks for spotting this.

> But that's a nit, that could probably be fixed when applying. Otherwise, if the device now works:

> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Well, as I wrote, it works till 86588296acbf (from v5.12-rc1-dontuse), which
will take me some time to figure out why. But this commit is valid, thus I dare
to add your Reviewed-by in that v4.

Kind regards,
Petr


> Konrad
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
index baa55643b40f..ffe1a9bd8f70 100644
--- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
+++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
@@ -32,3 +32,7 @@  serial@f991e000 {
 		};
 	};
 };
+
+&tlmm {
+	gpio-reserved-ranges = <85 4>;
+};