| Message ID | 20210926075951.28034-1-shawn.guo@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: qcom: Drop vdd-supply from qusb2-phy devices | expand |
On Sun, 26 Sept 2021 at 13:29, Shawn Guo <shawn.guo@linaro.org> wrote: > > Looking at qcom,qusb2-phy.yaml bindings and qusb2_phy_vreg_names[] in > qusb2-phy driver, vdd-supply is not a supported/valid property. Drop it > from qusb2-phy devices on various boards. > No obvious regression on PocoF1 (Beryllium). Tested-by: Amit Pundir <amit.pundir@linaro.org> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > --- > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 1 - > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 - > arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi | 1 - > arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 -- > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 -- > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 2 -- > arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 1 - > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 1 - > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 2 -- > 9 files changed, 13 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > index acdb36f4479f..5ec47eaa4a90 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > @@ -429,7 +429,6 @@ > > &usb_1_hsphy { > status = "okay"; > - vdd-supply = <&vreg_l4a_0p8>; > vdda-pll-supply = <&vreg_l11a_1p8>; > vdda-phy-dpdm-supply = <&vreg_l17a_3p0>; > qcom,imp-res-offset-value = <8>; > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index 0f2b3c00e434..ed68f1233d66 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -928,7 +928,6 @@ ap_spi_fp: &spi10 { > > &usb_1_hsphy { > status = "okay"; > - vdd-supply = <&vdd_qusb_hs0_core>; > vdda-pll-supply = <&vdda_qusb_hs0_1p8>; > vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; > qcom,imp-res-offset-value = <8>; > diff --git a/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi b/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi > index 11d0a8c1cf35..b05d5433a674 100644 > --- a/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi > @@ -228,7 +228,6 @@ > &qusb2phy { > status = "okay"; > > - vdd-supply = <&vreg_l1b_0p925>; > vdda-pll-supply = <&vreg_l10a_1p8>; > vdda-phy-dpdm-supply = <&vreg_l7b_3p125>; > }; > diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi > index dfd1b42c07fd..12fa059bef5a 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi > @@ -807,7 +807,6 @@ ap_ts_i2c: &i2c14 { > &usb_1_hsphy { > status = "okay"; > > - vdd-supply = <&vdda_usb1_ss_core>; > vdda-pll-supply = <&vdda_qusb_hs0_1p8>; > vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; > > @@ -829,7 +828,6 @@ ap_ts_i2c: &i2c14 { > &usb_2_hsphy { > status = "okay"; > > - vdd-supply = <&vdda_usb2_ss_core>; > vdda-pll-supply = <&vdda_qusb_hs0_1p8>; > vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index 2d5533dd4ec2..894be3b6aea5 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -940,7 +940,6 @@ > &usb_1_hsphy { > status = "okay"; > > - vdd-supply = <&vreg_l1a_0p875>; > vdda-pll-supply = <&vreg_l12a_1p8>; > vdda-phy-dpdm-supply = <&vreg_l24a_3p075>; > > @@ -968,7 +967,6 @@ > &usb_2_hsphy { > status = "okay"; > > - vdd-supply = <&vreg_l1a_0p875>; > vdda-pll-supply = <&vreg_l12a_1p8>; > vdda-phy-dpdm-supply = <&vreg_l24a_3p075>; > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > index 52dd7a858231..08485eb5963a 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > @@ -517,7 +517,6 @@ > &usb_1_hsphy { > status = "okay"; > > - vdd-supply = <&vdda_usb1_ss_core>; > vdda-pll-supply = <&vdda_qusb_hs0_1p8>; > vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; > > @@ -551,7 +550,6 @@ > &usb_2_hsphy { > status = "okay"; > > - vdd-supply = <&vdda_usb2_ss_core>; > vdda-pll-supply = <&vdda_qusb_hs0_1p8>; > vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi > index d4355522374a..911105d7603d 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi > @@ -580,7 +580,6 @@ > &usb_1_hsphy { > status = "okay"; > > - vdd-supply = <&vdda_usb1_ss_core>; > vdda-pll-supply = <&vdda_qusb_hs0_1p8>; > vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts > index c60c8c640e17..9dc173c1f0be 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts > @@ -496,7 +496,6 @@ > &usb_1_hsphy { > status = "okay"; > > - vdd-supply = <&vreg_l1a_0p875>; > vdda-pll-supply = <&vreg_l12a_1p8>; > vdda-phy-dpdm-supply = <&vreg_l24a_3p075>; > > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > index 385e5029437d..e330721cd6cd 100644 > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > @@ -646,7 +646,6 @@ > &usb_1_hsphy { > status = "okay"; > > - vdd-supply = <&vdda_usb1_ss_core>; > vdda-pll-supply = <&vdda_qusb_hs0_1p8>; > vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; > > @@ -674,7 +673,6 @@ > &usb_2_hsphy { > status = "okay"; > > - vdd-supply = <&vdda_usb2_ss_core>; > vdda-pll-supply = <&vdda_qusb_hs0_1p8>; > vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; > > -- > 2.17.1 >
On 26.09.2021 09:59, Shawn Guo wrote: > Looking at qcom,qusb2-phy.yaml bindings and qusb2_phy_vreg_names[] in > qusb2-phy driver, vdd-supply is not a supported/valid property. Drop it > from qusb2-phy devices on various boards. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> Why not add it to the regulators list instead? It's a valid regulator for this hw. Konrad
On Mon, Sep 27, 2021 at 12:58:19AM +0200, Konrad Dybcio wrote: > > On 26.09.2021 09:59, Shawn Guo wrote: > > Looking at qcom,qusb2-phy.yaml bindings and qusb2_phy_vreg_names[] in > > qusb2-phy driver, vdd-supply is not a supported/valid property. Drop it > > from qusb2-phy devices on various boards. > > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > Why not add it to the regulators list instead? It's a valid regulator for this hw. I do not have enough information to be sure. Could you cook up a patch to update bindings and driver, if you think that's the case? I will be happy as long as that DTS, bindings and driver are on the same page. Shawn
On Mon, Sep 27, 2021 at 08:07:16AM +0800, Shawn Guo wrote: > On Mon, Sep 27, 2021 at 12:58:19AM +0200, Konrad Dybcio wrote: > > > > On 26.09.2021 09:59, Shawn Guo wrote: > > > Looking at qcom,qusb2-phy.yaml bindings and qusb2_phy_vreg_names[] in > > > qusb2-phy driver, vdd-supply is not a supported/valid property. Drop it > > > from qusb2-phy devices on various boards. > > > > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > > > Why not add it to the regulators list instead? It's a valid regulator for this hw. > > I do not have enough information to be sure. Could you cook up a patch to > update bindings and driver, if you think that's the case? I will be > happy as long as that DTS, bindings and driver are on the same page. Aha, I checked downstream kernel and vdd is indeed a valid supply for qusb2_phy. Please disregard this patch, and I will update bindings and driver instead. Thanks, Konrad! Shawn
diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts index acdb36f4479f..5ec47eaa4a90 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts @@ -429,7 +429,6 @@ &usb_1_hsphy { status = "okay"; - vdd-supply = <&vreg_l4a_0p8>; vdda-pll-supply = <&vreg_l11a_1p8>; vdda-phy-dpdm-supply = <&vreg_l17a_3p0>; qcom,imp-res-offset-value = <8>; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index 0f2b3c00e434..ed68f1233d66 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -928,7 +928,6 @@ ap_spi_fp: &spi10 { &usb_1_hsphy { status = "okay"; - vdd-supply = <&vdd_qusb_hs0_core>; vdda-pll-supply = <&vdda_qusb_hs0_1p8>; vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; qcom,imp-res-offset-value = <8>; diff --git a/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi b/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi index 11d0a8c1cf35..b05d5433a674 100644 --- a/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi @@ -228,7 +228,6 @@ &qusb2phy { status = "okay"; - vdd-supply = <&vreg_l1b_0p925>; vdda-pll-supply = <&vreg_l10a_1p8>; vdda-phy-dpdm-supply = <&vreg_l7b_3p125>; }; diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi index dfd1b42c07fd..12fa059bef5a 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi @@ -807,7 +807,6 @@ ap_ts_i2c: &i2c14 { &usb_1_hsphy { status = "okay"; - vdd-supply = <&vdda_usb1_ss_core>; vdda-pll-supply = <&vdda_qusb_hs0_1p8>; vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; @@ -829,7 +828,6 @@ ap_ts_i2c: &i2c14 { &usb_2_hsphy { status = "okay"; - vdd-supply = <&vdda_usb2_ss_core>; vdda-pll-supply = <&vdda_qusb_hs0_1p8>; vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts index 2d5533dd4ec2..894be3b6aea5 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts @@ -940,7 +940,6 @@ &usb_1_hsphy { status = "okay"; - vdd-supply = <&vreg_l1a_0p875>; vdda-pll-supply = <&vreg_l12a_1p8>; vdda-phy-dpdm-supply = <&vreg_l24a_3p075>; @@ -968,7 +967,6 @@ &usb_2_hsphy { status = "okay"; - vdd-supply = <&vreg_l1a_0p875>; vdda-pll-supply = <&vreg_l12a_1p8>; vdda-phy-dpdm-supply = <&vreg_l24a_3p075>; diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts index 52dd7a858231..08485eb5963a 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts @@ -517,7 +517,6 @@ &usb_1_hsphy { status = "okay"; - vdd-supply = <&vdda_usb1_ss_core>; vdda-pll-supply = <&vdda_qusb_hs0_1p8>; vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; @@ -551,7 +550,6 @@ &usb_2_hsphy { status = "okay"; - vdd-supply = <&vdda_usb2_ss_core>; vdda-pll-supply = <&vdda_qusb_hs0_1p8>; vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi index d4355522374a..911105d7603d 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi @@ -580,7 +580,6 @@ &usb_1_hsphy { status = "okay"; - vdd-supply = <&vdda_usb1_ss_core>; vdda-pll-supply = <&vdda_qusb_hs0_1p8>; vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts index c60c8c640e17..9dc173c1f0be 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts @@ -496,7 +496,6 @@ &usb_1_hsphy { status = "okay"; - vdd-supply = <&vreg_l1a_0p875>; vdda-pll-supply = <&vreg_l12a_1p8>; vdda-phy-dpdm-supply = <&vreg_l24a_3p075>; diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts index 385e5029437d..e330721cd6cd 100644 --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts @@ -646,7 +646,6 @@ &usb_1_hsphy { status = "okay"; - vdd-supply = <&vdda_usb1_ss_core>; vdda-pll-supply = <&vdda_qusb_hs0_1p8>; vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>; @@ -674,7 +673,6 @@ &usb_2_hsphy { status = "okay"; - vdd-supply = <&vdda_usb2_ss_core>; vdda-pll-supply = <&vdda_qusb_hs0_1p8>; vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>;
Looking at qcom,qusb2-phy.yaml bindings and qusb2_phy_vreg_names[] in qusb2-phy driver, vdd-supply is not a supported/valid property. Drop it from qusb2-phy devices on various boards. Signed-off-by: Shawn Guo <shawn.guo@linaro.org> --- arch/arm64/boot/dts/qcom/sc7180-idp.dts | 1 - arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 - arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi | 1 - arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 -- arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 -- arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 2 -- arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 1 - arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 1 - arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 2 -- 9 files changed, 13 deletions(-)