| Message ID | 20211001151145.55916-10-sean@poorly.run (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | None | expand |
On 01/10/2021 18:11, Sean Paul wrote: > From: Sean Paul <seanpaul@chromium.org> > > A couple more useless checks to remove in dpu_encoder. > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Signed-off-by: Sean Paul <seanpaul@chromium.org> > Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-10-sean@poorly.run #v1 > Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-10-sean@poorly.run #v2 Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Changes in v2: > -None > Changes in v3: > -None > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > index 0e9d3fa1544b..984f8a59cb73 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > @@ -1153,10 +1153,6 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc) > struct msm_drm_private *priv; > struct drm_display_mode *cur_mode = NULL; > > - if (!drm_enc) { > - DPU_ERROR("invalid encoder\n"); > - return; > - } > dpu_enc = to_dpu_encoder_virt(drm_enc); > > mutex_lock(&dpu_enc->enc_lock); > @@ -1203,14 +1199,6 @@ static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc) > struct msm_drm_private *priv; > int i = 0; > > - if (!drm_enc) { > - DPU_ERROR("invalid encoder\n"); > - return; > - } else if (!drm_enc->dev) { > - DPU_ERROR("invalid dev\n"); > - return; > - } > - > dpu_enc = to_dpu_encoder_virt(drm_enc); > DPU_DEBUG_ENC(dpu_enc, "\n"); > >
On 2021-10-01 08:11, Sean Paul wrote: > From: Sean Paul <seanpaul@chromium.org> > > A couple more useless checks to remove in dpu_encoder. > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Signed-off-by: Sean Paul <seanpaul@chromium.org> Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org> > Link: > https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-10-sean@poorly.run > #v1 > Link: > https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-10-sean@poorly.run > #v2 > > Changes in v2: > -None > Changes in v3: > -None > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > index 0e9d3fa1544b..984f8a59cb73 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > @@ -1153,10 +1153,6 @@ static void dpu_encoder_virt_enable(struct > drm_encoder *drm_enc) > struct msm_drm_private *priv; > struct drm_display_mode *cur_mode = NULL; > > - if (!drm_enc) { > - DPU_ERROR("invalid encoder\n"); > - return; > - } > dpu_enc = to_dpu_encoder_virt(drm_enc); > > mutex_lock(&dpu_enc->enc_lock); > @@ -1203,14 +1199,6 @@ static void dpu_encoder_virt_disable(struct > drm_encoder *drm_enc) > struct msm_drm_private *priv; > int i = 0; > > - if (!drm_enc) { > - DPU_ERROR("invalid encoder\n"); > - return; > - } else if (!drm_enc->dev) { > - DPU_ERROR("invalid dev\n"); > - return; > - } > - > dpu_enc = to_dpu_encoder_virt(drm_enc); > DPU_DEBUG_ENC(dpu_enc, "\n");
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 0e9d3fa1544b..984f8a59cb73 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -1153,10 +1153,6 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc) struct msm_drm_private *priv; struct drm_display_mode *cur_mode = NULL; - if (!drm_enc) { - DPU_ERROR("invalid encoder\n"); - return; - } dpu_enc = to_dpu_encoder_virt(drm_enc); mutex_lock(&dpu_enc->enc_lock); @@ -1203,14 +1199,6 @@ static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc) struct msm_drm_private *priv; int i = 0; - if (!drm_enc) { - DPU_ERROR("invalid encoder\n"); - return; - } else if (!drm_enc->dev) { - DPU_ERROR("invalid dev\n"); - return; - } - dpu_enc = to_dpu_encoder_virt(drm_enc); DPU_DEBUG_ENC(dpu_enc, "\n");