| Message ID | 20211110105922.217895-13-bhupesh.sharma@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Enable Qualcomm Crypto Engine on sm8150 & sm8250 | expand |
Hi Bhupesh, On 11/10/21 12:59 PM, Bhupesh Sharma wrote: > Since we are using soc specific qce crypto IP compatibles > in the bindings now, use the same in the device tree files > which include the crypto nodes. > > Cc: Thara Gopinath <thara.gopinath@linaro.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > index 933b56103a46..f477d026c949 100644 > --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > @@ -204,7 +204,7 @@ cryptobam: dma-controller@704000 { > }; > > crypto: crypto@73a000 { > - compatible = "qcom,crypto-v5.1"; > + compatible = "qcom,ipq6018-qce"; > reg = <0x0 0x0073a000 0x0 0x6000>; > clocks = <&gcc GCC_CRYPTO_AHB_CLK>, > <&gcc GCC_CRYPTO_AXI_CLK>, > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 526087586ba4..8e7cbadff25a 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -2329,7 +2329,7 @@ cryptobam: dma-controller@1dc4000 { > }; > > crypto: crypto@1dfa000 { > - compatible = "qcom,crypto-v5.4"; > + compatible = "qcom,sdm845-qce"; > reg = <0 0x01dfa000 0 0x6000>; > clocks = <&gcc GCC_CE1_AHB_CLK>, > <&gcc GCC_CE1_AXI_CLK>, > and in connection to my review comment on v5 11/22 there should be done similar changes for ipq8074.dtsi and msm8996.dtsi. -- Best wishes, Vladimir
Hi Vladimir, On Fri, 12 Nov 2021 at 15:56, Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> wrote: > > Hi Bhupesh, > > On 11/10/21 12:59 PM, Bhupesh Sharma wrote: > > Since we are using soc specific qce crypto IP compatibles > > in the bindings now, use the same in the device tree files > > which include the crypto nodes. > > > > Cc: Thara Gopinath <thara.gopinath@linaro.org> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > Cc: Rob Herring <robh+dt@kernel.org> > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +- > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > > index 933b56103a46..f477d026c949 100644 > > --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi > > +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > > @@ -204,7 +204,7 @@ cryptobam: dma-controller@704000 { > > }; > > > > crypto: crypto@73a000 { > > - compatible = "qcom,crypto-v5.1"; > > + compatible = "qcom,ipq6018-qce"; > > reg = <0x0 0x0073a000 0x0 0x6000>; > > clocks = <&gcc GCC_CRYPTO_AHB_CLK>, > > <&gcc GCC_CRYPTO_AXI_CLK>, > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > > index 526087586ba4..8e7cbadff25a 100644 > > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > > @@ -2329,7 +2329,7 @@ cryptobam: dma-controller@1dc4000 { > > }; > > > > crypto: crypto@1dfa000 { > > - compatible = "qcom,crypto-v5.4"; > > + compatible = "qcom,sdm845-qce"; > > reg = <0 0x01dfa000 0 0x6000>; > > clocks = <&gcc GCC_CE1_AHB_CLK>, > > <&gcc GCC_CE1_AXI_CLK>, > > > > and in connection to my review comment on v5 11/22 there should be done > similar changes for ipq8074.dtsi and msm8996.dtsi. Ok, I will fix this in v6. Thanks, Bhupesh
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi index 933b56103a46..f477d026c949 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -204,7 +204,7 @@ cryptobam: dma-controller@704000 { }; crypto: crypto@73a000 { - compatible = "qcom,crypto-v5.1"; + compatible = "qcom,ipq6018-qce"; reg = <0x0 0x0073a000 0x0 0x6000>; clocks = <&gcc GCC_CRYPTO_AHB_CLK>, <&gcc GCC_CRYPTO_AXI_CLK>, diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 526087586ba4..8e7cbadff25a 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -2329,7 +2329,7 @@ cryptobam: dma-controller@1dc4000 { }; crypto: crypto@1dfa000 { - compatible = "qcom,crypto-v5.4"; + compatible = "qcom,sdm845-qce"; reg = <0 0x01dfa000 0 0x6000>; clocks = <&gcc GCC_CE1_AHB_CLK>, <&gcc GCC_CE1_AXI_CLK>,
Since we are using soc specific qce crypto IP compatibles in the bindings now, use the same in the device tree files which include the crypto nodes. Cc: Thara Gopinath <thara.gopinath@linaro.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Rob Herring <robh+dt@kernel.org> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +- arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)