| Message ID | 20211201072915.3969178-13-vkoul@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: Add support for SM8450 SoC and QRD board | expand |
On 01.12.2021 08:29, Vinod Koul wrote: > SM8450 QRD platform has bunch of PMICs, include the common ones PM8350, > PM8350b and PMR735b > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts > index 3e65d662ab8c..48228888f500 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts > +++ b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts > @@ -8,6 +8,9 @@ > #include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > #include "sm8450.dtsi" > +#include "pm8350.dtsi" > +#include "pm8350b.dtsi" > +#include "pmr735b.dtsi" > > / { > model = "Qualcomm Technologies, Inc. SM8450 QRD"; > Again, this could have gone into a single "add board DTS" patch, but this works too, I guess.. Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> Konrad
On Wed 01 Dec 07:23 PST 2021, Konrad Dybcio wrote: > > On 01.12.2021 08:29, Vinod Koul wrote: > > SM8450 QRD platform has bunch of PMICs, include the common ones PM8350, > > PM8350b and PMR735b > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > --- > > arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts > > index 3e65d662ab8c..48228888f500 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts > > +++ b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts > > @@ -8,6 +8,9 @@ > > #include <dt-bindings/gpio/gpio.h> > > #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > > #include "sm8450.dtsi" > > +#include "pm8350.dtsi" > > +#include "pm8350b.dtsi" > > +#include "pmr735b.dtsi" > > > > / { > > model = "Qualcomm Technologies, Inc. SM8450 QRD"; > > > Again, this could have gone into a single "add board DTS" patch, but this > > works too, I guess.. > I like that suggestion, putting the qrd.dts as a single patch at the end of the series would look nice. Regards, Bjorn > > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > > > Konrad >
On 07-12-21, 07:05, Bjorn Andersson wrote: > On Wed 01 Dec 07:23 PST 2021, Konrad Dybcio wrote: > > > > > On 01.12.2021 08:29, Vinod Koul wrote: > > > SM8450 QRD platform has bunch of PMICs, include the common ones PM8350, > > > PM8350b and PMR735b > > > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > > --- > > > arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts > > > index 3e65d662ab8c..48228888f500 100644 > > > --- a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts > > > +++ b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts > > > @@ -8,6 +8,9 @@ > > > #include <dt-bindings/gpio/gpio.h> > > > #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > > > #include "sm8450.dtsi" > > > +#include "pm8350.dtsi" > > > +#include "pm8350b.dtsi" > > > +#include "pmr735b.dtsi" > > > > > > / { > > > model = "Qualcomm Technologies, Inc. SM8450 QRD"; > > > > > Again, this could have gone into a single "add board DTS" patch, but this > > > > works too, I guess.. > > > > I like that suggestion, putting the qrd.dts as a single patch at the end > of the series would look nice. I can do that.. I think I would do a dts patch but would keep regulator one separate..
diff --git a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts index 3e65d662ab8c..48228888f500 100644 --- a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts +++ b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts @@ -8,6 +8,9 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> #include "sm8450.dtsi" +#include "pm8350.dtsi" +#include "pm8350b.dtsi" +#include "pmr735b.dtsi" / { model = "Qualcomm Technologies, Inc. SM8450 QRD";
SM8450 QRD platform has bunch of PMICs, include the common ones PM8350, PM8350b and PMR735b Signed-off-by: Vinod Koul <vkoul@kernel.org> --- arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 3 +++ 1 file changed, 3 insertions(+)