| Message ID | 20211209103505.197453-11-vkoul@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: qcom: Add support for SM8450 SoC and QRD board | expand |
On 09/12/2021 05:35, Vinod Koul wrote: > Add the spmi bus as found in the SM8450 SoC > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index f75de777f6ea..b80e34fd3fe1 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 { > interrupt-controller; > }; > > + spmi_bus: spmi@c42d000 { > + compatible = "qcom,spmi-pmic-arb"; > + reg = <0x0 0x0c400000 0x0 0x00003000>, > + <0x0 0x0c500000 0x0 0x00400000>, > + <0x0 0x0c440000 0x0 0x00080000>, > + <0x0 0x0c4c0000 0x0 0x00010000>, > + <0x0 0x0c42d000 0x0 0x00010000>; This is a patch from December 2021. Is there anything blocking it from being merged? The same applies to several other patches here. Best regards, Krzysztof
On 2022-10-24 16:56, Krzysztof Kozlowski wrote: > On 09/12/2021 05:35, Vinod Koul wrote: >> Add the spmi bus as found in the SM8450 SoC >> >> Signed-off-by: Vinod Koul <vkoul@kernel.org> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> >> --- >> arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi >> b/arch/arm64/boot/dts/qcom/sm8450.dtsi >> index f75de777f6ea..b80e34fd3fe1 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >> @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 { >> interrupt-controller; >> }; >> >> + spmi_bus: spmi@c42d000 { >> + compatible = "qcom,spmi-pmic-arb"; >> + reg = <0x0 0x0c400000 0x0 0x00003000>, >> + <0x0 0x0c500000 0x0 0x00400000>, >> + <0x0 0x0c440000 0x0 0x00080000>, >> + <0x0 0x0c4c0000 0x0 0x00010000>, >> + <0x0 0x0c42d000 0x0 0x00010000>; > > This is a patch from December 2021. Is there anything blocking it from > being merged? I think it depended on a series of changes to the driver, as 8450 has a newer SPMI ver Konrad > > The same applies to several other patches here. > > Best regards, > Krzysztof
On 24/10/2022 11:06, konrad.dybcio@somainline.org wrote: > On 2022-10-24 16:56, Krzysztof Kozlowski wrote: >> On 09/12/2021 05:35, Vinod Koul wrote: >>> Add the spmi bus as found in the SM8450 SoC >>> >>> Signed-off-by: Vinod Koul <vkoul@kernel.org> >>> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> >>> --- >>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++ >>> 1 file changed, 18 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> index f75de777f6ea..b80e34fd3fe1 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 { >>> interrupt-controller; >>> }; >>> >>> + spmi_bus: spmi@c42d000 { >>> + compatible = "qcom,spmi-pmic-arb"; >>> + reg = <0x0 0x0c400000 0x0 0x00003000>, >>> + <0x0 0x0c500000 0x0 0x00400000>, >>> + <0x0 0x0c440000 0x0 0x00080000>, >>> + <0x0 0x0c4c0000 0x0 0x00010000>, >>> + <0x0 0x0c42d000 0x0 0x00010000>; >> >> This is a patch from December 2021. Is there anything blocking it from >> being merged? > I think it depended on a series of changes to the driver, as 8450 has a > newer SPMI ver > If the new device node in DTS (for new hardware) depends on driver changes, then something here is completely broken. Probably in the bindings for Qualcomm SPMI PMIC. I expect adding DTS independently of driver changes. It anyway goes always via separate branches. Best regards, Krzysztof
On 24/10/2022 17:56, Krzysztof Kozlowski wrote: > On 09/12/2021 05:35, Vinod Koul wrote: >> Add the spmi bus as found in the SM8450 SoC >> >> Signed-off-by: Vinod Koul <vkoul@kernel.org> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> >> --- >> arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi >> index f75de777f6ea..b80e34fd3fe1 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >> @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 { >> interrupt-controller; >> }; >> >> + spmi_bus: spmi@c42d000 { >> + compatible = "qcom,spmi-pmic-arb"; >> + reg = <0x0 0x0c400000 0x0 0x00003000>, >> + <0x0 0x0c500000 0x0 0x00400000>, >> + <0x0 0x0c440000 0x0 0x00080000>, >> + <0x0 0x0c4c0000 0x0 0x00010000>, >> + <0x0 0x0c42d000 0x0 0x00010000>; > > This is a patch from December 2021. Is there anything blocking it from > being merged? > > The same applies to several other patches here. As far as I know, Stephen still didn't pick up the spmi-pmic-arb support for the PMIC on the SM8450 platform. Thus we also can not merge the DT parts.
On 24/10/2022 12:45, Dmitry Baryshkov wrote: > On 24/10/2022 17:56, Krzysztof Kozlowski wrote: >> On 09/12/2021 05:35, Vinod Koul wrote: >>> Add the spmi bus as found in the SM8450 SoC >>> >>> Signed-off-by: Vinod Koul <vkoul@kernel.org> >>> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> >>> --- >>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++ >>> 1 file changed, 18 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> index f75de777f6ea..b80e34fd3fe1 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>> @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 { >>> interrupt-controller; >>> }; >>> >>> + spmi_bus: spmi@c42d000 { >>> + compatible = "qcom,spmi-pmic-arb"; >>> + reg = <0x0 0x0c400000 0x0 0x00003000>, >>> + <0x0 0x0c500000 0x0 0x00400000>, >>> + <0x0 0x0c440000 0x0 0x00080000>, >>> + <0x0 0x0c4c0000 0x0 0x00010000>, >>> + <0x0 0x0c42d000 0x0 0x00010000>; >> >> This is a patch from December 2021. Is there anything blocking it from >> being merged? >> >> The same applies to several other patches here. > > As far as I know, Stephen still didn't pick up the spmi-pmic-arb support > for the PMIC on the SM8450 platform. Thus we also can not merge the DT > parts. Why we cannot merge DTS? How is DTS with new nodes depending on any driver changes? Just like I replied to Konrad - if that's true, bindings are simply wrong and should be fixed. Best regards, Krzysztof
On 24/10/2022 19:46, Krzysztof Kozlowski wrote: > On 24/10/2022 12:45, Dmitry Baryshkov wrote: >> On 24/10/2022 17:56, Krzysztof Kozlowski wrote: >>> On 09/12/2021 05:35, Vinod Koul wrote: >>>> Add the spmi bus as found in the SM8450 SoC >>>> >>>> Signed-off-by: Vinod Koul <vkoul@kernel.org> >>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> >>>> --- >>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++ >>>> 1 file changed, 18 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>> index f75de777f6ea..b80e34fd3fe1 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>> @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 { >>>> interrupt-controller; >>>> }; >>>> >>>> + spmi_bus: spmi@c42d000 { >>>> + compatible = "qcom,spmi-pmic-arb"; >>>> + reg = <0x0 0x0c400000 0x0 0x00003000>, >>>> + <0x0 0x0c500000 0x0 0x00400000>, >>>> + <0x0 0x0c440000 0x0 0x00080000>, >>>> + <0x0 0x0c4c0000 0x0 0x00010000>, >>>> + <0x0 0x0c42d000 0x0 0x00010000>; >>> >>> This is a patch from December 2021. Is there anything blocking it from >>> being merged? >>> >>> The same applies to several other patches here. >> >> As far as I know, Stephen still didn't pick up the spmi-pmic-arb support >> for the PMIC on the SM8450 platform. Thus we also can not merge the DT >> parts. > > Why we cannot merge DTS? How is DTS with new nodes depending on any > driver changes? In this particular case, there was an open question, what should be the bindings for the PMIC ARB v7. > > Just like I replied to Konrad - if that's true, bindings are simply > wrong and should be fixed. Maybe I missed the reply. Which email are you referring to? > > Best regards, > Krzysztof >
On 24/10/2022 12:48, Dmitry Baryshkov wrote: > On 24/10/2022 19:46, Krzysztof Kozlowski wrote: >> On 24/10/2022 12:45, Dmitry Baryshkov wrote: >>> On 24/10/2022 17:56, Krzysztof Kozlowski wrote: >>>> On 09/12/2021 05:35, Vinod Koul wrote: >>>>> Add the spmi bus as found in the SM8450 SoC >>>>> >>>>> Signed-off-by: Vinod Koul <vkoul@kernel.org> >>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> >>>>> --- >>>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++ >>>>> 1 file changed, 18 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>> index f75de777f6ea..b80e34fd3fe1 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>> @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 { >>>>> interrupt-controller; >>>>> }; >>>>> >>>>> + spmi_bus: spmi@c42d000 { >>>>> + compatible = "qcom,spmi-pmic-arb"; >>>>> + reg = <0x0 0x0c400000 0x0 0x00003000>, >>>>> + <0x0 0x0c500000 0x0 0x00400000>, >>>>> + <0x0 0x0c440000 0x0 0x00080000>, >>>>> + <0x0 0x0c4c0000 0x0 0x00010000>, >>>>> + <0x0 0x0c42d000 0x0 0x00010000>; >>>> >>>> This is a patch from December 2021. Is there anything blocking it from >>>> being merged? >>>> >>>> The same applies to several other patches here. >>> >>> As far as I know, Stephen still didn't pick up the spmi-pmic-arb support >>> for the PMIC on the SM8450 platform. Thus we also can not merge the DT >>> parts. >> >> Why we cannot merge DTS? How is DTS with new nodes depending on any >> driver changes? > > In this particular case, there was an open question, what should be the > bindings for the PMIC ARB v7. Ah, so it is about PMIC ARB v7 bindings? Then it's reasonable to wait with this one. I just had an impression that it's about driver changes... > >> >> Just like I replied to Konrad - if that's true, bindings are simply >> wrong and should be fixed. > > Maybe I missed the reply. Which email are you referring to? I meant about this one: https://lore.kernel.org/linux-arm-msm/8c1428a6-f268-cb03-3e55-887d30236924@linaro.org/T/#m50f4c72775492046f9b0a172e974cab83563af3c Best regards, Krzysztof
On Mon, 24 Oct 2022 at 21:56, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 24/10/2022 12:48, Dmitry Baryshkov wrote: > > On 24/10/2022 19:46, Krzysztof Kozlowski wrote: > >> On 24/10/2022 12:45, Dmitry Baryshkov wrote: > >>> On 24/10/2022 17:56, Krzysztof Kozlowski wrote: > >>>> On 09/12/2021 05:35, Vinod Koul wrote: > >>>>> Add the spmi bus as found in the SM8450 SoC > >>>>> > >>>>> Signed-off-by: Vinod Koul <vkoul@kernel.org> > >>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > >>>>> --- > >>>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++ > >>>>> 1 file changed, 18 insertions(+) > >>>>> > >>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > >>>>> index f75de777f6ea..b80e34fd3fe1 100644 > >>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > >>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > >>>>> @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 { > >>>>> interrupt-controller; > >>>>> }; > >>>>> > >>>>> + spmi_bus: spmi@c42d000 { > >>>>> + compatible = "qcom,spmi-pmic-arb"; > >>>>> + reg = <0x0 0x0c400000 0x0 0x00003000>, > >>>>> + <0x0 0x0c500000 0x0 0x00400000>, > >>>>> + <0x0 0x0c440000 0x0 0x00080000>, > >>>>> + <0x0 0x0c4c0000 0x0 0x00010000>, > >>>>> + <0x0 0x0c42d000 0x0 0x00010000>; > >>>> > >>>> This is a patch from December 2021. Is there anything blocking it from > >>>> being merged? > >>>> > >>>> The same applies to several other patches here. > >>> > >>> As far as I know, Stephen still didn't pick up the spmi-pmic-arb support > >>> for the PMIC on the SM8450 platform. Thus we also can not merge the DT > >>> parts. > >> > >> Why we cannot merge DTS? How is DTS with new nodes depending on any > >> driver changes? > > > > In this particular case, there was an open question, what should be the > > bindings for the PMIC ARB v7. > > Ah, so it is about PMIC ARB v7 bindings? Then it's reasonable to wait > with this one. I just had an impression that it's about driver changes... Yes, it's about binding. Thus we have been waiting for quite some time. > > > > >> > >> Just like I replied to Konrad - if that's true, bindings are simply > >> wrong and should be fixed. > > > > Maybe I missed the reply. Which email are you referring to? > > I meant about this one: > > https://lore.kernel.org/linux-arm-msm/8c1428a6-f268-cb03-3e55-887d30236924@linaro.org/T/#m50f4c72775492046f9b0a172e974cab83563af3c Ack, for some reason I got it later than the previous one. > > Best regards, > Krzysztof >
On 24-10-22, 21:58, Dmitry Baryshkov wrote: > On Mon, 24 Oct 2022 at 21:56, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > > > > On 24/10/2022 12:48, Dmitry Baryshkov wrote: > > > On 24/10/2022 19:46, Krzysztof Kozlowski wrote: > > >> On 24/10/2022 12:45, Dmitry Baryshkov wrote: > > >>> On 24/10/2022 17:56, Krzysztof Kozlowski wrote: > > >>>> On 09/12/2021 05:35, Vinod Koul wrote: > > >>>>> Add the spmi bus as found in the SM8450 SoC > > >>>>> > > >>>>> Signed-off-by: Vinod Koul <vkoul@kernel.org> > > >>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > > >>>>> --- > > >>>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++ > > >>>>> 1 file changed, 18 insertions(+) > > >>>>> > > >>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > > >>>>> index f75de777f6ea..b80e34fd3fe1 100644 > > >>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > > >>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > > >>>>> @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 { > > >>>>> interrupt-controller; > > >>>>> }; > > >>>>> > > >>>>> + spmi_bus: spmi@c42d000 { > > >>>>> + compatible = "qcom,spmi-pmic-arb"; > > >>>>> + reg = <0x0 0x0c400000 0x0 0x00003000>, > > >>>>> + <0x0 0x0c500000 0x0 0x00400000>, > > >>>>> + <0x0 0x0c440000 0x0 0x00080000>, > > >>>>> + <0x0 0x0c4c0000 0x0 0x00010000>, > > >>>>> + <0x0 0x0c42d000 0x0 0x00010000>; > > >>>> > > >>>> This is a patch from December 2021. Is there anything blocking it from > > >>>> being merged? > > >>>> > > >>>> The same applies to several other patches here. > > >>> > > >>> As far as I know, Stephen still didn't pick up the spmi-pmic-arb support > > >>> for the PMIC on the SM8450 platform. Thus we also can not merge the DT > > >>> parts. > > >> > > >> Why we cannot merge DTS? How is DTS with new nodes depending on any > > >> driver changes? > > > > > > In this particular case, there was an open question, what should be the > > > bindings for the PMIC ARB v7. > > > > Ah, so it is about PMIC ARB v7 bindings? Then it's reasonable to wait > > with this one. I just had an impression that it's about driver changes... > > Yes, it's about binding. Thus we have been waiting for quite some time. Yes sadly Steven has stopped responding to emails or IRC.. I am not sure whats going on! Even the SPMI tree is not being actively maintained with only few patches which were picked in last cycle since this year!
On 26/10/2022 07:33, Vinod Koul wrote: > On 24-10-22, 21:58, Dmitry Baryshkov wrote: >> On Mon, 24 Oct 2022 at 21:56, Krzysztof Kozlowski >> <krzysztof.kozlowski@linaro.org> wrote: >>> >>> On 24/10/2022 12:48, Dmitry Baryshkov wrote: >>>> On 24/10/2022 19:46, Krzysztof Kozlowski wrote: >>>>> On 24/10/2022 12:45, Dmitry Baryshkov wrote: >>>>>> On 24/10/2022 17:56, Krzysztof Kozlowski wrote: >>>>>>> On 09/12/2021 05:35, Vinod Koul wrote: >>>>>>>> Add the spmi bus as found in the SM8450 SoC >>>>>>>> >>>>>>>> Signed-off-by: Vinod Koul <vkoul@kernel.org> >>>>>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> >>>>>>>> --- >>>>>>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++ >>>>>>>> 1 file changed, 18 insertions(+) >>>>>>>> >>>>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>>>>> index f75de777f6ea..b80e34fd3fe1 100644 >>>>>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>>>>> @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 { >>>>>>>> interrupt-controller; >>>>>>>> }; >>>>>>>> >>>>>>>> + spmi_bus: spmi@c42d000 { >>>>>>>> + compatible = "qcom,spmi-pmic-arb"; >>>>>>>> + reg = <0x0 0x0c400000 0x0 0x00003000>, >>>>>>>> + <0x0 0x0c500000 0x0 0x00400000>, >>>>>>>> + <0x0 0x0c440000 0x0 0x00080000>, >>>>>>>> + <0x0 0x0c4c0000 0x0 0x00010000>, >>>>>>>> + <0x0 0x0c42d000 0x0 0x00010000>; >>>>>>> >>>>>>> This is a patch from December 2021. Is there anything blocking it from >>>>>>> being merged? >>>>>>> >>>>>>> The same applies to several other patches here. >>>>>> >>>>>> As far as I know, Stephen still didn't pick up the spmi-pmic-arb support >>>>>> for the PMIC on the SM8450 platform. Thus we also can not merge the DT >>>>>> parts. >>>>> >>>>> Why we cannot merge DTS? How is DTS with new nodes depending on any >>>>> driver changes? >>>> >>>> In this particular case, there was an open question, what should be the >>>> bindings for the PMIC ARB v7. >>> >>> Ah, so it is about PMIC ARB v7 bindings? Then it's reasonable to wait >>> with this one. I just had an impression that it's about driver changes... >> >> Yes, it's about binding. Thus we have been waiting for quite some time. > > Yes sadly Steven has stopped responding to emails or IRC.. I am not > sure whats going on! > > Even the SPMI tree is not being actively maintained with only few > patches which were picked in last cycle since this year! It's in -next now and 8450 boots and works fine. If the binding situation has been resolved, I say merge this ASAP! :) Konrad >
On 17/11/2022 15:57, Konrad Dybcio wrote: > > > On 26/10/2022 07:33, Vinod Koul wrote: >> On 24-10-22, 21:58, Dmitry Baryshkov wrote: >>> On Mon, 24 Oct 2022 at 21:56, Krzysztof Kozlowski >>> <krzysztof.kozlowski@linaro.org> wrote: >>>> >>>> On 24/10/2022 12:48, Dmitry Baryshkov wrote: >>>>> On 24/10/2022 19:46, Krzysztof Kozlowski wrote: >>>>>> On 24/10/2022 12:45, Dmitry Baryshkov wrote: >>>>>>> On 24/10/2022 17:56, Krzysztof Kozlowski wrote: >>>>>>>> On 09/12/2021 05:35, Vinod Koul wrote: >>>>>>>>> Add the spmi bus as found in the SM8450 SoC >>>>>>>>> >>>>>>>>> Signed-off-by: Vinod Koul <vkoul@kernel.org> >>>>>>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> >>>>>>>>> --- >>>>>>>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++ >>>>>>>>> 1 file changed, 18 insertions(+) >>>>>>>>> >>>>>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>>>>>> b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>>>>>> index f75de777f6ea..b80e34fd3fe1 100644 >>>>>>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>>>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>>>>>> @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 { >>>>>>>>> interrupt-controller; >>>>>>>>> }; >>>>>>>>> >>>>>>>>> + spmi_bus: spmi@c42d000 { >>>>>>>>> + compatible = "qcom,spmi-pmic-arb"; >>>>>>>>> + reg = <0x0 0x0c400000 0x0 0x00003000>, >>>>>>>>> + <0x0 0x0c500000 0x0 0x00400000>, >>>>>>>>> + <0x0 0x0c440000 0x0 0x00080000>, >>>>>>>>> + <0x0 0x0c4c0000 0x0 0x00010000>, >>>>>>>>> + <0x0 0x0c42d000 0x0 0x00010000>; >>>>>>>> >>>>>>>> This is a patch from December 2021. Is there anything blocking >>>>>>>> it from >>>>>>>> being merged? >>>>>>>> >>>>>>>> The same applies to several other patches here. >>>>>>> >>>>>>> As far as I know, Stephen still didn't pick up the spmi-pmic-arb >>>>>>> support >>>>>>> for the PMIC on the SM8450 platform. Thus we also can not merge >>>>>>> the DT >>>>>>> parts. >>>>>> >>>>>> Why we cannot merge DTS? How is DTS with new nodes depending on any >>>>>> driver changes? >>>>> >>>>> In this particular case, there was an open question, what should be >>>>> the >>>>> bindings for the PMIC ARB v7. >>>> >>>> Ah, so it is about PMIC ARB v7 bindings? Then it's reasonable to wait >>>> with this one. I just had an impression that it's about driver >>>> changes... >>> >>> Yes, it's about binding. Thus we have been waiting for quite some time. >> >> Yes sadly Steven has stopped responding to emails or IRC.. I am not >> sure whats going on! >> >> Even the SPMI tree is not being actively maintained with only few >> patches which were picked in last cycle since this year! > It's in -next now and 8450 boots and works fine. If the binding > situation has been resolved, I say merge this ASAP! :) > > Konrad With a small nit: it needs to be rebased, and should come between aoss_qmp: and ipcc: address-wise (ipcc wasn't around a year ago in this DT, it seems). Also most (all?) other nodes in the DT use reg = <0 [..]> instead of reg = <0x0 [..]> so that could be fixed up as well. Konrad >>
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index f75de777f6ea..b80e34fd3fe1 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 { interrupt-controller; }; + spmi_bus: spmi@c42d000 { + compatible = "qcom,spmi-pmic-arb"; + reg = <0x0 0x0c400000 0x0 0x00003000>, + <0x0 0x0c500000 0x0 0x00400000>, + <0x0 0x0c440000 0x0 0x00080000>, + <0x0 0x0c4c0000 0x0 0x00010000>, + <0x0 0x0c42d000 0x0 0x00010000>; + reg-names = "core", "chnls", "obsrvr", "intr", "cnfg"; + interrupt-names = "periph_irq"; + interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>; + qcom,ee = <0>; + qcom,channel = <0>; + #address-cells = <2>; + #size-cells = <0>; + interrupt-controller; + #interrupt-cells = <4>; + }; + tlmm: pinctrl@f100000 { compatible = "qcom,sm8450-tlmm"; reg = <0 0x0f100000 0 0x300000>;