From patchwork Mon Jan 10 19:31:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 12709080 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 941AEC433FE for ; Mon, 10 Jan 2022 19:31:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243555AbiAJTbD (ORCPT ); Mon, 10 Jan 2022 14:31:03 -0500 Received: from mga12.intel.com ([192.55.52.136]:56170 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243498AbiAJTbB (ORCPT ); Mon, 10 Jan 2022 14:31:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641843061; x=1673379061; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xlm8CglC+we0H9NkOpphMLOgZ8B9k3kYAjWWjk776tM=; b=GyB2er0qhaJcEd5UjVGWEWdTEwn5mNPL4sr1O+ojewPhOU8wndWLY/dG uSszna0Ht4nVuk5Btq8JspirVzy7e1LFmddu3i3v/9cPUeK9n0o65RMe8 8kiZm0UOn3MPHh7nEuLrQejudDx6/0UMln374s4TTY04IBhlDESeqQrOY cPGrZHOPSRpIZTIKMBbHN18i+un6AUincoInJR4oZxtXAoC28bEpSbfFM ptOM96ZGuZHovwnaI5Q6+qHSvopPK4I500Jscj6j22lJmKdfPRtExvhG/ ALf0gtTb/Ux+uxx8+guLeEINHgXe9pYeA1w551rXiFIMvwc/7xGRkOEXP Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10223"; a="223288206" X-IronPort-AV: E=Sophos;i="5.88,277,1635231600"; d="scan'208";a="223288206" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2022 11:31:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,277,1635231600"; d="scan'208";a="669547779" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 10 Jan 2022 11:30:58 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 4A31B2C7; Mon, 10 Jan 2022 21:31:09 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Dmitry Baryshkov , Jonathan Cameron , Andreas Kemnade , linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Gross , Bjorn Andersson , Jonathan Cameron , Lars-Peter Clausen , Peter Rosin Subject: [PATCH v2 5/5] iio: afe: iio-rescale: Re-use generic struct s32_fract Date: Mon, 10 Jan 2022 21:31:04 +0200 Message-Id: <20220110193104.75225-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220110193104.75225-1-andriy.shevchenko@linux.intel.com> References: <20220110193104.75225-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Instead of custom data type re-use generic struct s32_fract. No changes intended. The new member is put to be the first one to avoid additional pointer arithmetic. Besides that one may switch to use fract member to perform container_of(), which will be no-op in this case, to get struct rescale. Signed-off-by: Andy Shevchenko --- I found this better in order how code is structurally (re)organized. I may rebase this on top of ongoing AFE series. Also reveals possibility to switch to rational best approximation. But this is another story... v2: no changes drivers/iio/afe/iio-rescale.c | 74 +++++++++++++++++------------------ 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/iio/afe/iio-rescale.c b/drivers/iio/afe/iio-rescale.c index 774eb3044edd..0368bca8a485 100644 --- a/drivers/iio/afe/iio-rescale.c +++ b/drivers/iio/afe/iio-rescale.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -21,17 +22,16 @@ struct rescale; struct rescale_cfg { enum iio_chan_type type; - int (*props)(struct device *dev, struct rescale *rescale); + int (*props)(struct device *dev, struct s32_fract *fract); }; struct rescale { + struct s32_fract fract; const struct rescale_cfg *cfg; struct iio_channel *source; struct iio_chan_spec chan; struct iio_chan_spec_ext_info *ext_info; bool chan_processed; - s32 numerator; - s32 denominator; }; static int rescale_read_raw(struct iio_dev *indio_dev, @@ -39,6 +39,7 @@ static int rescale_read_raw(struct iio_dev *indio_dev, int *val, int *val2, long mask) { struct rescale *rescale = iio_priv(indio_dev); + struct s32_fract *fract = &rescale->fract; unsigned long long tmp; int ret; @@ -67,19 +68,19 @@ static int rescale_read_raw(struct iio_dev *indio_dev, } switch (ret) { case IIO_VAL_FRACTIONAL: - *val *= rescale->numerator; - *val2 *= rescale->denominator; + *val *= fract->numerator; + *val2 *= fract->denominator; return ret; case IIO_VAL_INT: - *val *= rescale->numerator; - if (rescale->denominator == 1) + *val *= fract->numerator; + if (fract->denominator == 1) return ret; - *val2 = rescale->denominator; + *val2 = fract->denominator; return IIO_VAL_FRACTIONAL; case IIO_VAL_FRACTIONAL_LOG2: tmp = *val * 1000000000LL; - do_div(tmp, rescale->denominator); - tmp *= rescale->numerator; + do_div(tmp, fract->denominator); + tmp *= fract->numerator; do_div(tmp, 1000000000LL); *val = tmp; return ret; @@ -175,7 +176,7 @@ static int rescale_configure_channel(struct device *dev, } static int rescale_current_sense_amplifier_props(struct device *dev, - struct rescale *rescale) + struct s32_fract *fract) { u32 sense; u32 gain_mult = 1; @@ -199,22 +200,22 @@ static int rescale_current_sense_amplifier_props(struct device *dev, * numerator/denominator from overflowing. */ factor = gcd(sense, 1000000); - rescale->numerator = 1000000 / factor; - rescale->denominator = sense / factor; + fract->numerator = 1000000 / factor; + fract->denominator = sense / factor; - factor = gcd(rescale->numerator, gain_mult); - rescale->numerator /= factor; - rescale->denominator *= gain_mult / factor; + factor = gcd(fract->numerator, gain_mult); + fract->numerator /= factor; + fract->denominator *= gain_mult / factor; - factor = gcd(rescale->denominator, gain_div); - rescale->numerator *= gain_div / factor; - rescale->denominator /= factor; + factor = gcd(fract->denominator, gain_div); + fract->numerator *= gain_div / factor; + fract->denominator /= factor; return 0; } static int rescale_current_sense_shunt_props(struct device *dev, - struct rescale *rescale) + struct s32_fract *fract) { u32 shunt; u32 factor; @@ -228,35 +229,33 @@ static int rescale_current_sense_shunt_props(struct device *dev, } factor = gcd(shunt, 1000000); - rescale->numerator = 1000000 / factor; - rescale->denominator = shunt / factor; + fract->numerator = 1000000 / factor; + fract->denominator = shunt / factor; return 0; } static int rescale_voltage_divider_props(struct device *dev, - struct rescale *rescale) + struct s32_fract *fract) { int ret; u32 factor; - ret = device_property_read_u32(dev, "output-ohms", - &rescale->denominator); + ret = device_property_read_u32(dev, "output-ohms", &fract->denominator); if (ret) { dev_err(dev, "failed to read output-ohms: %d\n", ret); return ret; } - ret = device_property_read_u32(dev, "full-ohms", - &rescale->numerator); + ret = device_property_read_u32(dev, "full-ohms", &fract->numerator); if (ret) { dev_err(dev, "failed to read full-ohms: %d\n", ret); return ret; } - factor = gcd(rescale->numerator, rescale->denominator); - rescale->numerator /= factor; - rescale->denominator /= factor; + factor = gcd(fract->numerator, fract->denominator); + fract->numerator /= factor; + fract->denominator /= factor; return 0; } @@ -299,6 +298,7 @@ static int rescale_probe(struct platform_device *pdev) struct iio_dev *indio_dev; struct iio_channel *source; struct rescale *rescale; + struct s32_fract *fract; int sizeof_ext_info; int sizeof_priv; int i; @@ -322,24 +322,24 @@ static int rescale_probe(struct platform_device *pdev) return -ENOMEM; rescale = iio_priv(indio_dev); - + rescale->source = source; rescale->cfg = of_device_get_match_data(dev); - rescale->numerator = 1; - rescale->denominator = 1; - ret = rescale->cfg->props(dev, rescale); + fract = &rescale->fract; + fract->numerator = 1; + fract->denominator = 1; + + ret = rescale->cfg->props(dev, fract); if (ret) return ret; - if (!rescale->numerator || !rescale->denominator) { + if (!fract->numerator || !fract->denominator) { dev_err(dev, "invalid scaling factor.\n"); return -EINVAL; } platform_set_drvdata(pdev, indio_dev); - rescale->source = source; - indio_dev->name = dev_name(dev); indio_dev->info = &rescale_info; indio_dev->modes = INDIO_DIRECT_MODE;