| Message ID | 20220114115939.146434-1-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | rpmsg: qcom_smd: Fix redundant channel->assigned assignment | expand |
diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 540e027f08c4..0ee3f7ddabb0 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -1298,9 +1298,7 @@ static void qcom_channel_state_worker(struct work_struct *work) spin_unlock_irqrestore(&edge->channels_lock, flags); qcom_smd_create_device(channel); - channel->registered = true; spin_lock_irqsave(&edge->channels_lock, flags); - channel->registered = true; }
In qcom_channel_state_worker(), we are setting channel->registered to true when registering a channel, but this is getting repeated both before and after re-locking the channels_lock spinlock, which is obviously a typo. Remove the assignment done out of the spinlock to fix this redundancy. Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend") Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- drivers/rpmsg/qcom_smd.c | 2 -- 1 file changed, 2 deletions(-)