| Message ID | 20220317010640.2498502-2-swboyd@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dbcbeed94f3b6f7f24349a7f335cc603a682e7a7 |
| Headers | show |
| Series | Fix and update fingerprint flashing on herobrine | expand |
On Wed, Mar 16, 2022 at 06:06:39PM -0700, Stephen Boyd wrote: > Having these pins with outputs is good on a fresh boot because it puts > the boot and reset pins in a known "good" state. Unfortunately, that > conflicts with the fingerprint firmware flashing code. The firmware > flashing process binds and unbinds the cros-ec and spidev drivers and > that reapplies the pin output values after the flashing code has > overridden the gpio values. This causes a problem because we try to put > the device into bootloader mode, bind the spidev driver and that > inadvertently puts it right back into normal boot mode, breaking the > flashing process. > > Fix this by removing the outputs. We'll introduce a binding for > fingerprint cros-ec specifically to set the gpios properly via gpio APIs > during cros-ec driver probe instead. > > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Matthias Kaehlcke <mka@chromium.org> > Cc: Alexandru M Stan <amstan@chromium.org> > Fixes: 116f7cc43d28 ("arm64: dts: qcom: sc7280: Add herobrine-r1") > Signed-off-by: Stephen Boyd <swboyd@chromium.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Hi, On Wed, Mar 16, 2022 at 6:06 PM Stephen Boyd <swboyd@chromium.org> wrote: > > Having these pins with outputs is good on a fresh boot because it puts > the boot and reset pins in a known "good" state. Unfortunately, that > conflicts with the fingerprint firmware flashing code. The firmware > flashing process binds and unbinds the cros-ec and spidev drivers and > that reapplies the pin output values after the flashing code has > overridden the gpio values. This causes a problem because we try to put > the device into bootloader mode, bind the spidev driver and that > inadvertently puts it right back into normal boot mode, breaking the > flashing process. > > Fix this by removing the outputs. We'll introduce a binding for > fingerprint cros-ec specifically to set the gpios properly via gpio APIs > during cros-ec driver probe instead. > > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Matthias Kaehlcke <mka@chromium.org> > Cc: Alexandru M Stan <amstan@chromium.org> > Fixes: 116f7cc43d28 ("arm64: dts: qcom: sc7280: Add herobrine-r1") > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi index dc17f2079695..984a7faf0888 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -677,7 +677,6 @@ fp_rst_l: fp-rst-l { function = "gpio"; bias-disable; drive-strength = <2>; - output-high; }; fp_to_ap_irq_l: fp-to-ap-irq-l { @@ -691,7 +690,6 @@ fpmcu_boot0: fpmcu-boot0 { pins = "gpio68"; function = "gpio"; bias-disable; - output-low; }; gsc_ap_int_odl: gsc-ap-int-odl {
Having these pins with outputs is good on a fresh boot because it puts the boot and reset pins in a known "good" state. Unfortunately, that conflicts with the fingerprint firmware flashing code. The firmware flashing process binds and unbinds the cros-ec and spidev drivers and that reapplies the pin output values after the flashing code has overridden the gpio values. This causes a problem because we try to put the device into bootloader mode, bind the spidev driver and that inadvertently puts it right back into normal boot mode, breaking the flashing process. Fix this by removing the outputs. We'll introduce a binding for fingerprint cros-ec specifically to set the gpios properly via gpio APIs during cros-ec driver probe instead. Cc: Douglas Anderson <dianders@chromium.org> Cc: Matthias Kaehlcke <mka@chromium.org> Cc: Alexandru M Stan <amstan@chromium.org> Fixes: 116f7cc43d28 ("arm64: dts: qcom: sc7280: Add herobrine-r1") Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 -- 1 file changed, 2 deletions(-)