From patchwork Fri Mar 18 00:07:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 12784709 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66F02C433F5 for ; Fri, 18 Mar 2022 00:07:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230352AbiCRAIw (ORCPT ); Thu, 17 Mar 2022 20:08:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbiCRAIv (ORCPT ); Thu, 17 Mar 2022 20:08:51 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2A7E2AA198 for ; Thu, 17 Mar 2022 17:07:33 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id o26so3875336pgb.8 for ; Thu, 17 Mar 2022 17:07:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1i8tHBCz0yGUnXTP63evaW8shC/1FTv22ymAKssO43g=; b=Ur+HSlhkoIDLHekqpPNSXAVLlxD5+T81ff6OBaHTxdXzokDkA8qnnVLDj9q0QAArhQ 8B28qd/JYP4jKNuPGjkNF8Z9JI3moyBARf9Nk/nhV0r4cLAzMLmI/7ti/9uugVGYGR/J 4cAJHw+XO9GiplYxM7ZZn9UlMuvIuvwPzTl/g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1i8tHBCz0yGUnXTP63evaW8shC/1FTv22ymAKssO43g=; b=MljsCT+kMAAPlidwE5u1VgWpPDPPN2WDoAge4WDjuuQA1BTdrM6mSokHJHtUOMG1mN aMO9YxBiKwCAMUa3oAuo963Njs9RKXYa7K85qXHWCi8+UPQilGF97XyzpDO+PcfSkqQ9 3iN1KMeWo+1A4cLGVAPCV/uIXz80zYSxqFIWt94cLR9Jw+Sfrhlf8Sd9/b4VWxWLMhSD dpWEG3rQcLZpMXYIRmD/qQHM5tupXui5clJ1sOHOb9NJ17reagXRwzYwo+38pl8g4nCb rreaxVa/oOcWXLC5yj1/93QzdeH7B8lEXiuhCrTFtiGI6MgrpyjUg1/n7qMzK7HgTClX Y1Zg== X-Gm-Message-State: AOAM530PyvWFLdPBDwwSWqTIvy+VRVPNvNGXNzRsdOhHwSerItHMGwmq 4WGhZTTMhiyc2E6JkD2PmI0AJ8vKqPK72Q== X-Google-Smtp-Source: ABdhPJxx5b5fjDNUn/yUMHMvPSEd5Y6joMRanwaFw9+NHRmy92bdTzHYRpjmt7wsM7IX3PrGoD3Btw== X-Received: by 2002:a05:6a00:815:b0:4f6:ee04:30af with SMTP id m21-20020a056a00081500b004f6ee0430afmr7183021pfk.15.1647562053324; Thu, 17 Mar 2022 17:07:33 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:49cf:7701:359e:b28f]) by smtp.gmail.com with ESMTPSA id o5-20020a056a0015c500b004f76735be68sm8280640pfu.216.2022.03.17.17.07.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 17:07:33 -0700 (PDT) From: Stephen Boyd To: Rob Clark , Sean Paul Cc: linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Abhinav Kumar , Dmitry Baryshkov , Sean Paul Subject: [PATCH] drm/msm/dsi: Use connector directly in msm_dsi_manager_connector_init() Date: Thu, 17 Mar 2022 17:07:31 -0700 Message-Id: <20220318000731.2823718-1-swboyd@chromium.org> X-Mailer: git-send-email 2.35.1.894.gb6a874cedc-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The member 'msm_dsi->connector' isn't assigned until msm_dsi_manager_connector_init() returns (see msm_dsi_modeset_init() and how it assigns the return value). Therefore this pointer is going to be NULL here. Let's use 'connector' which is what was intended. Cc: Dmitry Baryshkov Cc: Sean Paul Fixes: 6d5e78406991 ("drm/msm/dsi: Move dsi panel init into modeset init path") Signed-off-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- I don't know if this is superseeded by something else but I found this while trying to use the connector from msm_dsi in this function. drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 05afd57f4d34602a652fdaf58e0a2756b3c20fd4 diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c index 0c1b7dde377c..9f6af0f0fe00 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c @@ -638,7 +638,7 @@ struct drm_connector *msm_dsi_manager_connector_init(u8 id) return connector; fail: - connector->funcs->destroy(msm_dsi->connector); + connector->funcs->destroy(connector); return ERR_PTR(ret); }