diff mbox series

[v4,06/10] docs: sysfs: coresight: Add sysfs ABI documentation for TPDM

Message ID 20220324121734.21531-7-quic_jinlmao@quicinc.com (mailing list archive)
State Superseded
Headers show
Series Coresight: Add support for TPDM and TPDA | expand

Commit Message

Mao Jinlong March 24, 2022, 12:17 p.m. UTC
Add API usage document for sysfs API in TPDM driver.

Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
---
 Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm

Comments

Greg Kroah-Hartman March 24, 2022, 12:26 p.m. UTC | #1
On Thu, Mar 24, 2022 at 08:17:30PM +0800, Mao Jinlong wrote:
> Add API usage document for sysfs API in TPDM driver.
> 
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> ---
>  Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm | 5 +++++
>  1 file changed, 5 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
> new file mode 100644
> index 000000000000..1df2f9b9ade2
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
> @@ -0,0 +1,5 @@
> +What:		/sys/bus/coresight/devices/<tpdm-name>/integration_test
> +Date:		February 2022

It is no longer February.

> +KernelVersion	5.17

5.17 is long past.

> +Contact:	Jinlong Mao or Tao Zhang

How do we contact these names?

> +Description:	(Write) Run integration test for tpdm.

I do not understand this description at all.  Please explain it much
better.

thanks,

greg k-h
Mao Jinlong March 24, 2022, 2:24 p.m. UTC | #2
On 3/24/2022 8:26 PM, Greg Kroah-Hartman wrote:
> On Thu, Mar 24, 2022 at 08:17:30PM +0800, Mao Jinlong wrote:
>> Add API usage document for sysfs API in TPDM driver.
>>
>> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
>> ---
>>   Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm | 5 +++++
>>   1 file changed, 5 insertions(+)
>>   create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
>>
>> diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
>> new file mode 100644
>> index 000000000000..1df2f9b9ade2
>> --- /dev/null
>> +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
>> @@ -0,0 +1,5 @@
>> +What:		/sys/bus/coresight/devices/<tpdm-name>/integration_test
>> +Date:		February 2022
> It is no longer February.
>
>> +KernelVersion	5.17
> 5.17 is long past.
>
>> +Contact:	Jinlong Mao or Tao Zhang
> How do we contact these names?
>
>> +Description:	(Write) Run integration test for tpdm.
> I do not understand this description at all.  Please explain it much
> better.
>
> thanks,
>
> greg k-h

Thanks for the review. I will address your comments in next version.

Thanks
Jinlong Mao
diff mbox series

Patch

diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
new file mode 100644
index 000000000000..1df2f9b9ade2
--- /dev/null
+++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
@@ -0,0 +1,5 @@ 
+What:		/sys/bus/coresight/devices/<tpdm-name>/integration_test
+Date:		February 2022
+KernelVersion	5.17
+Contact:	Jinlong Mao or Tao Zhang
+Description:	(Write) Run integration test for tpdm.