| Message ID | 20220325211640.54228-1-swboyd@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 516ca27b6033a07d7654e7838520f2c00b1ec606 |
| Headers | show |
| Series | arm64: dts: qcom: sc7180-trogdor: Simply SAR sensor enabling | expand |
Hi, On Fri, Mar 25, 2022 at 2:16 PM Stephen Boyd <swboyd@chromium.org> wrote: > > The SAR node, ap_sar_sensor, needs to be enabled in addition to the i2c > bus it resides on. Let's simplify this by leaving the sensor node > enabled by default while leaving the i2c bus disabled by default. On > boards that use the sensor, we already enable the i2c bus so we can > simply remove the extra bit that enables the sar sensor node. This saves > some lines but is otherwise a non-functional change. > > Cc: Douglas Anderson <dianders@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dts | 4 ---- > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts | 4 ---- > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts | 4 ---- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 - > 4 files changed, 13 deletions(-) Makes sense to me and even saves a byte or two. Reviewed-by: Douglas Anderson <dianders@chromium.org> -Doug
Hello: This patch was applied to qcom/linux.git (for-next) by Bjorn Andersson <bjorn.andersson@linaro.org>: On Fri, 25 Mar 2022 14:16:40 -0700 you wrote: > The SAR node, ap_sar_sensor, needs to be enabled in addition to the i2c > bus it resides on. Let's simplify this by leaving the sensor node > enabled by default while leaving the i2c bus disabled by default. On > boards that use the sensor, we already enable the i2c bus so we can > simply remove the extra bit that enables the sar sensor node. This saves > some lines but is otherwise a non-functional change. > > [...] Here is the summary with links: - arm64: dts: qcom: sc7180-trogdor: Simply SAR sensor enabling https://git.kernel.org/qcom/c/516ca27b6033 You are awesome, thank you!
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dts index e16ba7b01f25..eb20157f6af9 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dts @@ -13,10 +13,6 @@ / { compatible = "google,lazor-rev1-sku0", "google,lazor-rev2-sku0", "qcom,sc7180"; }; -&ap_sar_sensor { - status = "okay"; -}; - &ap_sar_sensor_i2c { status = "okay"; }; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts index c5c9feff41b8..8913592b2d82 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts @@ -20,10 +20,6 @@ / { "qcom,sc7180"; }; -&ap_sar_sensor { - status = "okay"; -}; - &ap_sar_sensor_i2c { status = "okay"; }; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts index 344b57c035d0..8107f3d932eb 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts @@ -17,10 +17,6 @@ / { compatible = "google,lazor-sku0", "qcom,sc7180"; }; -&ap_sar_sensor { - status = "okay"; -}; - &ap_sar_sensor_i2c { status = "okay"; }; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index 732e1181af48..b0efb354458c 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -722,7 +722,6 @@ ap_sar_sensor: proximity@28 { vdd-supply = <&pp3300_a>; svdd-supply = <&pp1800_prox>; - status = "disabled"; label = "proximity-wifi"; }; };
The SAR node, ap_sar_sensor, needs to be enabled in addition to the i2c bus it resides on. Let's simplify this by leaving the sensor node enabled by default while leaving the i2c bus disabled by default. On boards that use the sensor, we already enable the i2c bus so we can simply remove the extra bit that enables the sar sensor node. This saves some lines but is otherwise a non-functional change. Cc: Douglas Anderson <dianders@chromium.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dts | 4 ---- arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts | 4 ---- arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts | 4 ---- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 - 4 files changed, 13 deletions(-) base-commit: 52deda9551a01879b3562e7b41748e85c591f14c