| Message ID | 20220328143035.519909-2-vkoul@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: Get rid of some warnings | expand |
On 28/03/2022 16:30, Vinod Koul wrote: > clk-virt and mc-virt interconnect nodes were named interconnect@0 and > interconnect@1. That is incorrect as we don't have unit addresses 0/1 > for these node. > > This causes warning: > arch/arm64/boot/dts/qcom/sm8450.dtsi:255.27-259.4: > Warning (unit_address_vs_reg): /interconnect@0: > node has a unit name, but no reg or ranges property > arch/arm64/boot/dts/qcom/sm8450.dtsi:261.26-265.4: > Warning (unit_address_vs_reg): /interconnect@1: > node has a unit name, but no reg or ranges property > arch/arm64/boot/dts/qcom/sm8450.dtsi:255.27-259.4: > Warning (unique_unit_address_if_enabled): /interconnect@0: > duplicate unit-address (also used in node /soc@0) > > Rename the nodes to interconnect-0 and interconnect-1 to fix the > warning. > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > Suggested-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) The DT schema will still need to be fixed because it expects 'reg' address. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 28-03-22, 17:07, Krzysztof Kozlowski wrote: > On 28/03/2022 16:30, Vinod Koul wrote: > > clk-virt and mc-virt interconnect nodes were named interconnect@0 and > > interconnect@1. That is incorrect as we don't have unit addresses 0/1 > > for these node. > > > > This causes warning: > > arch/arm64/boot/dts/qcom/sm8450.dtsi:255.27-259.4: > > Warning (unit_address_vs_reg): /interconnect@0: > > node has a unit name, but no reg or ranges property > > arch/arm64/boot/dts/qcom/sm8450.dtsi:261.26-265.4: > > Warning (unit_address_vs_reg): /interconnect@1: > > node has a unit name, but no reg or ranges property > > arch/arm64/boot/dts/qcom/sm8450.dtsi:255.27-259.4: > > Warning (unique_unit_address_if_enabled): /interconnect@0: > > duplicate unit-address (also used in node /soc@0) > > > > Rename the nodes to interconnect-0 and interconnect-1 to fix the > > warning. > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > Suggested-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > The DT schema will still need to be fixed because it expects 'reg' address. Yes will update that as well.. > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thanks
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index 934e29b9e153..b0128d115e7a 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -252,13 +252,13 @@ scm: scm { }; }; - clk_virt: interconnect@0 { + clk_virt: interconnect-0 { compatible = "qcom,sm8450-clk-virt"; #interconnect-cells = <2>; qcom,bcm-voters = <&apps_bcm_voter>; }; - mc_virt: interconnect@1 { + mc_virt: interconnect-1 { compatible = "qcom,sm8450-mc-virt"; #interconnect-cells = <2>; qcom,bcm-voters = <&apps_bcm_voter>;
clk-virt and mc-virt interconnect nodes were named interconnect@0 and interconnect@1. That is incorrect as we don't have unit addresses 0/1 for these node. This causes warning: arch/arm64/boot/dts/qcom/sm8450.dtsi:255.27-259.4: Warning (unit_address_vs_reg): /interconnect@0: node has a unit name, but no reg or ranges property arch/arm64/boot/dts/qcom/sm8450.dtsi:261.26-265.4: Warning (unit_address_vs_reg): /interconnect@1: node has a unit name, but no reg or ranges property arch/arm64/boot/dts/qcom/sm8450.dtsi:255.27-259.4: Warning (unique_unit_address_if_enabled): /interconnect@0: duplicate unit-address (also used in node /soc@0) Rename the nodes to interconnect-0 and interconnect-1 to fix the warning. Signed-off-by: Vinod Koul <vkoul@kernel.org> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org> --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)