| Message ID | 20220402051206.6115-5-singh.kuldeep87k@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/5] dt-bindings: i2c: Add Qualcomm Geni based QUP i2c bindings | expand |
On 02/04/2022 07:12, Kuldeep Singh wrote: > We now have geni based QUP uart controller binding in place as s/uart/UART/ Similar to your previous commit - this could be one, max two sentences... > dt-bindings/serial/qcom,serial-geni-qcom.yaml similar to other > controllers, update reference in parent schema and while at it, also > remove properties defined for the controller from commown wrapper. s/commown/common/ > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > --- > .../bindings/soc/qcom/qcom,geni-se.yaml | 18 +----------------- > 1 file changed, 1 insertion(+), 17 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Sat, Apr 02, 2022 at 05:39:18PM +0200, Krzysztof Kozlowski wrote: > On 02/04/2022 07:12, Kuldeep Singh wrote: > > We now have geni based QUP uart controller binding in place as > > s/uart/UART/ > > Similar to your previous commit - this could be one, max two sentences... > > > dt-bindings/serial/qcom,serial-geni-qcom.yaml similar to other > > controllers, update reference in parent schema and while at it, also > > remove properties defined for the controller from commown wrapper. > > s/commown/common/ > > > > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > > --- > > .../bindings/soc/qcom/qcom,geni-se.yaml | 18 +----------------- > > 1 file changed, 1 insertion(+), 17 deletions(-) > > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thanks, will update. -Kuldeep
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml index e6073923e03a..9f72c676b22c 100644 --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml @@ -133,23 +133,7 @@ patternProperties: "serial@[0-9a-f]+$": type: object description: GENI Serial Engine based UART Controller. - $ref: /schemas/serial.yaml# - - properties: - compatible: - enum: - - qcom,geni-uart - - qcom,geni-debug-uart - - interrupts: - minItems: 1 - items: - - description: UART core irq - - description: Wakeup irq (RX GPIO) - - required: - - compatible - - interrupts + $ref: /schemas/serial/qcom,serial-geni-qcom.yaml# additionalProperties: false
We now have geni based QUP uart controller binding in place as dt-bindings/serial/qcom,serial-geni-qcom.yaml similar to other controllers, update reference in parent schema and while at it, also remove properties defined for the controller from commown wrapper. Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> --- .../bindings/soc/qcom/qcom,geni-se.yaml | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-)