| Message ID | 20220415005828.1980055-3-swboyd@chromium.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | interconnect: qcom: Remove IP0 resource | expand |
On 4/14/22 7:58 PM, Stephen Boyd wrote: > These interconnects are modeled as clks, not interconnects, therefore > remove the compatibles from the binding as they're unused. > > Cc: Alex Elder <elder@linaro.org> > Cc: Taniya Das <quic_tdas@quicinc.com> > Cc: Mike Tipton <quic_mdtipton@quicinc.com> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> What's the proper thing to do for properties that stop being used? Do we delete them, like this, or deprecate them somehow? Old DTBs might define the values that are deleted here. Shouldn't devicetree@vger.kernel.org be copied on this and the other DTS patches? -Alex > --- > > I don't know who should apply this. Probably whoever takes the dtsi > patches, Bjorn?, because otherwise dt_bindings_check will fail. > > Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > index 5a911be0c2ea..ab859150c7f7 100644 > --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > @@ -31,7 +31,6 @@ properties: > - qcom,sc7180-config-noc > - qcom,sc7180-dc-noc > - qcom,sc7180-gem-noc > - - qcom,sc7180-ipa-virt > - qcom,sc7180-mc-virt > - qcom,sc7180-mmss-noc > - qcom,sc7180-npu-noc > @@ -68,7 +67,6 @@ properties: > - qcom,sdm845-mem-noc > - qcom,sdm845-mmss-noc > - qcom,sdm845-system-noc > - - qcom,sdx55-ipa-virt > - qcom,sdx55-mc-virt > - qcom,sdx55-mem-noc > - qcom,sdx55-system-noc
Quoting Alex Elder (2022-04-15 13:15:21) > On 4/14/22 7:58 PM, Stephen Boyd wrote: > > These interconnects are modeled as clks, not interconnects, therefore > > remove the compatibles from the binding as they're unused. > > > > Cc: Alex Elder <elder@linaro.org> > > Cc: Taniya Das <quic_tdas@quicinc.com> > > Cc: Mike Tipton <quic_mdtipton@quicinc.com> > > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > > What's the proper thing to do for properties that stop being > used? Do we delete them, like this, or deprecate them somehow? > Old DTBs might define the values that are deleted here. I think we leave them around until the last dts user stops using them. > > Shouldn't devicetree@vger.kernel.org > be copied on this and > the other DTS patches? Sure. I added it now. Thanks. > > > --- > > > > I don't know who should apply this. Probably whoever takes the dtsi > > patches, Bjorn?, because otherwise dt_bindings_check will fail. > > > > Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > > index 5a911be0c2ea..ab859150c7f7 100644 > > --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > > +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > > @@ -31,7 +31,6 @@ properties: > > - qcom,sc7180-config-noc > > - qcom,sc7180-dc-noc > > - qcom,sc7180-gem-noc > > - - qcom,sc7180-ipa-virt > > - qcom,sc7180-mc-virt > > - qcom,sc7180-mmss-noc > > - qcom,sc7180-npu-noc > > @@ -68,7 +67,6 @@ properties: > > - qcom,sdm845-mem-noc > > - qcom,sdm845-mmss-noc > > - qcom,sdm845-system-noc > > - - qcom,sdx55-ipa-virt > > - qcom,sdx55-mc-virt > > - qcom,sdx55-mem-noc > > - qcom,sdx55-system-noc >
On 4/14/22 7:58 PM, Stephen Boyd wrote: > These interconnects are modeled as clks, not interconnects, therefore > remove the compatibles from the binding as they're unused. > > Cc: Alex Elder <elder@linaro.org> > Cc: Taniya Das <quic_tdas@quicinc.com> > Cc: Mike Tipton <quic_mdtipton@quicinc.com> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > > I don't know who should apply this. Probably whoever takes the dtsi > patches, Bjorn?, because otherwise dt_bindings_check will fail. I don't see this commit applied anywhere, though I might have missed it. Is this for Bjorn, or Georgi, or someone else? -Alex > Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > index 5a911be0c2ea..ab859150c7f7 100644 > --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > @@ -31,7 +31,6 @@ properties: > - qcom,sc7180-config-noc > - qcom,sc7180-dc-noc > - qcom,sc7180-gem-noc > - - qcom,sc7180-ipa-virt > - qcom,sc7180-mc-virt > - qcom,sc7180-mmss-noc > - qcom,sc7180-npu-noc > @@ -68,7 +67,6 @@ properties: > - qcom,sdm845-mem-noc > - qcom,sdm845-mmss-noc > - qcom,sdm845-system-noc > - - qcom,sdx55-ipa-virt > - qcom,sdx55-mc-virt > - qcom,sdx55-mem-noc > - qcom,sdx55-system-noc
On 17.05.22 1:16, Alex Elder wrote: > On 4/14/22 7:58 PM, Stephen Boyd wrote: >> These interconnects are modeled as clks, not interconnects, therefore >> remove the compatibles from the binding as they're unused. >> >> Cc: Alex Elder <elder@linaro.org> >> Cc: Taniya Das <quic_tdas@quicinc.com> >> Cc: Mike Tipton <quic_mdtipton@quicinc.com> >> Signed-off-by: Stephen Boyd <swboyd@chromium.org> >> --- >> >> I don't know who should apply this. Probably whoever takes the dtsi >> patches, Bjorn?, because otherwise dt_bindings_check will fail. > > I don't see this commit applied anywhere, though I > might have missed it. Is this for Bjorn, or Georgi, > or someone else? I merged it as Bjorn has already sent his pull request. Thanks, Georgi > > -Alex > >> Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml >> b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml >> index 5a911be0c2ea..ab859150c7f7 100644 >> --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml >> +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml >> @@ -31,7 +31,6 @@ properties: >> - qcom,sc7180-config-noc >> - qcom,sc7180-dc-noc >> - qcom,sc7180-gem-noc >> - - qcom,sc7180-ipa-virt >> - qcom,sc7180-mc-virt >> - qcom,sc7180-mmss-noc >> - qcom,sc7180-npu-noc >> @@ -68,7 +67,6 @@ properties: >> - qcom,sdm845-mem-noc >> - qcom,sdm845-mmss-noc >> - qcom,sdm845-system-noc >> - - qcom,sdx55-ipa-virt >> - qcom,sdx55-mc-virt >> - qcom,sdx55-mem-noc >> - qcom,sdx55-system-noc >
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml index 5a911be0c2ea..ab859150c7f7 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml @@ -31,7 +31,6 @@ properties: - qcom,sc7180-config-noc - qcom,sc7180-dc-noc - qcom,sc7180-gem-noc - - qcom,sc7180-ipa-virt - qcom,sc7180-mc-virt - qcom,sc7180-mmss-noc - qcom,sc7180-npu-noc @@ -68,7 +67,6 @@ properties: - qcom,sdm845-mem-noc - qcom,sdm845-mmss-noc - qcom,sdm845-system-noc - - qcom,sdx55-ipa-virt - qcom,sdx55-mc-virt - qcom,sdx55-mem-noc - qcom,sdx55-system-noc
These interconnects are modeled as clks, not interconnects, therefore remove the compatibles from the binding as they're unused. Cc: Alex Elder <elder@linaro.org> Cc: Taniya Das <quic_tdas@quicinc.com> Cc: Mike Tipton <quic_mdtipton@quicinc.com> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- I don't know who should apply this. Probably whoever takes the dtsi patches, Bjorn?, because otherwise dt_bindings_check will fail. Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml | 2 -- 1 file changed, 2 deletions(-)