diff mbox series

[v3,3/6] arm64: dts: qcom: msm8996: User generic node name for DMA

Message ID 20220417210436.6203-4-singh.kuldeep87k@gmail.com (mailing list archive)
State Queued
Headers show
Series [v3,1/6] ARM: dts: qcom: apq8064: User generic node name for DMA | expand

Commit Message

Kuldeep Singh April 17, 2022, 9:04 p.m. UTC 
Qcom BAM DT spec expects generic DMA controller node name as
"dma-controller" to enable validations.

Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
v3: Add Krzysztof R-b tag
---
v2: No change
---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bhupesh Sharma April 18, 2022, 5:32 a.m. UTC | #1 
Hi Kuldeep,

On Mon, 18 Apr 2022 at 02:34, Kuldeep Singh <singh.kuldeep87k@gmail.com> wrote:
>
> Qcom BAM DT spec expects generic DMA controller node name as
> "dma-controller" to enable validations.

This is already fixed with in-flight patch
<https://lore.kernel.org/lkml/20220211214941.f55q5yksittut3ep@amazon.com/T/#mb84230b9b8e06544859ccf5e16a7651fac79c933>

Thanks,
Bhupesh

> Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> v3: Add Krzysztof R-b tag
> ---
> v2: No change
> ---
>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index b9a48cfd760f..c4cfab92a44e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -707,7 +707,7 @@ tsens1: thermal-sensor@4ad000 {
>                         #thermal-sensor-cells = <1>;
>                 };
>
> -               cryptobam: dma@644000 {
> +               cryptobam: dma-controller@644000 {
>                         compatible = "qcom,bam-v1.7.0";
>                         reg = <0x00644000 0x24000>;
>                         interrupts = <GIC_SPI 206 IRQ_TYPE_LEVEL_HIGH>;
> --
> 2.25.1
>
Kuldeep Singh April 18, 2022, 7:27 p.m. UTC | #2 
On Mon, Apr 18, 2022 at 11:02:11AM +0530, Bhupesh Sharma wrote:
> This is already fixed with in-flight patch
> <https://lore.kernel.org/lkml/20220211214941.f55q5yksittut3ep@amazon.com/T/#mb84230b9b8e06544859ccf5e16a7651fac79c933>

Your change is currently not accepted/merged and don't think it's in
maintainer's queue as well. So, probably it's not in-flight patch as of
now.
Kuldeep Singh April 19, 2022, 7:52 a.m. UTC | #3 
On Tue, Apr 19, 2022 at 02:37:19AM +0530, Bhupesh Sharma wrote:
> My patch already has an ACK from the DMA maintainer, whereas your's is
> still in review.

Sincere apologies, I saw your original patch only and missed Ack.
Please note, mine change is reviewed by FDT maintainer.

> So please drop this patch from the next version.

If we are going to have mine binding version, then skipping dts change
here will trigger Rob's bot warning.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index b9a48cfd760f..c4cfab92a44e 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -707,7 +707,7 @@  tsens1: thermal-sensor@4ad000 {
 			#thermal-sensor-cells = <1>;
 		};
 
-		cryptobam: dma@644000 {
+		cryptobam: dma-controller@644000 {
 			compatible = "qcom,bam-v1.7.0";
 			reg = <0x00644000 0x24000>;
 			interrupts = <GIC_SPI 206 IRQ_TYPE_LEVEL_HIGH>;