| Message ID | 20220421073438.1824061-1-vkoul@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v3] arm64: dts: qcom: db845c: Add support for MCP2517FD | expand |
On 21/04/2022 09:34, Vinod Koul wrote: > Add support for onboard MCP2517FD SPI CAN transceiver attached to > SPI0 of RB3. > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > Change in v3: > - change underscore(_) to dash (-) in can-clock node name > - remove superfluous status = okay in can node FWIW: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, Apr 21, 2022 at 01:04:38PM +0530, Vinod Koul wrote: > Add support for onboard MCP2517FD SPI CAN transceiver attached to > SPI0 of RB3. > > Signed-off-by: Vinod Koul <vkoul@kernel.org> One comment below but irrespective of that, Reviewed-by: Manivannan Sadhasivam <mani@kernel.org> Thanks, Mani > --- > Change in v3: > - change underscore(_) to dash (-) in can-clock node name > - remove superfluous status = okay in can node > > Changes in v2: > - add cs and pinctrl config > - remove misleading comment > > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 32 ++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index 28fe45c5d516..d2ade684703d 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -28,6 +28,13 @@ chosen { > stdout-path = "serial0:115200n8"; > }; > > + /* Fixed crystal oscillator dedicated to MCP2517FD */ > + clk40M: can-clock { clock@? > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <40000000>; > + }; > + > dc12v: dc12v-regulator { > compatible = "regulator-fixed"; > regulator-name = "DC12V"; > @@ -746,6 +753,23 @@ codec { > }; > }; > > +&spi0 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&qup_spi0_default>; > + cs-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>; > + > + can@0 { > + compatible = "microchip,mcp2517fd"; > + reg = <0>; > + clocks = <&clk40M>; > + interrupts-extended = <&tlmm 104 IRQ_TYPE_LEVEL_LOW>; > + spi-max-frequency = <10000000>; > + vdd-supply = <&vdc_5v>; > + xceiver-supply = <&vdc_5v>; > + }; > +}; > + > &spi2 { > /* On Low speed expansion */ > label = "LS-SPI0"; > @@ -1219,3 +1243,11 @@ ov7251_ep: endpoint { > }; > }; > }; > + > +/* PINCTRL - additions to nodes defined in sdm845.dtsi */ > +&qup_spi0_default { > + config { > + drive-strength = <6>; > + bias-disable; > + }; > +}; > -- > 2.34.1 >
On Thu, 21 Apr 2022 13:04:38 +0530, Vinod Koul wrote: > Add support for onboard MCP2517FD SPI CAN transceiver attached to > SPI0 of RB3. > > Applied, thanks! [1/1] arm64: dts: qcom: db845c: Add support for MCP2517FD commit: cb29e7106d4ee7bc3860fc65d28b6d7d0b71c0f8 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts index 28fe45c5d516..d2ade684703d 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts @@ -28,6 +28,13 @@ chosen { stdout-path = "serial0:115200n8"; }; + /* Fixed crystal oscillator dedicated to MCP2517FD */ + clk40M: can-clock { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <40000000>; + }; + dc12v: dc12v-regulator { compatible = "regulator-fixed"; regulator-name = "DC12V"; @@ -746,6 +753,23 @@ codec { }; }; +&spi0 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&qup_spi0_default>; + cs-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>; + + can@0 { + compatible = "microchip,mcp2517fd"; + reg = <0>; + clocks = <&clk40M>; + interrupts-extended = <&tlmm 104 IRQ_TYPE_LEVEL_LOW>; + spi-max-frequency = <10000000>; + vdd-supply = <&vdc_5v>; + xceiver-supply = <&vdc_5v>; + }; +}; + &spi2 { /* On Low speed expansion */ label = "LS-SPI0"; @@ -1219,3 +1243,11 @@ ov7251_ep: endpoint { }; }; }; + +/* PINCTRL - additions to nodes defined in sdm845.dtsi */ +&qup_spi0_default { + config { + drive-strength = <6>; + bias-disable; + }; +};
Add support for onboard MCP2517FD SPI CAN transceiver attached to SPI0 of RB3. Signed-off-by: Vinod Koul <vkoul@kernel.org> --- Change in v3: - change underscore(_) to dash (-) in can-clock node name - remove superfluous status = okay in can node Changes in v2: - add cs and pinctrl config - remove misleading comment arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 32 ++++++++++++++++++++++ 1 file changed, 32 insertions(+)