| Message ID | 20220424131522.14185-2-david@ixit.cz (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2,1/3] dt-bindings: net: qcom,ipa: fix example for upcomming smp2p conversion | expand |
On 24/04/2022 15:15, David Heidelberg wrote: > These missing required properties are needed for > smp2p binding reference checks. > > Misc: adjusted examples properties formatting from dtsi. I don't get the "misc:" comment. What is it about? Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 24/04/2022 16:43, Krzysztof Kozlowski wrote: > On 24/04/2022 15:15, David Heidelberg wrote: >> These missing required properties are needed for >> smp2p binding reference checks. >> >> Misc: adjusted examples properties formatting from dtsi. > I don't get the "misc:" comment. What is it about? I used same formatting as in dtsi where the node is used (cosmetic change). > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thanks > > Best regards, > Krzysztof
On Sun, 24 Apr 2022 15:15:20 +0200, David Heidelberg wrote: > These missing required properties are needed for > smp2p binding reference checks. > > Misc: adjusted examples properties formatting from dtsi. > > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > .../devicetree/bindings/mailbox/qcom-ipcc.yaml | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ mailbox@ed18000: compatible:0: 'qcom,sm8450-ipcc' is not one of ['qcom,sm6350-ipcc', 'qcom,sm8250-ipcc', 'qcom,sm8350-ipcc', 'qcom,sc7280-ipcc'] arch/arm64/boot/dts/qcom/sm8450-hdk.dtb arch/arm64/boot/dts/qcom/sm8450-qrd.dtb
diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml index 866efb278813..d573d555f4c6 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml @@ -75,9 +75,14 @@ examples: smp2p-modem { compatible = "qcom,smp2p"; - interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS - IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>; - mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>; + qcom,smem = <443>, <429>; + interrupts-extended = <&ipcc IPCC_CLIENT_LPASS + IPCC_MPROC_SIGNAL_SMP2P + IRQ_TYPE_EDGE_RISING>; + mboxes = <&ipcc IPCC_CLIENT_LPASS + IPCC_MPROC_SIGNAL_SMP2P>; + qcom,local-pid = <0>; + qcom,remote-pid = <2>; /* Other SMP2P fields */ };
These missing required properties are needed for smp2p binding reference checks. Misc: adjusted examples properties formatting from dtsi. Signed-off-by: David Heidelberg <david@ixit.cz> --- .../devicetree/bindings/mailbox/qcom-ipcc.yaml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)