| Message ID | 20220601061915.10946-1-slark_xiao@163.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | bus: mhi: host: Add support for Cinterion MV31-W with new device ID | expand |
On Wed, Jun 01, 2022 at 02:19:15PM +0800, Slark Xiao wrote: Please use pci_generic in the subject as this change belongs to that driver: bus: mhi: host: pci_generic: Add Cinterion MV31-W with new baseline > As Thales would use a new baseline, so we need to add > a new device ID to separate it from previous. > Thales refers to Cinterion MV31-W, right? Better just use Cinterion MV31-W. Like, Cinterion MV31-W modem with a new baseline (firmware) is sold as a separate product with different device ID. So add support for the same reusing the config. Thanks, Mani > Signed-off-by: Slark Xiao <slark_xiao@163.com> > --- > drivers/bus/mhi/host/pci_generic.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c > index 6fbc5915ea36..a2a4fd2cd13d 100644 > --- a/drivers/bus/mhi/host/pci_generic.c > +++ b/drivers/bus/mhi/host/pci_generic.c > @@ -578,6 +578,9 @@ static const struct pci_device_id mhi_pci_id_table[] = { > /* MV31-W (Cinterion) */ > { PCI_DEVICE(0x1269, 0x00b3), > .driver_data = (kernel_ulong_t) &mhi_mv31_info }, > + /* MV31-W (Cinterion), based on new baseline */ > + { PCI_DEVICE(0x1269, 0x00b4), > + .driver_data = (kernel_ulong_t) &mhi_mv31_info }, > /* MV32-WA (Cinterion) */ > { PCI_DEVICE(0x1269, 0x00ba), > .driver_data = (kernel_ulong_t) &mhi_mv32_info }, > -- > 2.25.1 >
At 2022-06-21 21:17:51, "Manivannan Sadhasivam" <mani@kernel.org> wrote:>On Wed, Jun 01, 2022 at 02:19:15PM +0800, Slark Xiao wrote:> >Please use pci_generic in the subject as this change belongs to that driver: > >bus: mhi: host: pci_generic: Add Cinterion MV31-W with new baseline > >> As Thales would use a new baseline, so we need to add >> a new device ID to separate it from previous. >> > >Thales refers to Cinterion MV31-W, right? Better just use Cinterion MV31-W. Hi, actually Cinterion belongs to Thales Group. Anyway, I will use CInterion for this product. >Like, > >Cinterion MV31-W modem with a new baseline (firmware) is sold as a separate >product with different device ID. So add support for the same reusing the >config. > I will apply it in V2. Thanks. >Thanks, >Mani > >> Signed-off-by: Slark Xiao <slark_xiao@163.com> >> --- >> drivers/bus/mhi/host/pci_generic.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c >> index 6fbc5915ea36..a2a4fd2cd13d 100644 >> --- a/drivers/bus/mhi/host/pci_generic.c >> +++ b/drivers/bus/mhi/host/pci_generic.c >> @@ -578,6 +578,9 @@ static const struct pci_device_id mhi_pci_id_table[] = { >> /* MV31-W (Cinterion) */ >> { PCI_DEVICE(0x1269, 0x00b3), >> .driver_data = (kernel_ulong_t) &mhi_mv31_info }, >> + /* MV31-W (Cinterion), based on new baseline */ >> + { PCI_DEVICE(0x1269, 0x00b4), >> + .driver_data = (kernel_ulong_t) &mhi_mv31_info }, >> /* MV32-WA (Cinterion) */ >> { PCI_DEVICE(0x1269, 0x00ba), >> .driver_data = (kernel_ulong_t) &mhi_mv32_info }, >> -- >> 2.25.1 >> > >-- >மணிவண்ணன் சதாசிவம்
diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c index 6fbc5915ea36..a2a4fd2cd13d 100644 --- a/drivers/bus/mhi/host/pci_generic.c +++ b/drivers/bus/mhi/host/pci_generic.c @@ -578,6 +578,9 @@ static const struct pci_device_id mhi_pci_id_table[] = { /* MV31-W (Cinterion) */ { PCI_DEVICE(0x1269, 0x00b3), .driver_data = (kernel_ulong_t) &mhi_mv31_info }, + /* MV31-W (Cinterion), based on new baseline */ + { PCI_DEVICE(0x1269, 0x00b4), + .driver_data = (kernel_ulong_t) &mhi_mv31_info }, /* MV32-WA (Cinterion) */ { PCI_DEVICE(0x1269, 0x00ba), .driver_data = (kernel_ulong_t) &mhi_mv32_info },
As Thales would use a new baseline, so we need to add a new device ID to separate it from previous. Signed-off-by: Slark Xiao <slark_xiao@163.com> --- drivers/bus/mhi/host/pci_generic.c | 3 +++ 1 file changed, 3 insertions(+)