| Message ID | 20220608154705.40322-4-quic_jinlmao@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Coresight: Add support for TPDM and TPDA | expand |
On Wed, 08 Jun 2022 23:46:58 +0800, Mao Jinlong wrote: > Adds new coresight-tpdm.yaml file describing the bindings required > to define tpdm in the device trees. > > Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com> > Reviewed-by: Mike Leach <mike.leach@linaro.org> > Signed-off-by: Tao Zhang <quic_taozha@quicinc.com> > Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> > --- > .../bindings/arm/coresight-tpdm.yaml | 99 +++++++++++++++++++ > .../devicetree/bindings/arm/coresight.txt | 7 ++ > MAINTAINERS | 1 + > 3 files changed, 107 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/coresight-tpdm.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dtb: memory-controller@e000e000: $nodename:0: 'memory-controller@e000e000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dtb: memory-controller@e000e000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dtb: memory-controller@e000e000: clocks: [[4294967295, 11], [4294967295, 44]] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dtb: memory-controller@e000e000: clock-names:0: 'apb_pclk' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dtb: memory-controller@e000e000: clock-names: ['memclk', 'apb_pclk'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dtb: memory-controller@e000e000: '#address-cells', '#size-cells', 'nand-controller@0,0', 'ranges' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/spi-pl022.example.dtb: spi@e0100000: $nodename:0: 'spi@e0100000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/spi-pl022.example.dtb: spi@e0100000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/spi-pl022.example.dtb: spi@e0100000: 'clocks' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/spi-pl022.example.dtb: spi@e0100000: 'clock-names' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/spi-pl022.example.dtb: spi@e0100000: '#address-cells', '#size-cells', 'dma-names', 'dmas', 'flash@1', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/arm,pl330.example.dtb: dma-controller@12680000: $nodename:0: 'dma-controller@12680000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/arm,pl330.example.dtb: dma-controller@12680000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/arm,pl330.example.dtb: dma-controller@12680000: 'clocks' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/arm,pl330.example.dtb: dma-controller@12680000: 'clock-names' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/arm,pl330.example.dtb: dma-controller@12680000: '#dma-cells', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/arm-pl08x.example.dtb: dma-controller@10130000: $nodename:0: 'dma-controller@10130000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/arm-pl08x.example.dtb: dma-controller@10130000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/arm-pl08x.example.dtb: dma-controller@10130000: '#dma-cells', 'interrupts', 'lli-bus-interface-ahb1', 'lli-bus-interface-ahb2', 'mem-bus-interface-ahb2', 'memcpy-burst-size', 'memcpy-bus-width' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/arm-pl08x.example.dtb: dma-controller@67000000: $nodename:0: 'dma-controller@67000000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/arm-pl08x.example.dtb: dma-controller@67000000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/arm-pl08x.example.dtb: dma-controller@67000000: compatible:1: 'arm,primecell' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/arm-pl08x.example.dtb: dma-controller@67000000: compatible: ['faraday,ftdma020', 'arm,pl080', 'arm,primecell'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/arm-pl08x.example.dtb: dma-controller@67000000: '#dma-cells', 'arm,primecell-periphid', 'interrupts', 'lli-bus-interface-ahb2', 'mem-bus-interface-ahb2', 'memcpy-burst-size', 'memcpy-bus-width', 'resets' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.example.dtb: mmc@80118000: $nodename:0: 'mmc@80118000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.example.dtb: mmc@80118000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.example.dtb: mmc@80118000: clocks: [[4294967295, 0], [4294967295, 1]] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.example.dtb: mmc@80118000: clock-names:0: 'apb_pclk' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.example.dtb: mmc@80118000: clock-names: ['mclk', 'apb_pclk'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.example.dtb: mmc@80118000: '#address-cells', '#size-cells', 'bus-width', 'interrupts', 'non-removable', 'vmmc-supply', 'wifi@1' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@5000: $nodename:0: 'mmc@5000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@5000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@5000: clocks: [[4294967295], [4294967295]] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@5000: clock-names:0: 'apb_pclk' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@5000: clock-names: ['mclk', 'apb_pclk'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@5000: 'interrupts-extended' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@80126000: $nodename:0: 'mmc@80126000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@80126000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@80126000: clocks: [[4294967295, 1, 5], [4294967295, 1, 5]] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@80126000: clock-names:0: 'apb_pclk' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@80126000: clock-names: ['sdi', 'apb_pclk'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@80126000: 'bus-width', 'cap-mmc-highspeed', 'cap-sd-highspeed', 'cd-gpios', 'dma-names', 'dmas', 'interrupts', 'max-frequency', 'st,sig-dir-cmd', 'st,sig-dir-dat0', 'st,sig-dir-dat2', 'st,sig-pin-fbclk', 'vmmc-supply', 'vqmmc-supply' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@101f6000: $nodename:0: 'mmc@101f6000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@101f6000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@101f6000: clocks: [[4294967295], [4294967295]] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@101f6000: clock-names:0: 'apb_pclk' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@101f6000: clock-names: ['mclk', 'apb_pclk'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@101f6000: 'bus-width', 'cap-mmc-highspeed', 'cap-sd-highspeed', 'full-pwr-cycle', 'interrupts', 'max-frequency', 'st,sig-dir-cmd', 'st,sig-dir-dat0', 'st,sig-dir-dat2', 'st,sig-dir-dat31', 'st,sig-pin-fbclk', 'vmmc-supply' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@52007000: $nodename:0: 'mmc@52007000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@52007000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/arm,pl18x.example.dtb: mmc@52007000: 'arm,primecell-periphid', 'cap-mmc-highspeed', 'cap-sd-highspeed', 'interrupts', 'max-frequency', 'resets' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rtc/arm,pl031.example.dtb: rtc@10017000: $nodename:0: 'rtc@10017000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rtc/arm,pl031.example.dtb: rtc@10017000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.example.dtb: memory-controller@e000e000: $nodename:0: 'memory-controller@e000e000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.example.dtb: memory-controller@e000e000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.example.dtb: memory-controller@e000e000: clocks: [[4294967295, 11], [4294967295, 44]] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.example.dtb: memory-controller@e000e000: clock-names:0: 'apb_pclk' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.example.dtb: memory-controller@e000e000: clock-names: ['memclk', 'apb_pclk'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.example.dtb: memory-controller@e000e000: '#address-cells', '#size-cells', 'nand-controller@0,0', 'ranges' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/serial/pl011.example.dtb: serial@80120000: $nodename:0: 'serial@80120000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/serial/pl011.example.dtb: serial@80120000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/serial/pl011.example.dtb: serial@80120000: clocks: [[4294967295], [4294967295]] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/serial/pl011.example.dtb: serial@80120000: clock-names:0: 'apb_pclk' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/serial/pl011.example.dtb: serial@80120000: clock-names: ['uartclk', 'apb_pclk'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/serial/pl011.example.dtb: serial@80120000: 'dma-names', 'dmas', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/arm,integrator-ap-lm.example.dtb: serial@100000: $nodename:0: 'serial@100000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/arm,integrator-ap-lm.example.dtb: serial@100000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/arm,integrator-ap-lm.example.dtb: serial@100000: 'clocks' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/arm,integrator-ap-lm.example.dtb: serial@100000: 'clock-names' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/arm,integrator-ap-lm.example.dtb: serial@100000: 'interrupts-extended' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/arm,pl11x.example.dtb: clcd@10020000: $nodename:0: 'clcd@10020000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/arm,pl11x.example.dtb: clcd@10020000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/arm,pl11x.example.dtb: clcd@10020000: clocks: [[4294967295], [4294967295]] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/arm,pl11x.example.dtb: clcd@10020000: clock-names:0: 'apb_pclk' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/arm,pl11x.example.dtb: clcd@10020000: clock-names: ['clcdclk', 'apb_pclk'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/arm,pl11x.example.dtb: clcd@10020000: 'interrupt-names', 'interrupts', 'max-memory-bandwidth', 'port' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/sp810.example.dtb: sysctl@20000: $nodename:0: 'sysctl@20000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/sp810.example.dtb: sysctl@20000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/sp810.example.dtb: sysctl@20000: clocks: [[4294967295], [4294967295], [4294967295]] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/sp810.example.dtb: sysctl@20000: clock-names:0: 'apb_pclk' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/sp810.example.dtb: sysctl@20000: clock-names: ['refclk', 'timclk', 'apb_pclk'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/sp810.example.dtb: sysctl@20000: '#clock-cells', 'clock-output-names' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-cti.example.dtb: cti@20020000: $nodename:0: 'cti@20020000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-cti.example.dtb: cti@20020000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-cti.example.dtb: cti@859000: $nodename:0: 'cti@859000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-cti.example.dtb: cti@859000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-cti.example.dtb: cti@859000: compatible:1: 'arm,primecell' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-cti.example.dtb: cti@859000: compatible: ['arm,coresight-cti-v8-arch', 'arm,coresight-cti', 'arm,primecell'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-cti.example.dtb: cti@859000: 'arm,cs-dev-assoc', 'cpu' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-cti.example.dtb: cti@858000: $nodename:0: 'cti@858000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-cti.example.dtb: cti@858000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-cti.example.dtb: cti@858000: '#address-cells', '#size-cells', 'arm,cti-ctm-id', 'trig-conns@0', 'trig-conns@1' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-cti.example.dtb: cti@20110000: $nodename:0: 'cti@20110000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-cti.example.dtb: cti@20110000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-cti.example.dtb: cti@20110000: '#address-cells', '#size-cells', 'trig-conns@0', 'trig-conns@1', 'trig-conns@2' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/serio/arm,pl050.example.dtb: serio@70000: $nodename:0: 'serio@70000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/serio/arm,pl050.example.dtb: serio@70000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/serio/arm,pl050.example.dtb: serio@70000: clocks: [[4294967295], [4294967295]] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/serio/arm,pl050.example.dtb: serio@70000: clock-names:0: 'apb_pclk' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/serio/arm,pl050.example.dtb: serio@70000: clock-names: ['KMIREFCLK', 'apb_pclk'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/serio/arm,pl050.example.dtb: serio@70000: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/watchdog/arm,sp805.example.dtb: watchdog@66090000: $nodename:0: 'watchdog@66090000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/watchdog/arm,sp805.example.dtb: watchdog@66090000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/watchdog/arm,sp805.example.dtb: watchdog@66090000: clocks: [[4294967295], [4294967295]] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/watchdog/arm,sp805.example.dtb: watchdog@66090000: clock-names:0: 'apb_pclk' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/watchdog/arm,sp805.example.dtb: watchdog@66090000: clock-names: ['wdog_clk', 'apb_pclk'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/watchdog/arm,sp805.example.dtb: watchdog@66090000: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/arm,pl041.example.dtb: audio-controller@40000: $nodename:0: 'audio-controller@40000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/arm,pl041.example.dtb: audio-controller@40000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/arm,pl041.example.dtb: audio-controller@40000: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhuv2.example.dtb: mailbox@2b1f0000: $nodename:0: 'mailbox@2b1f0000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhuv2.example.dtb: mailbox@2b1f0000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhuv2.example.dtb: mailbox@2b1f0000: '#mbox-cells', 'arm,mhuv2-protocols', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhuv2.example.dtb: mailbox@2b1f1000: $nodename:0: 'mailbox@2b1f1000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhuv2.example.dtb: mailbox@2b1f1000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhuv2.example.dtb: mailbox@2b1f1000: '#mbox-cells', 'arm,mhuv2-protocols', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhu.example.dtb: mailbox@2b1f0000: $nodename:0: 'mailbox@2b1f0000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhu.example.dtb: mailbox@2b1f0000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhu.example.dtb: mailbox@2b1f0000: '#mbox-cells', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhu.example.dtb: mailbox@2b2f0000: $nodename:0: 'mailbox@2b2f0000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhu.example.dtb: mailbox@2b2f0000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhu.example.dtb: mailbox@2b2f0000: '#mbox-cells', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.example.dtb: dma-controller@11420000: $nodename:0: 'dma-controller@11420000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.example.dtb: dma-controller@11420000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.example.dtb: dma-controller@11420000: '#dma-cells', 'dma-channels', 'dma-requests', 'interrupts', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/timer/arm,sp804.example.dtb: timer@fc800000: $nodename:0: 'timer@fc800000' does not match '^tpdm(@[0-9a-f]+)$' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/timer/arm,sp804.example.dtb: timer@fc800000: compatible:0: 'qcom,coresight-tpdm' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/timer/arm,sp804.example.dtb: timer@fc800000: clocks: [[4294967295], [4294967295], [4294967295]] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/timer/arm,sp804.example.dtb: timer@fc800000: clock-names:0: 'apb_pclk' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/timer/arm,sp804.example.dtb: timer@fc800000: clock-names: ['timer1', 'timer2', 'apb_pclk'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/timer/arm,sp804.example.dtb: timer@fc800000: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Wed, Jun 08, 2022 at 11:46:58PM +0800, Mao Jinlong wrote: > Adds new coresight-tpdm.yaml file describing the bindings required > to define tpdm in the device trees. > > Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com> > Reviewed-by: Mike Leach <mike.leach@linaro.org> > Signed-off-by: Tao Zhang <quic_taozha@quicinc.com> > Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> > --- > .../bindings/arm/coresight-tpdm.yaml | 99 +++++++++++++++++++ qcom,coresight-tpdm.yaml > .../devicetree/bindings/arm/coresight.txt | 7 ++ This file is going away[1]. I'd just drop the changes to it. > MAINTAINERS | 1 + > 3 files changed, 107 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/coresight-tpdm.yaml > > diff --git a/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml b/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml > new file mode 100644 > index 000000000000..14bef4ce4274 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml > @@ -0,0 +1,99 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +# Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/coresight-tpdm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Trace, Profiling and Diagnostics Monitor - TPDM > + > +description: | > + The TPDM or Monitor serves as data collection component for various dataset > + types specified in the QPMDA spec. It covers Implementation defined ((ImplDef), > + Basic Counts (BC), Tenure Counts (TC), Continuous Multi-Bit (CMB), and Discrete > + Single Bit (DSB). It performs data collection in the data producing clock > + domain and transfers it to the data collection time domain, generally ATB > + clock domain. > + > + The primary use case of the TPDM is to collect data from different data > + sources and send it to a TPDA for packetization, timestamping, and funneling. > + > +maintainers: > + - Mao Jinlong <quic_jinlmao@quicinc.com> > + - Tao Zhang <quic_taozha@quicinc.com> > + > +properties: > + $nodename: > + pattern: "^tpdm(@[0-9a-f]+)$" blank line > + compatible: > + items: > + - const: qcom,coresight-tpdm > + - const: arm,primecell You need a 'select' to fix the errors reported. See other primecell bindings. > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: apb_pclk > + > + out-ports: > + description: | > + Output connections from the TPDM to coresight funnle/tpda. typo > + $ref: /schemas/graph.yaml#/properties/ports blank line here. > + properties: > + port: > + description: Output connection from the TPDM to coresight > + funnel/tpda. s/tpda/TPDA/ > + $ref: /schemas/graph.yaml#/properties/port > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + # minimum TPDM definition. TPDM connect to coresight funnel. > + - | > + tpdm@6980000 { > + compatible = "qcom,coresight-tpdm", "arm,primecell"; > + reg = <0x6980000 0x1000>; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + out-ports { > + port { > + tpdm_turing_out_funnel_turing: endpoint { > + remote-endpoint = > + <&funnel_turing_in_tpdm_turing>; > + }; > + }; > + }; > + }; > + # minimum TPDM definition. TPDM connect to coresight TPDA. > + - | The only difference in the 2 examples is some external phandle. 1 example is sufficient. > + tpdm@684c000 { > + compatible = "qcom,coresight-tpdm", "arm,primecell"; > + reg = <0x684c000 0x1000>; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + out-ports { > + port { > + tpdm_prng_out_tpda_qdss: endpoint { > + remote-endpoint = > + <&tpda_qdss_in_tpdm_prng>; > + }; > + }; > + }; > + }; > + > +... Rob [1] https://lore.kernel.org/all/20220603011933.3277315-1-robh@kernel.org/
Thank you Rob for the review of the yaml changes. I will check and address all you comments. On 6/9/2022 6:01 AM, Rob Herring wrote: > On Wed, Jun 08, 2022 at 11:46:58PM +0800, Mao Jinlong wrote: >> Adds new coresight-tpdm.yaml file describing the bindings required >> to define tpdm in the device trees. >> >> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com> >> Reviewed-by: Mike Leach <mike.leach@linaro.org> >> Signed-off-by: Tao Zhang <quic_taozha@quicinc.com> >> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> >> --- >> .../bindings/arm/coresight-tpdm.yaml | 99 +++++++++++++++++++ > qcom,coresight-tpdm.yaml > >> .../devicetree/bindings/arm/coresight.txt | 7 ++ > This file is going away[1]. I'd just drop the changes to it. > >> MAINTAINERS | 1 + >> 3 files changed, 107 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/arm/coresight-tpdm.yaml >> >> diff --git a/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml b/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml >> new file mode 100644 >> index 000000000000..14bef4ce4274 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml >> @@ -0,0 +1,99 @@ >> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause >> +# Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/arm/coresight-tpdm.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Trace, Profiling and Diagnostics Monitor - TPDM >> + >> +description: | >> + The TPDM or Monitor serves as data collection component for various dataset >> + types specified in the QPMDA spec. It covers Implementation defined ((ImplDef), >> + Basic Counts (BC), Tenure Counts (TC), Continuous Multi-Bit (CMB), and Discrete >> + Single Bit (DSB). It performs data collection in the data producing clock >> + domain and transfers it to the data collection time domain, generally ATB >> + clock domain. >> + >> + The primary use case of the TPDM is to collect data from different data >> + sources and send it to a TPDA for packetization, timestamping, and funneling. >> + >> +maintainers: >> + - Mao Jinlong <quic_jinlmao@quicinc.com> >> + - Tao Zhang <quic_taozha@quicinc.com> >> + >> +properties: >> + $nodename: >> + pattern: "^tpdm(@[0-9a-f]+)$" > blank line > >> + compatible: >> + items: >> + - const: qcom,coresight-tpdm >> + - const: arm,primecell > You need a 'select' to fix the errors reported. See other primecell > bindings. > >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + clock-names: >> + items: >> + - const: apb_pclk >> + >> + out-ports: >> + description: | >> + Output connections from the TPDM to coresight funnle/tpda. > typo > >> + $ref: /schemas/graph.yaml#/properties/ports > blank line here. > >> + properties: >> + port: >> + description: Output connection from the TPDM to coresight >> + funnel/tpda. > s/tpda/TPDA/ > >> + $ref: /schemas/graph.yaml#/properties/port >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + >> +additionalProperties: false >> + >> +examples: >> + # minimum TPDM definition. TPDM connect to coresight funnel. >> + - | >> + tpdm@6980000 { >> + compatible = "qcom,coresight-tpdm", "arm,primecell"; >> + reg = <0x6980000 0x1000>; >> + >> + clocks = <&aoss_qmp>; >> + clock-names = "apb_pclk"; >> + >> + out-ports { >> + port { >> + tpdm_turing_out_funnel_turing: endpoint { >> + remote-endpoint = >> + <&funnel_turing_in_tpdm_turing>; >> + }; >> + }; >> + }; >> + }; >> + # minimum TPDM definition. TPDM connect to coresight TPDA. >> + - | > The only difference in the 2 examples is some external phandle. 1 > example is sufficient. > >> + tpdm@684c000 { >> + compatible = "qcom,coresight-tpdm", "arm,primecell"; >> + reg = <0x684c000 0x1000>; >> + >> + clocks = <&aoss_qmp>; >> + clock-names = "apb_pclk"; >> + >> + out-ports { >> + port { >> + tpdm_prng_out_tpda_qdss: endpoint { >> + remote-endpoint = >> + <&tpda_qdss_in_tpdm_prng>; >> + }; >> + }; >> + }; >> + }; >> + >> +... > Rob > > [1] https://lore.kernel.org/all/20220603011933.3277315-1-robh@kernel.org/
diff --git a/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml b/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml new file mode 100644 index 000000000000..14bef4ce4274 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml @@ -0,0 +1,99 @@ +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause +# Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/coresight-tpdm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Trace, Profiling and Diagnostics Monitor - TPDM + +description: | + The TPDM or Monitor serves as data collection component for various dataset + types specified in the QPMDA spec. It covers Implementation defined ((ImplDef), + Basic Counts (BC), Tenure Counts (TC), Continuous Multi-Bit (CMB), and Discrete + Single Bit (DSB). It performs data collection in the data producing clock + domain and transfers it to the data collection time domain, generally ATB + clock domain. + + The primary use case of the TPDM is to collect data from different data + sources and send it to a TPDA for packetization, timestamping, and funneling. + +maintainers: + - Mao Jinlong <quic_jinlmao@quicinc.com> + - Tao Zhang <quic_taozha@quicinc.com> + +properties: + $nodename: + pattern: "^tpdm(@[0-9a-f]+)$" + compatible: + items: + - const: qcom,coresight-tpdm + - const: arm,primecell + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + items: + - const: apb_pclk + + out-ports: + description: | + Output connections from the TPDM to coresight funnle/tpda. + $ref: /schemas/graph.yaml#/properties/ports + properties: + port: + description: Output connection from the TPDM to coresight + funnel/tpda. + $ref: /schemas/graph.yaml#/properties/port + +required: + - compatible + - reg + - clocks + - clock-names + +additionalProperties: false + +examples: + # minimum TPDM definition. TPDM connect to coresight funnel. + - | + tpdm@6980000 { + compatible = "qcom,coresight-tpdm", "arm,primecell"; + reg = <0x6980000 0x1000>; + + clocks = <&aoss_qmp>; + clock-names = "apb_pclk"; + + out-ports { + port { + tpdm_turing_out_funnel_turing: endpoint { + remote-endpoint = + <&funnel_turing_in_tpdm_turing>; + }; + }; + }; + }; + # minimum TPDM definition. TPDM connect to coresight TPDA. + - | + tpdm@684c000 { + compatible = "qcom,coresight-tpdm", "arm,primecell"; + reg = <0x684c000 0x1000>; + + clocks = <&aoss_qmp>; + clock-names = "apb_pclk"; + + out-ports { + port { + tpdm_prng_out_tpda_qdss: endpoint { + remote-endpoint = + <&tpda_qdss_in_tpdm_prng>; + }; + }; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt index c68d93a35b6c..f7ce8af48574 100644 --- a/Documentation/devicetree/bindings/arm/coresight.txt +++ b/Documentation/devicetree/bindings/arm/coresight.txt @@ -52,6 +52,10 @@ its hardware characteristcs. "arm,coresight-cti", "arm,primecell"; See coresight-cti.yaml for full CTI definitions. + - Trace, Profiling and Diagnostics Monitor (TPDM): + "qcom,coresight-tpdm", "arm,primecell"; + See coresight-tpdm.yaml for full TPDM definitions. + * reg: physical base address and length of the register set(s) of the component. @@ -82,6 +86,9 @@ its hardware characteristcs. * Required properties for Coresight Cross Trigger Interface (CTI) See coresight-cti.yaml for full CTI definitions. +* Required properties for Trace, Profiling and Diagnostics Monitor (TPDM) + See coresight-tpdm.yaml for full TPDM definitions. + * Required properties for devices that don't show up on the AMBA bus, such as non-configurable replicators and non-configurable funnels: diff --git a/MAINTAINERS b/MAINTAINERS index b85ee59e808b..3527bda0e617 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1979,6 +1979,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git F: Documentation/ABI/testing/sysfs-bus-coresight-devices-* F: Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt F: Documentation/devicetree/bindings/arm/coresight-cti.yaml +F: Documentation/devicetree/bindings/arm/coresight-tpdm.yaml F: Documentation/devicetree/bindings/arm/coresight.txt F: Documentation/devicetree/bindings/arm/ete.yaml F: Documentation/devicetree/bindings/arm/trbe.yaml