From patchwork Fri Jul 15 20:36:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 12919679 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2897BCCA480 for ; Fri, 15 Jul 2022 20:37:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231397AbiGOUhR (ORCPT ); Fri, 15 Jul 2022 16:37:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231354AbiGOUhO (ORCPT ); Fri, 15 Jul 2022 16:37:14 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 080337D1F2 for ; Fri, 15 Jul 2022 13:37:14 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCS3Y-0004t9-W4; Fri, 15 Jul 2022 22:37:01 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oCS3Y-001BFe-8Q; Fri, 15 Jul 2022 22:37:00 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oCS3X-005PyJ-BJ; Fri, 15 Jul 2022 22:36:59 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Andy Gross , Bjorn Andersson , Georgi Djakov Cc: kernel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/8] interconnect: msm8974: Ignore return value of icc_provider_del() in .remove() Date: Fri, 15 Jul 2022 22:36:48 +0200 Message-Id: <20220715203652.89912-5-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220715203652.89912-1-u.kleine-koenig@pengutronix.de> References: <20220715203652.89912-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1126; h=from:subject; bh=FJpmWEXN+H+dGnE/UQ8dINtNJBHBVROLu55mJZbljTU=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBi0c+fn8V4MYO8Y+Zd92pavKNcD2A1mz6JcJosSBcZ rJbUi5GJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYtHPnwAKCRDB/BR4rcrsCdBsB/ 9kkHwaum6u26a2hQ0ySj2ctxX/0L6zjMeoDpWXFUhf/SCU7wK3d01/zw5LtAA9p2PPdIf3c0p6WpQD Pmw92i5lCmRAZrGTJEI/OaYnSIgIa4ehyPGGp/KNWUfs2q5jNMab+GVf64oOqZtzRwNzxbclktgMYT lHR5BEKD8KsD1OHrtRZusrRlwprEtGO8O1lR8a4Xz27nw6UyhVFA6NB5v95lDS3IYrWalMjCv52fxo 2XjSoSirQ3lQZQ4oJ3utTr33RYSRZd/VAwjSizn4kuGzHqvWQUVPHh1Czf+mkq/EGL1veI9yFx1vr6 qgQIQqbeJClOvQOAodMCge9QmD0nJO X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-msm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org icc_provider_del() already emits an error message on failure. In this case letting .remove() return the corresponding error code results in another error message and the device is removed anyhow. (See platform_remove().) So ignore the return value of icc_provider_del() and return 0 unconditionally. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König --- drivers/interconnect/qcom/msm8974.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/interconnect/qcom/msm8974.c b/drivers/interconnect/qcom/msm8974.c index 6fa0ad90fc3d..5ea192f1141d 100644 --- a/drivers/interconnect/qcom/msm8974.c +++ b/drivers/interconnect/qcom/msm8974.c @@ -749,7 +749,9 @@ static int msm8974_icc_remove(struct platform_device *pdev) icc_nodes_remove(&qp->provider); clk_bulk_disable_unprepare(qp->num_clks, qp->bus_clks); - return icc_provider_del(&qp->provider); + icc_provider_del(&qp->provider); + + return 0; } static const struct of_device_id msm8974_noc_of_match[] = {