From patchwork Sat Jul 30 09:40:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akhil P Oommen X-Patchwork-Id: 12932943 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 076E1C04A68 for ; Sat, 30 Jul 2022 09:42:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230209AbiG3JmM (ORCPT ); Sat, 30 Jul 2022 05:42:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237184AbiG3Jlv (ORCPT ); Sat, 30 Jul 2022 05:41:51 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6615E45F5B; Sat, 30 Jul 2022 02:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1659174105; x=1690710105; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=+nv5k6cElBg65M4Dh82ondzpZeLgEEYFpmWR1ufVNmc=; b=KlUa1wVhAS3sO52fX6WnL28qLD1HSx8Y1sv6HbLl+5oqysqDGyPIH4sH l+mclZ/BXg/a9szLVRsCsm9iIfQF0zJglqxu6e3NelZ2GoaAtHo5SkCfb h5dpLRSLgNKeJ+3B0TQYzKztq4NW4+ukb/iypkh/qJH0lp4vdqNSF1x6K o=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-02.qualcomm.com with ESMTP; 30 Jul 2022 02:41:44 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2022 02:41:44 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sat, 30 Jul 2022 02:41:43 -0700 Received: from hyd-lnxbld559.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sat, 30 Jul 2022 02:41:38 -0700 From: Akhil P Oommen To: freedreno , , , Rob Clark , Bjorn Andersson CC: Jordan Crouse , Jonathan Marek , Douglas Anderson , "Matthias Kaehlcke" , Akhil P Oommen , Abhinav Kumar , AngeloGioacchino Del Regno , Daniel Vetter , David Airlie , Dmitry Baryshkov , Nathan Chancellor , "Sean Paul" , Vladimir Lypak , Subject: [PATCH v3 6/8] drm/msm/adreno: Remove a WARN() during runtime_suspend Date: Sat, 30 Jul 2022 15:10:49 +0530 Message-ID: <20220730150952.v3.6.I3329f9e803d8c09bd017d777e5bbd2a80080295f@changeid> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1659174051-27816-1-git-send-email-quic_akhilpo@quicinc.com> References: <1659174051-27816-1-git-send-email-quic_akhilpo@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org WARN(gpu->active_submits) during runtime_suspend doesn't make sense now because we force runtime suspend during a gpu recovery when there are active submissions pending. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/adreno_device.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index 8706bcd..d1e1e8e 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -610,13 +610,6 @@ static int adreno_runtime_suspend(struct device *dev) { struct msm_gpu *gpu = dev_to_gpu(dev); - /* - * We should be holding a runpm ref, which will prevent - * runtime suspend. In the system suspend path, we've - * already waited for active jobs to complete. - */ - WARN_ON_ONCE(gpu->active_submits); - return gpu->funcs->pm_suspend(gpu); }