| Message ID | 20220822062820.1684139-1-judyhsiao@chromium.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v3] arm64: dts: qcom: sc7280: Use "PP1800_L2C" as the DMIC power source. | expand |
Hi, On Sun, Aug 21, 2022 at 11:28 PM Judy Hsiao <judyhsiao@chromium.org> wrote: > > Use "PP1800_L2C" as the DMIC power source to match the hardware > schematic by: > 1. Set MIC bias voltage regulator (vdd-micb-supply) to PP1800_L2C. > 2. In audio-routing, set VA DMIC01~VA DMIC03 to use the vdd-micb-supply > setting. > > It fixes the DMIC no sound issue of villager-r1. > > Co-developed-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > Signed-off-by: Judy Hsiao <judyhsiao@chromium.org> > --- > Changes since V2: > -- Update the commit message. > Changes since V1: > -- Update the commit message. > > This patch depends on: > arm64: dts: qcom: sc7280: Add herobrine-villager-r1. [1] > > [1] https://patchwork.kernel.org/patch/12926099/ > > .../dts/qcom/sc7280-herobrine-villager-r1.dts | 28 +++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts > index c03b3ae4de50..983defa7c76d 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts > @@ -12,3 +12,31 @@ / { > model = "Google Villager (rev1+)"; > compatible = "google,villager", "qcom,sc7280"; > }; > + > +&lpass_va_macro { > + vdd-micb-supply = <&pp1800_l2c>; > +}; > + > +&sound { > + audio-routing = > + "IN1_HPHL", "HPHL_OUT", > + "IN2_HPHR", "HPHR_OUT", > + "AMIC1", "MIC BIAS1", > + "AMIC2", "MIC BIAS2", > + "VA DMIC0", "vdd-micb", > + "VA DMIC1", "vdd-micb", > + "VA DMIC2", "vdd-micb", > + "VA DMIC3", "vdd-micb", > + "TX SWR_ADC0", "ADC1_OUTPUT", > + "TX SWR_ADC1", "ADC2_OUTPUT", > + "TX SWR_ADC2", "ADC3_OUTPUT", > + "TX SWR_DMIC0", "DMIC1_OUTPUT", > + "TX SWR_DMIC1", "DMIC2_OUTPUT", > + "TX SWR_DMIC2", "DMIC3_OUTPUT", > + "TX SWR_DMIC3", "DMIC4_OUTPUT", > + "TX SWR_DMIC4", "DMIC5_OUTPUT", > + "TX SWR_DMIC5", "DMIC6_OUTPUT", > + "TX SWR_DMIC6", "DMIC7_OUTPUT", > + "TX SWR_DMIC7", "DMIC8_OUTPUT"; > + > +}; nit: there's an extra blank line here. Can you send a v4 to fix? Other than that this looks OK to me, but I suspect that Bjorn will have a hard time applying this without help. I think someone who is keeping track of all the audio patches is going to need to provide a list (or a sample tree) showing what needs to be applied and in what order. It would be good to confirm that there aren't any outstanding issues on any of the patches as well. We really don't want to go another cycle without getting the audio patches landed. -Doug
Quoting Judy Hsiao (2022-08-21 23:28:20) > Use "PP1800_L2C" as the DMIC power source to match the hardware > schematic by: > 1. Set MIC bias voltage regulator (vdd-micb-supply) to PP1800_L2C. > 2. In audio-routing, set VA DMIC01~VA DMIC03 to use the vdd-micb-supply > setting. > > It fixes the DMIC no sound issue of villager-r1. > > Co-developed-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > Signed-off-by: Judy Hsiao <judyhsiao@chromium.org> Please remove the period from the end of the subject, and maybe make the subject something like "Fix audio on Villager" because it does more than set the power source.
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts index c03b3ae4de50..983defa7c76d 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts @@ -12,3 +12,31 @@ / { model = "Google Villager (rev1+)"; compatible = "google,villager", "qcom,sc7280"; }; + +&lpass_va_macro { + vdd-micb-supply = <&pp1800_l2c>; +}; + +&sound { + audio-routing = + "IN1_HPHL", "HPHL_OUT", + "IN2_HPHR", "HPHR_OUT", + "AMIC1", "MIC BIAS1", + "AMIC2", "MIC BIAS2", + "VA DMIC0", "vdd-micb", + "VA DMIC1", "vdd-micb", + "VA DMIC2", "vdd-micb", + "VA DMIC3", "vdd-micb", + "TX SWR_ADC0", "ADC1_OUTPUT", + "TX SWR_ADC1", "ADC2_OUTPUT", + "TX SWR_ADC2", "ADC3_OUTPUT", + "TX SWR_DMIC0", "DMIC1_OUTPUT", + "TX SWR_DMIC1", "DMIC2_OUTPUT", + "TX SWR_DMIC2", "DMIC3_OUTPUT", + "TX SWR_DMIC3", "DMIC4_OUTPUT", + "TX SWR_DMIC4", "DMIC5_OUTPUT", + "TX SWR_DMIC5", "DMIC6_OUTPUT", + "TX SWR_DMIC6", "DMIC7_OUTPUT", + "TX SWR_DMIC7", "DMIC8_OUTPUT"; + +};
Use "PP1800_L2C" as the DMIC power source to match the hardware schematic by: 1. Set MIC bias voltage regulator (vdd-micb-supply) to PP1800_L2C. 2. In audio-routing, set VA DMIC01~VA DMIC03 to use the vdd-micb-supply setting. It fixes the DMIC no sound issue of villager-r1. Co-developed-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org> --- Changes since V2: -- Update the commit message. Changes since V1: -- Update the commit message. This patch depends on: arm64: dts: qcom: sc7280: Add herobrine-villager-r1. [1] [1] https://patchwork.kernel.org/patch/12926099/ .../dts/qcom/sc7280-herobrine-villager-r1.dts | 28 +++++++++++++++++++ 1 file changed, 28 insertions(+)