| Message ID | 20220915113523.44074-1-luca.weiss@fairphone.com (mailing list archive) |
|---|---|
| State | Queued |
| Headers | show |
| Series | [v3,1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase | expand |
On 15/09/2022 14:35, Luca Weiss wrote: > There are some IDs that are written in uppercase. For consistency > convert them to lowercase. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Changes since v2: > * Split out to separate patch > > include/soc/qcom/qcom-spmi-pmic.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)
On 15/09/2022 12:35, Luca Weiss wrote: > There are some IDs that are written in uppercase. For consistency > convert them to lowercase. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org> Kind Regards, Caleb > --- > Changes since v2: > * Split out to separate patch > > include/soc/qcom/qcom-spmi-pmic.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/soc/qcom/qcom-spmi-pmic.h b/include/soc/qcom/qcom-spmi-pmic.h > index 72398ff44719..fde0148d0077 100644 > --- a/include/soc/qcom/qcom-spmi-pmic.h > +++ b/include/soc/qcom/qcom-spmi-pmic.h > @@ -29,9 +29,9 @@ > #define PM8998_SUBTYPE 0x14 > #define PMI8998_SUBTYPE 0x15 > #define PM8005_SUBTYPE 0x18 > -#define PM660L_SUBTYPE 0x1A > -#define PM660_SUBTYPE 0x1B > -#define PM8150_SUBTYPE 0x1E > +#define PM660L_SUBTYPE 0x1a > +#define PM660_SUBTYPE 0x1b > +#define PM8150_SUBTYPE 0x1e > #define PM8150L_SUBTYPE 0x1f > #define PM8150B_SUBTYPE 0x20 > #define PMK8002_SUBTYPE 0x21
On Thu, 15 Sep 2022, Luca Weiss wrote: > There are some IDs that are written in uppercase. For consistency > convert them to lowercase. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > Changes since v2: > * Split out to separate patch > > include/soc/qcom/qcom-spmi-pmic.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) These aren't MFD patches. Please reword the subject.
Hi Lee, hi Caleb On Tue Sep 20, 2022 at 9:50 AM CEST, Lee Jones wrote: > On Thu, 15 Sep 2022, Luca Weiss wrote: > > > There are some IDs that are written in uppercase. For consistency > > convert them to lowercase. > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > --- > > Changes since v2: > > * Split out to separate patch > > > > include/soc/qcom/qcom-spmi-pmic.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > These aren't MFD patches. Please reword the subject. Do you have any suggestion what subject to use then? The most I can think of is "soc: qcom: " which is sometimes used for other files in this include directory. I've used the current subject because the previous two patches touching this file had this subject also. Regards Luca > > -- > DEPRECATED: Please use lee@kernel.org
On 21/09/2022 07:12, Luca Weiss wrote: > Hi Lee, hi Caleb > > On Tue Sep 20, 2022 at 9:50 AM CEST, Lee Jones wrote: >> On Thu, 15 Sep 2022, Luca Weiss wrote: >> >>> There are some IDs that are written in uppercase. For consistency >>> convert them to lowercase. >>> >>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> >>> --- >>> Changes since v2: >>> * Split out to separate patch >>> >>> include/soc/qcom/qcom-spmi-pmic.h | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> These aren't MFD patches. Please reword the subject. > > Do you have any suggestion what subject to use then? The most I can > think of is "soc: qcom: " which is sometimes used for other files in > this include directory. > I've used the current subject because the previous two patches touching > this file had this subject also. This file just contains platform data which used to be in the qcom SPMI PMIC driver. In hindsight, maybe it would have been better suited in include/linux/mfd but I don't think it matters too much. I guess it makes sense to follow convention for the directory and treat it like the other platform headers, maybe something like: soc: qcom: spmi-pmic: convert hex numbers to lowercase > > Regards > Luca > >> >> -- >> DEPRECATED: Please use lee@kernel.org >
On Wed, 21 Sep 2022, Caleb Connolly wrote: > > > On 21/09/2022 07:12, Luca Weiss wrote: > > Hi Lee, hi Caleb > > > > On Tue Sep 20, 2022 at 9:50 AM CEST, Lee Jones wrote: > > > On Thu, 15 Sep 2022, Luca Weiss wrote: > > > > > > > There are some IDs that are written in uppercase. For consistency > > > > convert them to lowercase. > > > > > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > > > --- > > > > Changes since v2: > > > > * Split out to separate patch > > > > > > > > include/soc/qcom/qcom-spmi-pmic.h | 6 +++--- > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > These aren't MFD patches. Please reword the subject. > > > > Do you have any suggestion what subject to use then? The most I can > > think of is "soc: qcom: " which is sometimes used for other files in > > this include directory. > > I've used the current subject because the previous two patches touching > > this file had this subject also. > > This file just contains platform data which used to be in the qcom SPMI > PMIC driver. In hindsight, maybe it would have been better suited in > include/linux/mfd but I don't think it matters too much. I guess it makes > sense to follow convention for the directory and treat it like the other > platform headers, maybe something like: > > soc: qcom: spmi-pmic: convert hex numbers to lowercase Agree.
diff --git a/include/soc/qcom/qcom-spmi-pmic.h b/include/soc/qcom/qcom-spmi-pmic.h index 72398ff44719..fde0148d0077 100644 --- a/include/soc/qcom/qcom-spmi-pmic.h +++ b/include/soc/qcom/qcom-spmi-pmic.h @@ -29,9 +29,9 @@ #define PM8998_SUBTYPE 0x14 #define PMI8998_SUBTYPE 0x15 #define PM8005_SUBTYPE 0x18 -#define PM660L_SUBTYPE 0x1A -#define PM660_SUBTYPE 0x1B -#define PM8150_SUBTYPE 0x1E +#define PM660L_SUBTYPE 0x1a +#define PM660_SUBTYPE 0x1b +#define PM8150_SUBTYPE 0x1e #define PM8150L_SUBTYPE 0x1f #define PM8150B_SUBTYPE 0x20 #define PMK8002_SUBTYPE 0x21
There are some IDs that are written in uppercase. For consistency convert them to lowercase. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- Changes since v2: * Split out to separate patch include/soc/qcom/qcom-spmi-pmic.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)