| Message ID | 20220926112200.1948080-1-bhupesh.sharma@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2] dt-bindings: dma: Make minor fixes to qcom,bam-dma binding doc | expand |
On 26/09/2022 13:22, Bhupesh Sharma wrote: > As a user recently noted, the qcom,bam-dma binding document > describes the msm8974 BAM DMA node in the 'example section' > incorrectly. Fix the same by making it consistent with the node > present inside 'qcom-msm8974' dts file, namely the 'reg' and > 'interrupt' values which are incorrect in the 'example section'. > > While at it also make two additioanal minor cleanups: > - mention Bjorn's new email ID in the document, and > - add SDM845 in the comment line for the SoCs on which > qcom,bam-v1.7.0 version is supported. > > Fixes: 4f46cc1b88b3 ("dt-bindings: dma: Convert Qualcomm BAM DMA binding to json format") I don't think examples are worth backporting. Other than that: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 26-09-22, 16:52, Bhupesh Sharma wrote: > As a user recently noted, the qcom,bam-dma binding document > describes the msm8974 BAM DMA node in the 'example section' > incorrectly. Fix the same by making it consistent with the node > present inside 'qcom-msm8974' dts file, namely the 'reg' and > 'interrupt' values which are incorrect in the 'example section'. > > While at it also make two additioanal minor cleanups: > - mention Bjorn's new email ID in the document, and > - add SDM845 in the comment line for the SoCs on which > qcom,bam-v1.7.0 version is supported. Applied, thanks > > Fixes: 4f46cc1b88b3 ("dt-bindings: dma: Convert Qualcomm BAM DMA binding to json format") Dropped this
diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml index 9bf3a1b164f1..003098caf709 100644 --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml @@ -8,7 +8,7 @@ title: Qualcomm Technologies Inc BAM DMA controller maintainers: - Andy Gross <agross@kernel.org> - - Bjorn Andersson <bjorn.andersson@linaro.org> + - Bjorn Andersson <andersson@kernel.org> allOf: - $ref: "dma-controller.yaml#" @@ -20,7 +20,7 @@ properties: - qcom,bam-v1.3.0 # MSM8974, APQ8074 and APQ8084 - qcom,bam-v1.4.0 - # MSM8916 + # MSM8916 and SDM845 - qcom,bam-v1.7.0 clocks: @@ -90,8 +90,8 @@ examples: dma-controller@f9944000 { compatible = "qcom,bam-v1.4.0"; - reg = <0xf9944000 0x15000>; - interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>; + reg = <0xf9944000 0x19000>; + interrupts = <GIC_SPI 239 IRQ_TYPE_LEVEL_HIGH>; clocks = <&gcc GCC_BLSP2_AHB_CLK>; clock-names = "bam_clk"; #dma-cells = <1>;
As a user recently noted, the qcom,bam-dma binding document describes the msm8974 BAM DMA node in the 'example section' incorrectly. Fix the same by making it consistent with the node present inside 'qcom-msm8974' dts file, namely the 'reg' and 'interrupt' values which are incorrect in the 'example section'. While at it also make two additioanal minor cleanups: - mention Bjorn's new email ID in the document, and - add SDM845 in the comment line for the SoCs on which qcom,bam-v1.7.0 version is supported. Fixes: 4f46cc1b88b3 ("dt-bindings: dma: Convert Qualcomm BAM DMA binding to json format") Cc: konrad.dybcio@somainline.org Cc: robh+dt@kernel.org Cc: andersson@kernel.org Cc: krzysztof.kozlowski@linaro.org Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- - v1 can be seen here: https://lore.kernel.org/all/20220918081119.295364-1-bhupesh.sharma@linaro.org/ - Fixed Krzysztof's comments on v1 regarding describing the problem more clearly in the commit log. Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)