| Message ID | 20220926190148.283805-2-marijn.suijten@somainline.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add Qcom PM6125 PMIC and use in Sony Xperia Seine PDX201 | expand |
On 26/09/2022 21:01, Marijn Suijten wrote: > Document support for the pm6125, typically paired with the sm6125 SoC. > > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 + > 1 file changed, 1 insertion(+) Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 If a tag was not added on purpose, please state why and what changed. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 2022-09-28 09:35:40, Krzysztof Kozlowski wrote: > On 26/09/2022 21:01, Marijn Suijten wrote: > > Document support for the pm6125, typically paired with the sm6125 SoC. > > > > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > > --- > > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. > > https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 > > If a tag was not added on purpose, please state why and what changed. > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> https://lore.kernel.org/linux-arm-msm/0ec65132-7d7a-2f8d-cc16-cb76efc343d6@linaro.org/ Thanks, I thought of it this morning while browsing lore, but only got to a screen just now so you beat me to it by ~30 minutes. No need to lecture me on the rules, but I can't promise this won't happen again. - Marijn
On 28/09/2022 10:10, Marijn Suijten wrote: > On 2022-09-28 09:35:40, Krzysztof Kozlowski wrote: >> On 26/09/2022 21:01, Marijn Suijten wrote: >>> Document support for the pm6125, typically paired with the sm6125 SoC. >>> >>> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> >>> --- >>> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 + >>> 1 file changed, 1 insertion(+) >> >> >> Please add Acked-by/Reviewed-by tags when posting new versions. However, >> there's no need to repost patches *only* to add the tags. The upstream >> maintainer will do that for acks received on the version they apply. >> >> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 >> >> If a tag was not added on purpose, please state why and what changed. >> >> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > https://lore.kernel.org/linux-arm-msm/0ec65132-7d7a-2f8d-cc16-cb76efc343d6@linaro.org/ > > Thanks, I thought of it this morning while browsing lore, but only got > to a screen just now so you beat me to it by ~30 minutes. > > No need to lecture me on the rules, but I can't promise this won't > happen again. This is a automated message, don't get it too personal. A lot of people are not aware they have to do it, so I just one, same reply. I don't know whether you are aware of the process and just forgot to include it. If that's the case, just ignore the message. Best regards, Krzysztof
On 2022-09-28 10:14:05, Krzysztof Kozlowski wrote: > On 28/09/2022 10:10, Marijn Suijten wrote: > > On 2022-09-28 09:35:40, Krzysztof Kozlowski wrote: > >> On 26/09/2022 21:01, Marijn Suijten wrote: > >>> Document support for the pm6125, typically paired with the sm6125 SoC. > >>> > >>> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > >>> --- > >>> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 + > >>> 1 file changed, 1 insertion(+) > >> > >> > >> Please add Acked-by/Reviewed-by tags when posting new versions. However, > >> there's no need to repost patches *only* to add the tags. The upstream > >> maintainer will do that for acks received on the version they apply. > >> > >> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 > >> > >> If a tag was not added on purpose, please state why and what changed. > >> > >> > >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > https://lore.kernel.org/linux-arm-msm/0ec65132-7d7a-2f8d-cc16-cb76efc343d6@linaro.org/ > > > > Thanks, I thought of it this morning while browsing lore, but only got > > to a screen just now so you beat me to it by ~30 minutes. > > > > No need to lecture me on the rules, but I can't promise this won't > > happen again. > > > This is a automated message, don't get it too personal. A lot of people > are not aware they have to do it, so I just one, same reply. I don't > know whether you are aware of the process and just forgot to include it. > If that's the case, just ignore the message. That's useful, what software are you using for this? Perhaps I can run it as well, both to preempt myself and others. (Side-note: I should get accustomed to `b4 shazam` to automatically pick this up from the list, instead of rebasing / re-applying local patches) - Marijn
On 28/09/2022 10:23, Marijn Suijten wrote: >> >> >> This is a automated message, don't get it too personal. A lot of people >> are not aware they have to do it, so I just one, same reply. I don't >> know whether you are aware of the process and just forgot to include it. >> If that's the case, just ignore the message. > > That's useful, what software are you using for this? Perhaps I can run > it as well, both to preempt myself and others. https://gitlab.com/robherring/pw-utils/-/blob/master/mail-add-acks-reply https://gitlab.com/robherring/pw-utils/-/blob/master/pw-review#L97 > (Side-note: I should get accustomed to `b4 shazam` to automatically pick > this up from the list, instead of rebasing / re-applying local patches) Would be nice if b4 could update patches in current branch adding the tags... but git reset --hard && b4 shazam should work as well. Best regards, Krzysztof
On Wed, Sep 28, 2022 at 10:30:00AM +0200, Krzysztof Kozlowski wrote: > > (Side-note: I should get accustomed to `b4 shazam` to automatically pick > > this up from the list, instead of rebasing / re-applying local patches) > > Would be nice if b4 could update patches in current branch adding the > tags... but git reset --hard && b4 shazam should work as well. FYI, it can do just that using "b4 trailers -uF [msgid]". See: https://b4.docs.kernel.org/en/stable-0.10.y/contributor/trailers.html -K
On 28/09/2022 17:44, Konstantin Ryabitsev wrote: > On Wed, Sep 28, 2022 at 10:30:00AM +0200, Krzysztof Kozlowski wrote: >>> (Side-note: I should get accustomed to `b4 shazam` to automatically pick >>> this up from the list, instead of rebasing / re-applying local patches) >> >> Would be nice if b4 could update patches in current branch adding the >> tags... but git reset --hard && b4 shazam should work as well. > > FYI, it can do just that using "b4 trailers -uF [msgid]". See: > https://b4.docs.kernel.org/en/stable-0.10.y/contributor/trailers.html Wow, that's cool! Thanks! Best regards, Krzysztof
On 2022-09-28 11:44:37, Konstantin Ryabitsev wrote: > On Wed, Sep 28, 2022 at 10:30:00AM +0200, Krzysztof Kozlowski wrote: > > > (Side-note: I should get accustomed to `b4 shazam` to automatically pick > > > this up from the list, instead of rebasing / re-applying local patches) > > > > Would be nice if b4 could update patches in current branch adding the > > tags... but git reset --hard && b4 shazam should work as well. > > FYI, it can do just that using "b4 trailers -uF [msgid]". See: > https://b4.docs.kernel.org/en/stable-0.10.y/contributor/trailers.html That's super cool and will save a lot of time. I'll also have to get accustomed to `b4 prep` and `b4 send`, though typically prefer to look at the `diff` between two `format-patch` revisions to make sure the changelog is complete and no erratic changes made it in. - Marijn
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml index 6a3e3ede1ede..a5edab6f2e40 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml @@ -33,6 +33,7 @@ properties: compatible: items: - enum: + - qcom,pm6125 - qcom,pm6150 - qcom,pm6150l - qcom,pm6350
Document support for the pm6125, typically paired with the sm6125 SoC. Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> --- Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 + 1 file changed, 1 insertion(+)