diff mbox series

[4/5] soc: qcom: rpmhpd: Add QDU1000/QRU1000 power domains

Message ID 20221001030641.29354-5-quic_molvera@quicinc.com (mailing list archive)
State Superseded
Headers show
Series Add misc support for QDU1000/QRU1000 SoCs | expand

Commit Message

Melody Olvera Oct. 1, 2022, 3:06 a.m. UTC
Add the power domains exposed by RPMH in the Qualcomm QDU1000
and QRU1000 platforms.

Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
 drivers/soc/qcom/rpmhpd.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Dmitry Baryshkov Oct. 1, 2022, 7:50 a.m. UTC | #1
On 01/10/2022 06:06, Melody Olvera wrote:
> Add the power domains exposed by RPMH in the Qualcomm QDU1000
> and QRU1000 platforms.
> 
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> ---
>   drivers/soc/qcom/rpmhpd.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
> index 092f6ab09acf..f70573cbc636 100644
> --- a/drivers/soc/qcom/rpmhpd.c
> +++ b/drivers/soc/qcom/rpmhpd.c
> @@ -353,6 +353,19 @@ static const struct rpmhpd_desc sm8450_desc = {
>   	.num_pds = ARRAY_SIZE(sm8450_rpmhpds),
>   };
>   
> +/* QDU1000/QRU1000 RPMH powerdomains */
> +static struct rpmhpd *qdru1000_rpmhpds[] = {
> +	[QDRU1000_CX] = &cx,
> +	[QDRU1000_EBI] = &ebi,
> +	[QDRU1000_MSS] = &mss,
> +	[QDRU1000_MX] = &mx,
> +};
> +
> +static const struct rpmhpd_desc qdru1000_desc = {
> +	.rpmhpds = qdru1000_rpmhpds,
> +	.num_pds = ARRAY_SIZE(qdru1000_rpmhpds),
> +};
> +
>   /* SC7180 RPMH powerdomains */
>   static struct rpmhpd *sc7180_rpmhpds[] = {
>   	[SC7180_CX] = &cx_w_mx_parent,
Bjorn Andersson Oct. 7, 2022, 3:11 a.m. UTC | #2
On Fri, Sep 30, 2022 at 08:06:40PM -0700, Melody Olvera wrote:
> Add the power domains exposed by RPMH in the Qualcomm QDU1000
> and QRU1000 platforms.
> 
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
>  drivers/soc/qcom/rpmhpd.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
> index 092f6ab09acf..f70573cbc636 100644
> --- a/drivers/soc/qcom/rpmhpd.c
> +++ b/drivers/soc/qcom/rpmhpd.c
> @@ -353,6 +353,19 @@ static const struct rpmhpd_desc sm8450_desc = {
>  	.num_pds = ARRAY_SIZE(sm8450_rpmhpds),
>  };
>  
> +/* QDU1000/QRU1000 RPMH powerdomains */
> +static struct rpmhpd *qdru1000_rpmhpds[] = {
> +	[QDRU1000_CX] = &cx,
> +	[QDRU1000_EBI] = &ebi,
> +	[QDRU1000_MSS] = &mss,
> +	[QDRU1000_MX] = &mx,
> +};
> +
> +static const struct rpmhpd_desc qdru1000_desc = {
> +	.rpmhpds = qdru1000_rpmhpds,
> +	.num_pds = ARRAY_SIZE(qdru1000_rpmhpds),
> +};
> +

Looks like you missed adding a (or two) entires to rpmhpd_match_table.

Regards,
Bjorn

>  /* SC7180 RPMH powerdomains */
>  static struct rpmhpd *sc7180_rpmhpds[] = {
>  	[SC7180_CX] = &cx_w_mx_parent,
> -- 
> 2.37.3
>
Melody Olvera Oct. 12, 2022, 8:32 p.m. UTC | #3
On 10/6/2022 8:11 PM, Bjorn Andersson wrote:
> On Fri, Sep 30, 2022 at 08:06:40PM -0700, Melody Olvera wrote:
>> Add the power domains exposed by RPMH in the Qualcomm QDU1000
>> and QRU1000 platforms.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>>  drivers/soc/qcom/rpmhpd.c | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>
>> diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
>> index 092f6ab09acf..f70573cbc636 100644
>> --- a/drivers/soc/qcom/rpmhpd.c
>> +++ b/drivers/soc/qcom/rpmhpd.c
>> @@ -353,6 +353,19 @@ static const struct rpmhpd_desc sm8450_desc = {
>>  	.num_pds = ARRAY_SIZE(sm8450_rpmhpds),
>>  };
>>  
>> +/* QDU1000/QRU1000 RPMH powerdomains */
>> +static struct rpmhpd *qdru1000_rpmhpds[] = {
>> +	[QDRU1000_CX] = &cx,
>> +	[QDRU1000_EBI] = &ebi,
>> +	[QDRU1000_MSS] = &mss,
>> +	[QDRU1000_MX] = &mx,
>> +};
>> +
>> +static const struct rpmhpd_desc qdru1000_desc = {
>> +	.rpmhpds = qdru1000_rpmhpds,
>> +	.num_pds = ARRAY_SIZE(qdru1000_rpmhpds),
>> +};
>> +
> Looks like you missed adding a (or two) entires to rpmhpd_match_table.
So I did. Will add.
>
> Regards,
> Bjorn
>
>>  /* SC7180 RPMH powerdomains */
>>  static struct rpmhpd *sc7180_rpmhpds[] = {
>>  	[SC7180_CX] = &cx_w_mx_parent,
>> -- 
>> 2.37.3
>>
Thanks,
Melody
diff mbox series

Patch

diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
index 092f6ab09acf..f70573cbc636 100644
--- a/drivers/soc/qcom/rpmhpd.c
+++ b/drivers/soc/qcom/rpmhpd.c
@@ -353,6 +353,19 @@  static const struct rpmhpd_desc sm8450_desc = {
 	.num_pds = ARRAY_SIZE(sm8450_rpmhpds),
 };
 
+/* QDU1000/QRU1000 RPMH powerdomains */
+static struct rpmhpd *qdru1000_rpmhpds[] = {
+	[QDRU1000_CX] = &cx,
+	[QDRU1000_EBI] = &ebi,
+	[QDRU1000_MSS] = &mss,
+	[QDRU1000_MX] = &mx,
+};
+
+static const struct rpmhpd_desc qdru1000_desc = {
+	.rpmhpds = qdru1000_rpmhpds,
+	.num_pds = ARRAY_SIZE(qdru1000_rpmhpds),
+};
+
 /* SC7180 RPMH powerdomains */
 static struct rpmhpd *sc7180_rpmhpds[] = {
 	[SC7180_CX] = &cx_w_mx_parent,