From patchwork Thu Oct 6 14:55:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 13000459 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E55D7C433FE for ; Thu, 6 Oct 2022 14:56:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230089AbiJFO4T (ORCPT ); Thu, 6 Oct 2022 10:56:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231219AbiJFO4Q (ORCPT ); Thu, 6 Oct 2022 10:56:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D1C29AFE0 for ; Thu, 6 Oct 2022 07:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665068174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hvu927jcP5VOBqnit88bPG8K5LsmKJyGG9EvVu5KyBM=; b=aCEBDeflMlDv7GxLn7Fu2A0xtCaMDDSK4xYOJMQb2zSFr/YTx/QVs+XslVU3d+P+dgJZYZ 9/bjm9Go0AUoHNiwv+CqqBxNVvfaz3s+2ZGUgFql4EmpV+u4JFgLQWsY+vKpXTPDXo/KB/ q+WnxBxYIXE13M91fdpFCm7EKljoM2Y= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-86-VpuFv-J3MUia3KyCSxE_CQ-1; Thu, 06 Oct 2022 10:56:07 -0400 X-MC-Unique: VpuFv-J3MUia3KyCSxE_CQ-1 Received: by mail-il1-f199.google.com with SMTP id j29-20020a056e02219d00b002f9b13c40c5so1702805ila.21 for ; Thu, 06 Oct 2022 07:55:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hvu927jcP5VOBqnit88bPG8K5LsmKJyGG9EvVu5KyBM=; b=dNLdxbehy5LLb2YiAoqW5cfSxRRzB+mhGD5CxxrbmDeEoww4LV1/uR6Ukc7WP10TyK 3hXEc3wBoeeIroAIt6Y5FeugGbRPOvx0Pih/Qmcv27oGOhnXyCCyT6OTGKAJvUPbKkom /HqWONc2CN/XW2qhLBjN/hvF2U3DzVhKbmesc99+e+L7VDjP/gJy8Dw3dxU0h0uS4cdn +7O4iaDSxNXoh9/STW6wK5e+oB2PBz1sAXcQIGVPtU+hDnI4xFFcQVvev4q5o5E6T4iU LX5epxca+bYifx4YvY+hf4FUK/WoDY63I7V3wr2jGw+VDwW2B6LJ/Jzqa2jra72LwBa5 YNsg== X-Gm-Message-State: ACrzQf20shDKcPTZLtTp0oikVPbfOS/4J+iawAzaKVJPn26i4d8zZnwa jPDayYCokQL5Vg4O2Z6p5CkI3gb5OCmeov2OK0LvViiYRh9MDuNEaTcgTWo/Z5cHCG/1vz/51c0 E6WzqXAZg6GZqHU1eRDJ4gqq1bQ== X-Received: by 2002:a05:6638:248f:b0:363:73fc:cc17 with SMTP id x15-20020a056638248f00b0036373fccc17mr40632jat.257.1665068143918; Thu, 06 Oct 2022 07:55:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6lCbCh+MPmTjfqYkLRJfeMy/CGiv6Cjxm/4a1eaZr5AusJ2YLiO8ihXN7k4fKIotEsuCwJjw== X-Received: by 2002:a05:6638:248f:b0:363:73fc:cc17 with SMTP id x15-20020a056638248f00b0036373fccc17mr40624jat.257.1665068143639; Thu, 06 Oct 2022 07:55:43 -0700 (PDT) Received: from x1.. (c-98-239-145-235.hsd1.wv.comcast.net. [98.239.145.235]) by smtp.gmail.com with ESMTPSA id z2-20020a05660229c200b006884b050a0asm7848669ioq.18.2022.10.06.07.55.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 07:55:43 -0700 (PDT) From: Brian Masney To: andersson@kernel.org Cc: agross@kernel.org, konrad.dybcio@somainline.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ahalaney@redhat.com, echanude@redhat.com, johan+linaro@kernel.org Subject: [PATCH v4] arm64: dts: qcom: sc8280xp: correct ref clock for ufs_mem_phy Date: Thu, 6 Oct 2022 10:55:29 -0400 Message-Id: <20221006145529.755521-1-bmasney@redhat.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The first UFS host controller fails to start on the SA8540P automotive board (QDrive3) due to the following errors: ufshcd-qcom 1d84000.ufs: ufshcd_query_flag: Sending flag query for idn 18 failed, err = 253 ufshcd-qcom 1d84000.ufs: ufshcd_query_flag: Sending flag query for idn 18 failed, err = 253 ufshcd-qcom 1d84000.ufs: ufshcd_query_flag: Sending flag query for idn 18 failed, err = 253 ufshcd-qcom 1d84000.ufs: ufshcd_query_flag_retry: query attribute, opcode 5, idn 18, failed with error 253 after 3 retries The system eventually fails to boot with the warning: gcc_ufs_phy_axi_clk status stuck at 'off' This issue can be worked around by adding clk_ignore_unused to the kernel command line since the system firmware sets up this clock for us. Let's fix this issue by updating the ref clock on ufs_mem_phy. Note that the downstream MSM 5.4 sources list this as ref_clk_parent. With this patch, the SA8540P is able to be booted without clk_ignore_unused. Signed-off-by: Brian Masney Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") Tested-by: Johan Hovold Reviewed-by: Johan Hovold --- Changes since v3: - Renamed ref_aux to ref in patch subject. Added Johan's R-b and T-b. v3 of this patch can be found at https://lore.kernel.org/lkml/20220830180120.2082734-1-bmasney@redhat.com/ v2 of this patch can be found at https://lore.kernel.org/lkml/20220825163755.683843-1-bmasney@redhat.com/T/#u v1 of this patch can be found at https://lore.kernel.org/lkml/20220623142837.3140680-1-bmasney@redhat.com/T/#u arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index c32bcded2aef..006b9a13bc2f 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -891,7 +891,7 @@ ufs_mem_phy: phy@1d87000 { ranges; clock-names = "ref", "ref_aux"; - clocks = <&rpmhcc RPMH_CXO_CLK>, + clocks = <&gcc GCC_UFS_REF_CLKREF_CLK>, <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; resets = <&ufs_mem_hc 0>;