diff mbox series

[v3,1/2] dt-bindings: qcom: smp2p: Add WPSS node names to pattern property

Message ID 20221017125346.3691-2-quic_mpubbise@quicinc.com (mailing list archive)
State Accepted, archived
Headers show
Series arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750 | expand

Commit Message

Manikanta Pubbisetty Oct. 17, 2022, 12:53 p.m. UTC
WLAN firmware uses SMP2P protocol in order to talk to the application
processor (AP) in certain cases like WoW (Wake on Wireless). WLAN
firmware runs on the WPSS Q6 processor (Wireless Processor SubSystem).
Therefore it is required to have sub nodes pertaining to the WPSS Q6
processor and the application processor in the SMP2P node.

Add WPSS Q6 (Wireless Processor SubSystem) node names to the pattern
property required for WPSS Q6 processor to communicate to the
application processor and vice versa over SMP2P protocol.

Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
---
 Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Oct. 18, 2022, 2:06 a.m. UTC | #1
On 17/10/2022 08:53, Manikanta Pubbisetty wrote:
> WLAN firmware uses SMP2P protocol in order to talk to the application
> processor (AP) in certain cases like WoW (Wake on Wireless). WLAN
> firmware runs on the WPSS Q6 processor (Wireless Processor SubSystem).
> Therefore it is required to have sub nodes pertaining to the WPSS Q6
> processor and the application processor in the SMP2P node.
> 
> Add WPSS Q6 (Wireless Processor SubSystem) node names to the pattern
> property required for WPSS Q6 processor to communicate to the
> application processor and vice versa over SMP2P protocol.
> 
> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Krzysztof Kozlowski Oct. 18, 2022, 2:07 a.m. UTC | #2
On 17/10/2022 22:06, Krzysztof Kozlowski wrote:
> On 17/10/2022 08:53, Manikanta Pubbisetty wrote:
>> WLAN firmware uses SMP2P protocol in order to talk to the application
>> processor (AP) in certain cases like WoW (Wake on Wireless). WLAN
>> firmware runs on the WPSS Q6 processor (Wireless Processor SubSystem).
>> Therefore it is required to have sub nodes pertaining to the WPSS Q6
>> processor and the application processor in the SMP2P node.
>>
>> Add WPSS Q6 (Wireless Processor SubSystem) node names to the pattern
>> property required for WPSS Q6 processor to communicate to the
>> application processor and vice versa over SMP2P protocol.
>>
>> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
> 
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Ah and I almost forgot: thank you for detailed explanation in the commit
msg. Much appreciated!

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.yaml
index 795bd8cd4104..58500529b90f 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.yaml
@@ -60,7 +60,7 @@  properties:
       Two identifiers of the inbound and outbound smem items used for this edge.
 
 patternProperties:
-  "^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap$":
+  "^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap|wlan-ap-to-wpss|wlan-wpss-to-ap$":
     type: object
     description:
       Each SMP2P pair contain a set of inbound and outbound entries, these are