diff mbox series

ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1

Message ID 20221024233817.27410-1-ansuelsmth@gmail.com (mailing list archive)
State Accepted
Headers show
Series ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1 | expand

Commit Message

Christian Marangi Oct. 24, 2022, 11:38 p.m. UTC 
It was reported non working mmc with this option enabled.
Both mmc for ipq8064 are supplied by a fixed 3.3v regulator so mmc can't
be run at 1.8v.
Disable it to restore correct functionality of this SoC feature.

Tested-by: Hendrik Koerner <koerhen@web.de>
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 arch/arm/boot/dts/qcom-ipq8064.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Brian Norris Nov. 6, 2022, 8:01 a.m. UTC | #1 
On Tue, Oct 25, 2022 at 01:38:17AM +0200, Christian Marangi wrote:
> It was reported non working mmc with this option enabled.
> Both mmc for ipq8064 are supplied by a fixed 3.3v regulator so mmc can't
> be run at 1.8v.
> Disable it to restore correct functionality of this SoC feature.
> 
> Tested-by: Hendrik Koerner <koerhen@web.de>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>

Perhaps there's some board where this property makes sense, but it seems
like something that should be added when needed in the leaf DTS, and not
supplied in the base DTSI. So:

Reviewed-by: Brian Norris <computersforpeace@gmail.com>

This also fixes problems I've seen on my systems, so:

Tested-by: Brian Norris <computersforpeace@gmail.com>

Thanks!
Bjorn Andersson Nov. 7, 2022, 3:11 a.m. UTC | #2 
On Tue, 25 Oct 2022 01:38:17 +0200, Christian Marangi wrote:
> It was reported non working mmc with this option enabled.
> Both mmc for ipq8064 are supplied by a fixed 3.3v regulator so mmc can't
> be run at 1.8v.
> Disable it to restore correct functionality of this SoC feature.
> 
> 

Applied, thanks!

[1/1] ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1
      commit: c9713e4ede1e5d044b64fe4d3cbb84223625637f

Best regards,
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
index 90c08b51680a..01ff24560ee6 100644
--- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
@@ -756,7 +756,6 @@  sdcc1: mmc@12400000 {
 				non-removable;
 				cap-sd-highspeed;
 				cap-mmc-highspeed;
-				mmc-ddr-1_8v;
 				vmmc-supply = <&vsdcc_fixed>;
 				dmas = <&sdcc1bam 2>, <&sdcc1bam 1>;
 				dma-names = "tx", "rx";