| Message ID | 20221108201625.1220919-1-elder@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | arm64: dts: qcom: sc7280-idp: don't modify &ipa twice | expand |
On 08/11/2022 21:16, Alex Elder wrote: > In "sc7280-idp.dts", the IPA node is modified after being defined. > However that file includes "sc7280-idp.dtsi", which also modifies > the IPA node (in the same way). This only needs to be done in > "sc7280-idp.dtsi". > > Signed-off-by: Alex Elder <elder@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts > index 7559164cdda08..9ddfdfdd354ee 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts > @@ -61,11 +61,6 @@ &bluetooth { > vddio-supply = <&vreg_l19b_1p8>; > }; > > -&ipa { > - status = "okay"; > - modem-init; > -}; > - > &pmk8350_rtc { > status = "okay"; > };
On 08/11/2022 21:16, Alex Elder wrote: > In "sc7280-idp.dts", the IPA node is modified after being defined. > However that file includes "sc7280-idp.dtsi", which also modifies > the IPA node (in the same way). This only needs to be done in > "sc7280-idp.dtsi". > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, 8 Nov 2022 14:16:25 -0600, Alex Elder wrote: > In "sc7280-idp.dts", the IPA node is modified after being defined. > However that file includes "sc7280-idp.dtsi", which also modifies > the IPA node (in the same way). This only needs to be done in > "sc7280-idp.dtsi". > > Applied, thanks! [1/1] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice commit: d4d4a7c4fd5f1b802ccf329edf11a3ade69b55e0 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts index 7559164cdda08..9ddfdfdd354ee 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts @@ -61,11 +61,6 @@ &bluetooth { vddio-supply = <&vreg_l19b_1p8>; }; -&ipa { - status = "okay"; - modem-init; -}; - &pmk8350_rtc { status = "okay"; };
In "sc7280-idp.dts", the IPA node is modified after being defined. However that file includes "sc7280-idp.dtsi", which also modifies the IPA node (in the same way). This only needs to be done in "sc7280-idp.dtsi". Signed-off-by: Alex Elder <elder@linaro.org> --- arch/arm64/boot/dts/qcom/sc7280-idp.dts | 5 ----- 1 file changed, 5 deletions(-)