| Message ID | 20221110195619.1276302-2-elder@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dt-bindings: net: qcom,ipa: relax some restrictions | expand |
On 10/11/2022 20:56, Alex Elder wrote: > Commit d8604b209e9b3 ("dt-bindings: net: qcom,ipa: add firmware-name > property") added a requirement for a "firmware-name" property that > is more restrictive than necessary. > > If the AP loads GSI firmware, the name of the firmware file to use > may optionally be provided via a "firmware-name" property. If the > *modem* loads GSI firmware, "firmware-name" doesn't need to be > supplied--but it's harmless to do so (it will simply be ignored). > > Remove the unnecessary restriction, and allow "firware-name" to be > supplied even if it's not needed. > > Signed-off-by: Alex Elder <elder@linaro.org> > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 ---------- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml index dd4bb2e748800..2d253ef488188 100644 --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml @@ -162,16 +162,6 @@ oneOf: - required: - memory-region -# If memory-region is present, firmware-name may optionally be present. -# But if modem-init is present, firmware-name must not be present. -if: - required: - - modem-init -then: - not: - required: - - firmware-name - additionalProperties: false examples:
Commit d8604b209e9b3 ("dt-bindings: net: qcom,ipa: add firmware-name property") added a requirement for a "firmware-name" property that is more restrictive than necessary. If the AP loads GSI firmware, the name of the firmware file to use may optionally be provided via a "firmware-name" property. If the *modem* loads GSI firmware, "firmware-name" doesn't need to be supplied--but it's harmless to do so (it will simply be ignored). Remove the unnecessary restriction, and allow "firware-name" to be supplied even if it's not needed. Signed-off-by: Alex Elder <elder@linaro.org> --- Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 ---------- 1 file changed, 10 deletions(-)